From: Rajendra Nayak <rnayak@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tony@atomide.com, khilman@linaro.org, benoit.cousson@gmail.com,
r.sricharan@ti.com, ambresh@ti.com
Subject: Re: [PATCH 00/12] DRA7xx PRCM, hwmod and DT data
Date: Wed, 21 Aug 2013 14:46:39 +0530 [thread overview]
Message-ID: <52148577.1090105@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1308210842400.6426@utopia.booyaka.com>
On Wednesday 21 August 2013 02:25 PM, Paul Walmsley wrote:
> On Tue, 9 Jul 2013, Rajendra Nayak wrote:
>
>> This series adds the data files for DRA7xx devices for
>> PRCM, hwmod and DT. This is dependent on the core support [1]
>> patches for DRA7xx and leaves out the clock data since its
>> on its way to DT [2]
>>
>> The regbit headers for prm and cm are cleaned up post the
>> autogeneration as 95% was seen to be currently unused
>> (prm-regbits-7xx.h was 100% unused and hence removed)
>>
>> These patches along with the core support patches are available at:
>> git://github.com/rrnayak/linux.git for-3.12/dra-core-data
>
> Have glanced through these patches. The form looks okay to me. But again
> it's impossible to me to spot-check or verify almost anything in the data
> here, until some documentation is available. Nor can I verify that the
> series works here, since I don't have a DRA7xx board. It would be best
> for TI and for upstream Linux if us maintainers outside TI could at least
> test these patches, otherwise we are flying blind.
I agree Paul. There isn't a public TRM available yet but I will see if an
NDA TRM can be made available to all maintainers.
As for the boards, we are really running short of these for now due to
lower fab yield etc, but once the situation improves I will push for
boards to be shipped.
>
> One minor comment is that I think the credit information in the comments
> of the data files needs to be qualified. Instead of simply:
>
> + * Paul Walmsley (paul@pwsan.com)
> + * Rajendra Nayak (rnayak@ti.com)
> + * Benoit Cousson (b-cousson@ti.com)
>
> it would be better if it read something like:
>
> * Generated by code originally written by:
> * Paul Walmsley (paul@pwsan.com)
> * Rajendra Nayak (rnayak@ti.com)
> * Benoit Cousson (b-cousson@ti.com)
>
> or something similar. Same for the oth
a files.
>
> Are you fine with this change, or do you have some similar wording that
> you think is better? No need to repost, I'll update the patches here.
Thanks, looks fine to me.
Btw, Patch 11/12 and 12/12 of this series are already pulled in by Tony and
Benoit resp.
>
>
> - Paul
>
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/12] DRA7xx PRCM, hwmod and DT data
Date: Wed, 21 Aug 2013 14:46:39 +0530 [thread overview]
Message-ID: <52148577.1090105@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1308210842400.6426@utopia.booyaka.com>
On Wednesday 21 August 2013 02:25 PM, Paul Walmsley wrote:
> On Tue, 9 Jul 2013, Rajendra Nayak wrote:
>
>> This series adds the data files for DRA7xx devices for
>> PRCM, hwmod and DT. This is dependent on the core support [1]
>> patches for DRA7xx and leaves out the clock data since its
>> on its way to DT [2]
>>
>> The regbit headers for prm and cm are cleaned up post the
>> autogeneration as 95% was seen to be currently unused
>> (prm-regbits-7xx.h was 100% unused and hence removed)
>>
>> These patches along with the core support patches are available at:
>> git://github.com/rrnayak/linux.git for-3.12/dra-core-data
>
> Have glanced through these patches. The form looks okay to me. But again
> it's impossible to me to spot-check or verify almost anything in the data
> here, until some documentation is available. Nor can I verify that the
> series works here, since I don't have a DRA7xx board. It would be best
> for TI and for upstream Linux if us maintainers outside TI could at least
> test these patches, otherwise we are flying blind.
I agree Paul. There isn't a public TRM available yet but I will see if an
NDA TRM can be made available to all maintainers.
As for the boards, we are really running short of these for now due to
lower fab yield etc, but once the situation improves I will push for
boards to be shipped.
>
> One minor comment is that I think the credit information in the comments
> of the data files needs to be qualified. Instead of simply:
>
> + * Paul Walmsley (paul at pwsan.com)
> + * Rajendra Nayak (rnayak at ti.com)
> + * Benoit Cousson (b-cousson at ti.com)
>
> it would be better if it read something like:
>
> * Generated by code originally written by:
> * Paul Walmsley (paul at pwsan.com)
> * Rajendra Nayak (rnayak at ti.com)
> * Benoit Cousson (b-cousson at ti.com)
>
> or something similar. Same for the oth
a files.
>
> Are you fine with this change, or do you have some similar wording that
> you think is better? No need to repost, I'll update the patches here.
Thanks, looks fine to me.
Btw, Patch 11/12 and 12/12 of this series are already pulled in by Tony and
Benoit resp.
>
>
> - Paul
>
next prev parent reply other threads:[~2013-08-21 9:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 7:32 [PATCH 00/12] DRA7xx PRCM, hwmod and DT data Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 01/12] ARM: DRA7: PRM: Add DRA7XX register definitions Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 02/12] ARM: DRA7: CM: Add DRA7XX register defines Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 03/12] ARM: DRA7: CM: Add minimal regbit shifts Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 04/12] ARM: DRA7: PRCM: Add DRA7XX local MPU PRCM regsiters Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 05/12] ARM: DRA7: clockdomain: Add DRA7XX data and update header Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 06/12] ARM: DRA7: powerdomain: " Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 07/12] ARM: DRA7: powerdomain: Handle missing vc/vp Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 08/12] ARM: DRA7: Reuse the omap44xx_restart and fix the device instance Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-14 12:12 ` Kevin Hilman
2013-07-14 12:12 ` Kevin Hilman
2013-07-09 7:32 ` [PATCH 09/12] ARM: DRA7: hwmod: Create initial DRA7XX SoC data Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 8:31 ` Tony Lindgren
2013-07-09 8:31 ` Tony Lindgren
2013-07-09 10:14 ` Rajendra Nayak
2013-07-09 10:14 ` Rajendra Nayak
2013-07-09 11:36 ` Tony Lindgren
2013-07-09 11:36 ` Tony Lindgren
2013-07-15 9:22 ` Rajendra Nayak
2013-07-15 9:22 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 10/12] ARM: DRA7: Enable PM framework initializations Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 11/12] ARM: DRA7: Add the build support in omap2plus Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-07-09 7:32 ` [PATCH 12/12] ARM: DRA7: dts: Add the dts files for dra7 SoC and dra7-evm board Rajendra Nayak
2013-07-09 7:32 ` Rajendra Nayak
2013-08-21 2:10 ` [PATCH 00/12] DRA7xx PRCM, hwmod and DT data Paul Walmsley
2013-08-21 2:10 ` Paul Walmsley
2013-08-21 8:55 ` Paul Walmsley
2013-08-21 8:55 ` Paul Walmsley
2013-08-21 9:16 ` Rajendra Nayak [this message]
2013-08-21 9:16 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52148577.1090105@ti.com \
--to=rnayak@ti.com \
--cc=ambresh@ti.com \
--cc=benoit.cousson@gmail.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=r.sricharan@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.