From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>, <tony@atomide.com>,
<benoit.cousson@linaro.org>, <rnayak@ti.com>,
<peter.ujfalusi@ti.com>, <kishon@ti.com>, <jic23@cam.ac.uk>,
<grant.likely@linaro.org>, <rob.herring@calxeda.com>,
<lars@metafoo.de>, <sameo@linux.intel.com>,
<ch.naveen@samsung.com>, <poeschel@lemonage.de>,
<milo.kim@ti.com>, <balajitk@ti.com>, <gg@slimlogic.co.uk>,
<linux-iio@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree
Date: Fri, 19 Jul 2013 18:40:27 +0300 [thread overview]
Message-ID: <51E95DEB.7010702@ti.com> (raw)
In-Reply-To: <51E94F97.40002@cogentembedded.com>
On 07/19/2013 05:39 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 19-07-2013 13:27, Oleksandr Kozaruk wrote:
>
>> GPADC is the general purpose ADC present on twl6030.
>> The dt data is interrupt used to trigger end of ADC
>> conversion.
>
>> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
>> ---
>> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/twl6030.dtsi
>> b/arch/arm/boot/dts/twl6030.dtsi
>> index 2e3bd31..d7d4c28 100644
>> --- a/arch/arm/boot/dts/twl6030.dtsi
>> +++ b/arch/arm/boot/dts/twl6030.dtsi
>> @@ -103,4 +103,10 @@
>> compatible = "ti,twl6030-pwmled";
>> #pwm-cells = <2>;
>> };
>> +
>> + adc: gpadc {
>
> Read my lips: the node should be called just "adc", not "gpadc".
^^^^^^^^^^^^ Are you sure?
Why? The name was selected according to the documentation on device
"General purpose analog-to-digital converter (GPADC)".
PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Regards,
- grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: milo.kim@ti.com, lars@metafoo.de, sameo@linux.intel.com,
tony@atomide.com, poeschel@lemonage.de,
devicetree-discuss@lists.ozlabs.org, rnayak@ti.com,
Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>,
linux-kernel@vger.kernel.org, rob.herring@calxeda.com,
kishon@ti.com, peter.ujfalusi@ti.com, linux-iio@vger.kernel.org,
linux-omap@vger.kernel.org, jic23@cam.ac.uk,
grant.likely@linaro.org, benoit.cousson@linaro.org,
gg@slimlogic.co.uk, ch.naveen@samsung.com,
linux-arm-kernel@lists.infradead.org, balajitk@ti.com
Subject: Re: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree
Date: Fri, 19 Jul 2013 18:40:27 +0300 [thread overview]
Message-ID: <51E95DEB.7010702@ti.com> (raw)
In-Reply-To: <51E94F97.40002@cogentembedded.com>
On 07/19/2013 05:39 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 19-07-2013 13:27, Oleksandr Kozaruk wrote:
>
>> GPADC is the general purpose ADC present on twl6030.
>> The dt data is interrupt used to trigger end of ADC
>> conversion.
>
>> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
>> ---
>> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/twl6030.dtsi
>> b/arch/arm/boot/dts/twl6030.dtsi
>> index 2e3bd31..d7d4c28 100644
>> --- a/arch/arm/boot/dts/twl6030.dtsi
>> +++ b/arch/arm/boot/dts/twl6030.dtsi
>> @@ -103,4 +103,10 @@
>> compatible = "ti,twl6030-pwmled";
>> #pwm-cells = <2>;
>> };
>> +
>> + adc: gpadc {
>
> Read my lips: the node should be called just "adc", not "gpadc".
^^^^^^^^^^^^ Are you sure?
Why? The name was selected according to the documentation on device
"General purpose analog-to-digital converter (GPADC)".
PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Regards,
- grygorii
WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree
Date: Fri, 19 Jul 2013 18:40:27 +0300 [thread overview]
Message-ID: <51E95DEB.7010702@ti.com> (raw)
In-Reply-To: <51E94F97.40002@cogentembedded.com>
On 07/19/2013 05:39 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 19-07-2013 13:27, Oleksandr Kozaruk wrote:
>
>> GPADC is the general purpose ADC present on twl6030.
>> The dt data is interrupt used to trigger end of ADC
>> conversion.
>
>> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
>> ---
>> arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/twl6030.dtsi
>> b/arch/arm/boot/dts/twl6030.dtsi
>> index 2e3bd31..d7d4c28 100644
>> --- a/arch/arm/boot/dts/twl6030.dtsi
>> +++ b/arch/arm/boot/dts/twl6030.dtsi
>> @@ -103,4 +103,10 @@
>> compatible = "ti,twl6030-pwmled";
>> #pwm-cells = <2>;
>> };
>> +
>> + adc: gpadc {
>
> Read my lips: the node should be called just "adc", not "gpadc".
^^^^^^^^^^^^ Are you sure?
Why? The name was selected according to the documentation on device
"General purpose analog-to-digital converter (GPADC)".
PS. Following your logic - "GPIO" need to renamed to "IO" everywhere ;P
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Regards,
- grygorii
next prev parent reply other threads:[~2013-07-19 15:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 9:27 [PATCH v6 0/2] TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-19 9:27 ` Oleksandr Kozaruk
2013-07-19 9:27 ` Oleksandr Kozaruk
2013-07-19 9:27 ` [PATCH v6 1/2] ARM: dts: twl: Add GPADC data to device tree Oleksandr Kozaruk
2013-07-19 9:27 ` Oleksandr Kozaruk
2013-07-19 9:27 ` Oleksandr Kozaruk
2013-07-19 14:39 ` Sergei Shtylyov
2013-07-19 14:39 ` Sergei Shtylyov
2013-07-19 15:40 ` Grygorii Strashko [this message]
2013-07-19 15:40 ` Grygorii Strashko
2013-07-19 15:40 ` Grygorii Strashko
2013-07-19 18:18 ` Sergei Shtylyov
2013-07-19 18:18 ` Sergei Shtylyov
2013-07-19 18:18 ` Sergei Shtylyov
2013-07-20 6:14 ` Oleksandr Kozaruk
2013-07-20 6:14 ` Oleksandr Kozaruk
2013-07-19 9:27 ` [PATCH v6 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-19 9:27 ` Oleksandr Kozaruk
2013-07-19 9:27 ` Oleksandr Kozaruk
2013-07-20 10:43 ` Jonathan Cameron
2013-07-20 10:43 ` Jonathan Cameron
2013-07-20 10:43 ` Jonathan Cameron
2013-07-22 9:12 ` Oleksandr Kozaruk
2013-07-22 9:12 ` Oleksandr Kozaruk
2013-07-22 9:12 ` Oleksandr Kozaruk
2013-07-25 6:08 ` Oleksandr Kozaruk
2013-07-25 6:08 ` Oleksandr Kozaruk
2013-07-25 6:08 ` Oleksandr Kozaruk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E95DEB.7010702@ti.com \
--to=grygorii.strashko@ti.com \
--cc=balajitk@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=ch.naveen@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=kishon@ti.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=oleksandr.kozaruk@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=poeschel@lemonage.de \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.