From: Gerd Hoffmann <kraxel@redhat.com>
To: fantonifabio@tiscali.it
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <aliguori@us.ibm.com>,
xen-devel@lists.xensource.com,
"Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Alon Levy" <alevy@redhat.com>,
"Frediano Ziglio" <freddy77@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.
Date: Tue, 23 Jul 2013 13:28:30 +0200 [thread overview]
Message-ID: <51EE68DE.7080405@redhat.com> (raw)
In-Reply-To: <51EE4CE1.7060402@tiscali.it>
Hi,
> Tested-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>
> I tested it for a long time with spice on xen (because qxl will be fully
> working only after adding SSE support on hvm domUs). It works, I think
> it is good to add this and the respective vgabios patch on upstream.
>> case VBE_DISPI_INDEX_XRES:
>> - if ((val <= VBE_DISPI_MAX_XRES) && ((val & 7) == 0)) {
>> + if ((val <= VBE_DISPI_MAX_XRES) && ((val & 1) == 0)) {
>> s->vbe_regs[s->vbe_index] = val;
>> }
>> break;
It's not that simple. With 32bit depths common today it will work fine,
but for lower depths (especially those lower than 8bit) this will give
you broken scanline alignment.
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: fantonifabio@tiscali.it
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <aliguori@us.ibm.com>,
xen-devel@lists.xensource.com,
"Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Alon Levy" <alevy@redhat.com>,
"Frediano Ziglio" <freddy77@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly.
Date: Tue, 23 Jul 2013 13:28:30 +0200 [thread overview]
Message-ID: <51EE68DE.7080405@redhat.com> (raw)
In-Reply-To: <51EE4CE1.7060402@tiscali.it>
Hi,
> Tested-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>
> I tested it for a long time with spice on xen (because qxl will be fully
> working only after adding SSE support on hvm domUs). It works, I think
> it is good to add this and the respective vgabios patch on upstream.
>> case VBE_DISPI_INDEX_XRES:
>> - if ((val <= VBE_DISPI_MAX_XRES) && ((val & 7) == 0)) {
>> + if ((val <= VBE_DISPI_MAX_XRES) && ((val & 1) == 0)) {
>> s->vbe_regs[s->vbe_index] = val;
>> }
>> break;
It's not that simple. With 32bit depths common today it will work fine,
but for lower depths (especially those lower than 8bit) this will give
you broken scanline alignment.
cheers,
Gerd
next prev parent reply other threads:[~2013-07-23 11:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 18:14 [Qemu-devel] [RFC PATCH] vga: Start supporting resolution not multiple of 16 correctly Frediano Ziglio
2013-03-15 18:14 ` Frediano Ziglio
2013-03-19 13:56 ` [Qemu-devel] " Stefano Stabellini
2013-03-19 13:56 ` Stefano Stabellini
2013-05-09 14:20 ` [Qemu-devel] [Xen-devel] " Pasi Kärkkäinen
2013-05-09 14:20 ` Pasi Kärkkäinen
2013-05-10 5:52 ` [Qemu-devel] " Andreas Färber
2013-05-10 5:52 ` Andreas Färber
2013-06-18 10:17 ` [Qemu-devel] " Frediano Ziglio
2013-06-18 10:17 ` Frediano Ziglio
2013-07-23 9:29 ` [Qemu-devel] " Fabio Fantoni
2013-07-23 9:29 ` Fabio Fantoni
2013-07-23 11:28 ` Gerd Hoffmann [this message]
2013-07-23 11:28 ` Gerd Hoffmann
2013-07-28 16:56 ` [Qemu-devel] " Frediano Ziglio
2013-07-28 16:56 ` Frediano Ziglio
2013-09-25 16:12 ` [Qemu-devel] [Xen-devel] " Pasi Kärkkäinen
2013-09-25 16:12 ` Pasi Kärkkäinen
2013-10-03 12:09 ` [Qemu-devel] " Fabio Fantoni
2013-10-03 12:09 ` Fabio Fantoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EE68DE.7080405@redhat.com \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=alevy@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=fantonifabio@tiscali.it \
--cc=freddy77@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.