From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()
Date: Thu, 25 Jul 2013 10:02:21 +0000 [thread overview]
Message-ID: <51F0F7AD.5000408@cn.fujitsu.com> (raw)
In-Reply-To: <CAMuHMdVxXLrUXQno+vtHQrT_mmc9C6q42HZ6F1TujLBeEZt+Mw@mail.gmail.com>
On 07/25/2013 05:58 PM, Geert Uytterhoeven wrote:
> On Thu, Jul 25, 2013 at 5:37 AM, Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:
>> Commit e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
>> but left the variable "dev" unused, delete it.
>
> When referring to another commit, please also include the oneline summary of
> the commit, to make it easier for people to see what it's about.
Got it, thanks for your reminder.:)
>
> E.g. "Commit e21d2170f36602ae2708 ("video: remove unnecessary
> platform_set_drvdata()") removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it."
This is easier reading. I'll update it.
Regards,
Gu
>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
WARNING: multiple messages have this Message-ID (diff)
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()
Date: Thu, 25 Jul 2013 18:02:21 +0800 [thread overview]
Message-ID: <51F0F7AD.5000408@cn.fujitsu.com> (raw)
In-Reply-To: <CAMuHMdVxXLrUXQno+vtHQrT_mmc9C6q42HZ6F1TujLBeEZt+Mw@mail.gmail.com>
On 07/25/2013 05:58 PM, Geert Uytterhoeven wrote:
> On Thu, Jul 25, 2013 at 5:37 AM, Gu Zheng <guz.fnst@cn.fujitsu.com> wrote:
>> Commit e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
>> but left the variable "dev" unused, delete it.
>
> When referring to another commit, please also include the oneline summary of
> the commit, to make it easier for people to see what it's about.
Got it, thanks for your reminder.:)
>
> E.g. "Commit e21d2170f36602ae2708 ("video: remove unnecessary
> platform_set_drvdata()") removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it."
This is easier reading. I'll update it.
Regards,
Gu
>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
next prev parent reply other threads:[~2013-07-25 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 3:37 [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy() Gu Zheng
2013-07-25 3:37 ` Gu Zheng
2013-07-25 9:58 ` Geert Uytterhoeven
2013-07-25 9:58 ` Geert Uytterhoeven
2013-07-25 10:02 ` Gu Zheng [this message]
2013-07-25 10:02 ` Gu Zheng
2013-07-25 10:20 ` Luis Henriques
2013-07-25 10:20 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F0F7AD.5000408@cn.fujitsu.com \
--to=guz.fnst@cn.fujitsu.com \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.