All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Henriques <luis.henriques@canonical.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
	linux-fbdev@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()
Date: Thu, 25 Jul 2013 10:20:34 +0000	[thread overview]
Message-ID: <87siz3uej1.fsf@canonical.com> (raw)
In-Reply-To: <51F09D5E.70304@cn.fujitsu.com> (Gu Zheng's message of "Thu, 25 Jul 2013 11:37:02 +0800")

Hi,

Gu Zheng <guz.fnst@cn.fujitsu.com> writes:

> Commit 	e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it.
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
>  drivers/video/vga16fb.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>  
>  static void vga16fb_destroy(struct fb_info *info)
>  {
> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>  	iounmap(info->screen_base);
>  	fb_dealloc_cmap(&info->cmap);
>  	/* XXX unshare VGA regions */

I'm not sure if this fix isn't already queued as I sent a similar
patch a few days ago:

 https://lkml.org/lkml/2013/7/10/524

Cheers,
-- 
Luis

WARNING: multiple messages have this Message-ID (diff)
From: Luis Henriques <luis.henriques@canonical.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
	linux-fbdev@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()
Date: Thu, 25 Jul 2013 11:20:34 +0100	[thread overview]
Message-ID: <87siz3uej1.fsf@canonical.com> (raw)
In-Reply-To: <51F09D5E.70304@cn.fujitsu.com> (Gu Zheng's message of "Thu, 25 Jul 2013 11:37:02 +0800")

Hi,

Gu Zheng <guz.fnst@cn.fujitsu.com> writes:

> Commit 	e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it.
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
>  drivers/video/vga16fb.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>  
>  static void vga16fb_destroy(struct fb_info *info)
>  {
> -	struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>  	iounmap(info->screen_base);
>  	fb_dealloc_cmap(&info->cmap);
>  	/* XXX unshare VGA regions */

I'm not sure if this fix isn't already queued as I sent a similar
patch a few days ago:

 https://lkml.org/lkml/2013/7/10/524

Cheers,
-- 
Luis

  parent reply	other threads:[~2013-07-25 10:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25  3:37 [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy() Gu Zheng
2013-07-25  3:37 ` Gu Zheng
2013-07-25  9:58 ` Geert Uytterhoeven
2013-07-25  9:58   ` Geert Uytterhoeven
2013-07-25 10:02   ` Gu Zheng
2013-07-25 10:02     ` Gu Zheng
2013-07-25 10:20 ` Luis Henriques [this message]
2013-07-25 10:20   ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87siz3uej1.fsf@canonical.com \
    --to=luis.henriques@canonical.com \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.