[PATCH] video: sh7760fb: fix to pass correct device identity to free_irq()

[PATCH] video: sh7760fb: fix to pass correct device identity to free_irq()

[Wei Yongjun]

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

free_irq() expects the same device identity that was passed to
corresponding request_irq(), otherwise the IRQ is not freed.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/video/sh7760fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/sh7760fb.c b/drivers/video/sh7760fb.c
index a8c6c43..1265b25 100644
--- a/drivers/video/sh7760fb.c
+++ b/drivers/video/sh7760fb.c
@@ -567,7 +567,7 @@ static int sh7760fb_remove(struct platform_device *dev)
 	fb_dealloc_cmap(&info->cmap);
 	sh7760fb_free_mem(info);
 	if (par->irq >= 0)
-		free_irq(par->irq, par);
+		free_irq(par->irq, &par->vsync);
 	iounmap(par->base);
 	release_mem_region(par->ioarea->start, resource_size(par->ioarea));
 	framebuffer_release(info);

Re: [PATCH] video: sh7760fb: fix to pass correct device identity to free_irq()

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

On 12/07/13 16:20, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> free_irq() expects the same device identity that was passed to
> corresponding request_irq(), otherwise the IRQ is not freed.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/video/sh7760fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/sh7760fb.c b/drivers/video/sh7760fb.c
> index a8c6c43..1265b25 100644
> --- a/drivers/video/sh7760fb.c
> +++ b/drivers/video/sh7760fb.c
> @@ -567,7 +567,7 @@ static int sh7760fb_remove(struct platform_device *dev)
>  	fb_dealloc_cmap(&info->cmap);
>  	sh7760fb_free_mem(info);
>  	if (par->irq >= 0)
> -		free_irq(par->irq, par);
> +		free_irq(par->irq, &par->vsync);
>  	iounmap(par->base);
>  	release_mem_region(par->ioarea->start, resource_size(par->ioarea));
>  	framebuffer_release(info);
> 

Thanks, I've applied this into my 3.11-fixes/fbdev branch.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]