* [PATCH] video: sh7760fb: fix to pass correct device identity to free_irq()
@ 2013-07-12 13:20 Wei Yongjun
2013-07-26 8:38 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-07-12 13:20 UTC (permalink / raw)
To: linux-fbdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
free_irq() expects the same device identity that was passed to
corresponding request_irq(), otherwise the IRQ is not freed.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/video/sh7760fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/sh7760fb.c b/drivers/video/sh7760fb.c
index a8c6c43..1265b25 100644
--- a/drivers/video/sh7760fb.c
+++ b/drivers/video/sh7760fb.c
@@ -567,7 +567,7 @@ static int sh7760fb_remove(struct platform_device *dev)
fb_dealloc_cmap(&info->cmap);
sh7760fb_free_mem(info);
if (par->irq >= 0)
- free_irq(par->irq, par);
+ free_irq(par->irq, &par->vsync);
iounmap(par->base);
release_mem_region(par->ioarea->start, resource_size(par->ioarea));
framebuffer_release(info);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: sh7760fb: fix to pass correct device identity to free_irq()
2013-07-12 13:20 [PATCH] video: sh7760fb: fix to pass correct device identity to free_irq() Wei Yongjun
@ 2013-07-26 8:38 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2013-07-26 8:38 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On 12/07/13 16:20, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> free_irq() expects the same device identity that was passed to
> corresponding request_irq(), otherwise the IRQ is not freed.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/video/sh7760fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/sh7760fb.c b/drivers/video/sh7760fb.c
> index a8c6c43..1265b25 100644
> --- a/drivers/video/sh7760fb.c
> +++ b/drivers/video/sh7760fb.c
> @@ -567,7 +567,7 @@ static int sh7760fb_remove(struct platform_device *dev)
> fb_dealloc_cmap(&info->cmap);
> sh7760fb_free_mem(info);
> if (par->irq >= 0)
> - free_irq(par->irq, par);
> + free_irq(par->irq, &par->vsync);
> iounmap(par->base);
> release_mem_region(par->ioarea->start, resource_size(par->ioarea));
> framebuffer_release(info);
>
Thanks, I've applied this into my 3.11-fixes/fbdev branch.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-26 8:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-12 13:20 [PATCH] video: sh7760fb: fix to pass correct device identity to free_irq() Wei Yongjun
2013-07-26 8:38 ` Tomi Valkeinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.