* [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET
@ 2013-07-25 16:40 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2013-07-25 16:40 UTC (permalink / raw)
To: Lars-Peter Clausen, Daniel Mack
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Grant Likely, Rob Herring, device-drivers-devel, alsa-devel,
devicetree, kernel-janitors
ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and
not an unsigned long. The current tests are always false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
index 44d8a95..2c10252 100644
--- a/sound/soc/codecs/adau1701.c
+++ b/sound/soc/codecs/adau1701.c
@@ -91,7 +91,7 @@
#define ADAU1701_OSCIPOW_OPD 0x04
#define ADAU1701_DACSET_DACINIT 1
-#define ADAU1707_CLKDIV_UNSET (-1UL)
+#define ADAU1707_CLKDIV_UNSET (-1U)
#define ADAU1701_FIRMWARE "adau1701.bin"
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET
@ 2013-07-25 16:40 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2013-07-25 16:40 UTC (permalink / raw)
To: Lars-Peter Clausen, Daniel Mack
Cc: devicetree, alsa-devel, Takashi Iwai, kernel-janitors,
Liam Girdwood, Rob Herring, Mark Brown, device-drivers-devel,
Grant Likely
ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and
not an unsigned long. The current tests are always false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
index 44d8a95..2c10252 100644
--- a/sound/soc/codecs/adau1701.c
+++ b/sound/soc/codecs/adau1701.c
@@ -91,7 +91,7 @@
#define ADAU1701_OSCIPOW_OPD 0x04
#define ADAU1701_DACSET_DACINIT 1
-#define ADAU1707_CLKDIV_UNSET (-1UL)
+#define ADAU1707_CLKDIV_UNSET (-1U)
#define ADAU1701_FIRMWARE "adau1701.bin"
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET
2013-07-25 16:40 ` Dan Carpenter
@ 2013-07-26 15:54 ` Daniel Mack
-1 siblings, 0 replies; 7+ messages in thread
From: Daniel Mack @ 2013-07-26 15:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lars-Peter Clausen, devicetree, alsa-devel, Takashi Iwai,
kernel-janitors, Liam Girdwood, Rob Herring, Mark Brown,
device-drivers-devel, Grant Likely
On 25.07.2013 18:40, Dan Carpenter wrote:
> ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and
> not an unsigned long. The current tests are always false.
Well, in my case, sizeof(unsigned int) equals sizeof(unsigned long), so
it didn't hit me. But it should be fixed of course, thanks for catching.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Mack <zonque@gmail.com>
>
> diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
> index 44d8a95..2c10252 100644
> --- a/sound/soc/codecs/adau1701.c
> +++ b/sound/soc/codecs/adau1701.c
> @@ -91,7 +91,7 @@
> #define ADAU1701_OSCIPOW_OPD 0x04
> #define ADAU1701_DACSET_DACINIT 1
>
> -#define ADAU1707_CLKDIV_UNSET (-1UL)
> +#define ADAU1707_CLKDIV_UNSET (-1U)
>
> #define ADAU1701_FIRMWARE "adau1701.bin"
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [alsa-devel] [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET
@ 2013-07-26 15:54 ` Daniel Mack
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Mack @ 2013-07-26 15:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lars-Peter Clausen, devicetree, alsa-devel, Takashi Iwai,
kernel-janitors, Liam Girdwood, Rob Herring, Mark Brown,
device-drivers-devel, Grant Likely
On 25.07.2013 18:40, Dan Carpenter wrote:
> ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and
> not an unsigned long. The current tests are always false.
Well, in my case, sizeof(unsigned int) equals sizeof(unsigned long), so
it didn't hit me. But it should be fixed of course, thanks for catching.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Mack <zonque@gmail.com>
>
> diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
> index 44d8a95..2c10252 100644
> --- a/sound/soc/codecs/adau1701.c
> +++ b/sound/soc/codecs/adau1701.c
> @@ -91,7 +91,7 @@
> #define ADAU1701_OSCIPOW_OPD 0x04
> #define ADAU1701_DACSET_DACINIT 1
>
> -#define ADAU1707_CLKDIV_UNSET (-1UL)
> +#define ADAU1707_CLKDIV_UNSET (-1U)
>
> #define ADAU1701_FIRMWARE "adau1701.bin"
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET
2013-07-25 16:40 ` Dan Carpenter
@ 2013-07-26 16:02 ` Mark Brown
-1 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2013-07-26 16:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lars-Peter Clausen, Daniel Mack, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Grant Likely, Rob Herring, device-drivers-devel,
alsa-devel, devicetree, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
On Thu, Jul 25, 2013 at 07:40:17PM +0300, Dan Carpenter wrote:
> ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and
> not an unsigned long. The current tests are always false.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET
@ 2013-07-26 16:02 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2013-07-26 16:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lars-Peter Clausen, Daniel Mack, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Grant Likely, Rob Herring, device-drivers-devel,
alsa-devel, devicetree, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
On Thu, Jul 25, 2013 at 07:40:17PM +0300, Dan Carpenter wrote:
> ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and
> not an unsigned long. The current tests are always false.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread