Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

[Alexander Holler <holler@ahsoftware.de>]

Am 28.07.2013 18:29, schrieb Linus Walleij:
> On Sun, Jul 28, 2013 at 4:37 PM, Shilimkar, Santosh
> <santosh.shilimkar@ti.com> wrote:
> 
>> I think the default OMAP DT files will continue to work with
>>  these patches applied and mostly doesn't break anything
>> in default configuration.
> 
> What does "mostly" mean? Hm hm. OK I feel a little
> bit better about this now...
> 
>> Ofcourse with the DT modification as done
>> by Alexander will expose the issue.
> 
> So this is all caused by non-upstream code or
> non-upstream DTS files?
> 
>> I really wanted to have the auto request GPIO supported
>> when used as IRQ line but surely not at expense of
>> breaking the client drivers.
> 
> If things are working for the default DTS files in the
> kernel then I am OK with it.

Sorry, but that isn't and can't be a solution. Most upstream DTS files
are just for a small number of developer boards and DT got introduced to
support a lot of boards while only providing a few DTs.

Having a quick look git grep gpio_to_irq, I've quickly spotted e.g. this
in drivers/input/keyboard/gpio_keys.c:

                irq = gpio_to_irq(button->gpio);
                if (irq < 0) {

(again <0 not <=0)

and I assume that gpio-keys now fails too.

But I haven't tested it (yet).

Maybe my dts entry is wrong or incomplete, but I don't see a way how to
define the irq-domain besides the one which is already defined by the
definition of the gpio. And I don't see why that should be necessary, in
the dts the domain is already defined, it just (now) isn't used anymore.

Besides that, I feel free to ignore me. I don't know what the new
patches do fix and I don't really have a need for a solution.

Regards,

Alexander Holler