From: Alexander Holler <holler@ahsoftware.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Javier Martinez Canillas <martinez.javier@gmail.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Grant Likely <grant.likely@linaro.org>,
Jon Hunter <jgchunter@gmail.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Tony Lindgren <tony@atomide.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
Florian Vaussard <florian.vaussard@epfl.ch>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Balaji T K <balajitk@ti.com>
Subject: Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT
Date: Mon, 29 Jul 2013 12:48:37 +0200 [thread overview]
Message-ID: <51F64885.1020403@ahsoftware.de> (raw)
In-Reply-To: <CACRpkda3vN1SQR-25358B20Gye3kgVOBTQqYT+reYhjQoZ2rbA@mail.gmail.com>
Am 29.07.2013 11:05, schrieb Linus Walleij:
> On Mon, Jul 29, 2013 at 7:24 AM, Alexander Holler <holler@ahsoftware.de> wrote:
>
>> Maybe it might be worth to suggest using/returning NO_IRQ in (new) patches
>> instead of zero. That would make it very clear that the value 0 isn't to be
>> used later.
>
> Using NO_IRQ is also discouraged, and this is because we should
> use the if (!irq) design pattern and not if (irq == NO_IRQ).
So the article on lkml is already outdated. After reading the article, I
had the impression that using NO_IRQ (at least for return codes) is
encouraged.
Regards,
Alexander Holler
prev parent reply other threads:[~2013-07-29 10:49 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 15:27 [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT Javier Martinez Canillas
2013-06-28 15:27 ` [PATCH v4 2/2] gpio/omap: auto request GPIO as input if used as IRQ via DT Javier Martinez Canillas
2013-06-28 15:32 ` Santosh Shilimkar
2013-06-28 15:28 ` [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT Santosh Shilimkar
2013-06-29 23:44 ` Linus Walleij
2013-06-30 0:25 ` Javier Martinez Canillas
2013-07-01 8:04 ` Linus Walleij
2013-07-01 11:01 ` Javier Martinez Canillas
2013-07-01 12:35 ` Linus Walleij
2013-07-01 12:49 ` Grant Likely
2013-07-01 13:23 ` Linus Walleij
2013-07-28 10:58 ` Alexander Holler
2013-07-28 11:14 ` Linus Walleij
2013-07-28 12:59 ` Alexander Holler
2013-07-28 14:11 ` Linus Walleij
2013-07-28 14:37 ` Shilimkar, Santosh
2013-07-28 16:29 ` Linus Walleij
2013-07-28 17:13 ` Alexander Holler
2013-07-28 18:10 ` Linus Walleij
2013-07-28 17:33 ` Javier Martinez Canillas
2013-07-28 17:36 ` Javier Martinez Canillas
2013-07-28 18:22 ` Linus Walleij
2013-07-28 19:06 ` Javier Martinez Canillas
2013-07-29 6:41 ` Alexander Holler
2013-07-29 8:17 ` Javier Martinez Canillas
2013-07-29 9:13 ` Linus Walleij
2013-07-29 10:27 ` Alexander Holler
2013-07-29 11:11 ` Javier Martinez Canillas
2013-07-29 11:30 ` Alexander Holler
2013-07-29 11:33 ` Alexander Holler
2013-07-29 11:48 ` Linus Walleij
2013-07-29 11:53 ` Balaji T K
2013-07-28 19:30 ` Javier Martinez Canillas
2013-07-29 6:54 ` Alexander Holler
2013-07-28 14:25 ` Alexander Holler
2013-07-28 16:25 ` Linus Walleij
2013-07-28 16:45 ` Alexander Holler
2013-07-28 17:47 ` Javier Martinez Canillas
2013-07-28 18:06 ` Linus Walleij
2013-07-28 18:50 ` Javier Martinez Canillas
2013-07-29 5:24 ` Alexander Holler
2013-07-29 9:05 ` Linus Walleij
2013-07-29 10:48 ` Alexander Holler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F64885.1020403@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=aaro.koskinen@iki.fi \
--cc=balajitk@ti.com \
--cc=eballetbo@gmail.com \
--cc=florian.vaussard@epfl.ch \
--cc=grant.likely@linaro.org \
--cc=javier.martinez@collabora.co.uk \
--cc=jgchunter@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=plagnioj@jcrosoft.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.