From: Alexander Holler <holler@ahsoftware.de>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
ext Tony Lindgren <tony@atomide.com>,
Grant Likely <grant.likely@secretlab.ca>,
Kevin Hilman <khilman@linaro.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Jon Hunter <jgchunter@gmail.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
Florian Vaussard <florian.vaussard@epfl.ch>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
"Krishnamoorthy, Balaji T" <balajitk@ti.com>
Subject: Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT
Date: Mon, 29 Jul 2013 08:41:05 +0200 [thread overview]
Message-ID: <51F60E81.7090103@ahsoftware.de> (raw)
In-Reply-To: <CAAwP0s2ETdSwmFjh=QJP+LwU+hsBR_KQ0mYGX94BYYfjx3+QVA@mail.gmail.com>
Am 28.07.2013 21:06, schrieb Javier Martinez Canillas:
> On Sun, Jul 28, 2013 at 8:22 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Sun, Jul 28, 2013 at 7:33 PM, Javier Martinez Canillas
>> <martinez.javier@gmail.com> wrote:
>>
>>> According to Documentation/devicetree/bindings/mmc/mmc.txt:
>>>
>>> cd-gpios: Specify GPIOs for card detection, see gpio binding
>>>
>>> So it just says that it is a GPIO for card detection and not an IRQ so
>>> this assumption comes from either the omap_hsmmc driver or Alexander'
>>> DTS is missing something like:
>>>
>>> interrupt-parent = <&gpio6>;
>>> interrupts = <16 8>;
What do the values 16 and 8 mean here? GPIO numbers?
And where do I have to place that?
I've now tried the following:
--
&mmc1 {
vmmc-supply = <&vmmcsd_fixed>;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&mmc1_pins>; /* pinmux for GPIO0__6 */
interrupt-parent = <&gpio0>;
interrupts = <6>;
cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
cd-inverted;
};
--
(the gpio which should be used for the IRQ is GPIO0_6)
The result was that the gpio_request() failed with -EBUSY.
Then I've commented out that, because it isn't necessary anymore as the
gpio should be set as input automatically (as I've understood the commit
msg).
The result was
[ 1.397100] genirq: Flags mismatch irq 144. 00002003 (mmc0) vs.
00000000 (mmc0)
and request_threaded_irq() returned with -EBUSY.
To stop that discussion about some "non-standard" dts I'm using (I
wonder where the standard is), I try to formulate a clear question:
If a driver uses
--
irq = gpio_to_irq(some_gpio_number);
/*
gpio_request();
gpio_direction_input();
*/
request_threaded_irq(irq);
--
How should the dts or the driver be changed that this works with 3.11-rc2?
Regards,
Alexander Holler
next prev parent reply other threads:[~2013-07-29 6:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 15:27 [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT Javier Martinez Canillas
2013-06-28 15:27 ` [PATCH v4 2/2] gpio/omap: auto request GPIO as input if used as IRQ via DT Javier Martinez Canillas
2013-06-28 15:32 ` Santosh Shilimkar
2013-06-28 15:28 ` [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT Santosh Shilimkar
2013-06-29 23:44 ` Linus Walleij
2013-06-30 0:25 ` Javier Martinez Canillas
2013-07-01 8:04 ` Linus Walleij
2013-07-01 11:01 ` Javier Martinez Canillas
2013-07-01 12:35 ` Linus Walleij
2013-07-01 12:49 ` Grant Likely
2013-07-01 13:23 ` Linus Walleij
2013-07-28 10:58 ` Alexander Holler
2013-07-28 11:14 ` Linus Walleij
2013-07-28 12:59 ` Alexander Holler
2013-07-28 14:11 ` Linus Walleij
2013-07-28 14:37 ` Shilimkar, Santosh
2013-07-28 16:29 ` Linus Walleij
2013-07-28 17:13 ` Alexander Holler
2013-07-28 18:10 ` Linus Walleij
2013-07-28 17:33 ` Javier Martinez Canillas
2013-07-28 17:36 ` Javier Martinez Canillas
2013-07-28 18:22 ` Linus Walleij
2013-07-28 19:06 ` Javier Martinez Canillas
2013-07-29 6:41 ` Alexander Holler [this message]
2013-07-29 8:17 ` Javier Martinez Canillas
2013-07-29 9:13 ` Linus Walleij
2013-07-29 10:27 ` Alexander Holler
2013-07-29 11:11 ` Javier Martinez Canillas
2013-07-29 11:30 ` Alexander Holler
2013-07-29 11:33 ` Alexander Holler
2013-07-29 11:48 ` Linus Walleij
2013-07-29 11:53 ` Balaji T K
2013-07-28 19:30 ` Javier Martinez Canillas
2013-07-29 6:54 ` Alexander Holler
2013-07-28 14:25 ` Alexander Holler
2013-07-28 16:25 ` Linus Walleij
2013-07-28 16:45 ` Alexander Holler
2013-07-28 17:47 ` Javier Martinez Canillas
2013-07-28 18:06 ` Linus Walleij
2013-07-28 18:50 ` Javier Martinez Canillas
2013-07-29 5:24 ` Alexander Holler
2013-07-29 9:05 ` Linus Walleij
2013-07-29 10:48 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F60E81.7090103@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=aaro.koskinen@iki.fi \
--cc=balajitk@ti.com \
--cc=eballetbo@gmail.com \
--cc=florian.vaussard@epfl.ch \
--cc=grant.likely@secretlab.ca \
--cc=javier.martinez@collabora.co.uk \
--cc=jgchunter@gmail.com \
--cc=khilman@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=martinez.javier@gmail.com \
--cc=plagnioj@jcrosoft.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.