Re: [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used

[Michael Tokarev <mjt@tls.msk.ru>]

On 29.07.2013 02:37, Aurelien Jarno wrote:
> On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
>> This assignment causes a compiler warning for compilations with the compiler
>> option -Wunused-but-set-variable (which is included with -Wextra).
>>
>> Removing it allows using -Wextra for QEMU code without suppressing too many
>> extra warnings.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>   target-mips/op_helper.c |    1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
>> index 5cf1c3f..b828375 100644
>> --- a/target-mips/op_helper.c
>> +++ b/target-mips/op_helper.c
>> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
>>   void helper_fork(target_ulong arg1, target_ulong arg2)
>>   {
>>       // arg1 = rt, arg2 = rs
>> -    arg1 = 0;
>>       // TODO: store to TC register
>>   }
>
> Thanks, applied.

FWIW, you're applying this (and "linux-user: correct argument number ..")
3 days after I sent a pull request for trivial-patches which includes
these patches.

Should I rebase and re-issue my pull request now?

Thanks,

/mjt