Re: Small fix for ceph.spec

Re: Small fix for ceph.spec

[Patrick McGarry]

[-- Attachment #1.1: Type: text/plain, Size: 659 bytes --]

Thanks Erik!

Adding ceph-devel since it has a patch on it.



Best Regards,

Patrick McGarry
Director, Community || Inktank
http://ceph.com  ||  http://inktank.com
@scuttlemonkey || @ceph || @inktank


On Mon, Jul 29, 2013 at 7:07 PM, Erik Logtenberg <erik-nLcryBYLV+bMkAkIaI5Geg@public.gmane.org> wrote:

> Hi,
>
> The spec file used for building rpm's misses a build time dependency on
> snappy-devel. Please see attached patch to fix.
>
> Kind regards,
>
> Erik.
>
> _______________________________________________
> ceph-users mailing list
> ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org
> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
>
>

[-- Attachment #1.2: Type: text/html, Size: 1418 bytes --]

[-- Attachment #2: Type: text/plain, Size: 178 bytes --]

_______________________________________________
ceph-users mailing list
ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org
http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com

Fwd: [ceph-users] Small fix for ceph.spec

[Patrick McGarry]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

---------- Forwarded message ----------
From: Erik Logtenberg <erik@logtenberg.eu>
Date: Mon, Jul 29, 2013 at 7:07 PM
Subject: [ceph-users] Small fix for ceph.spec
To: ceph-users@lists.ceph.com


Hi,

The spec file used for building rpm's misses a build time dependency on
snappy-devel. Please see attached patch to fix.

Kind regards,

Erik.

_______________________________________________
ceph-users mailing list
ceph-users@lists.ceph.com
http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com

[-- Attachment #2: require-snappy-devel.patch --]
[-- Type: text/x-patch, Size: 359 bytes --]

--- ceph.spec-orig	2013-07-30 00:24:54.705000000 +0200
+++ ceph.spec	2013-07-30 00:25:34.199000000 +0200
@@ -42,6 +42,7 @@
 BuildRequires:  libxml2-devel
 BuildRequires:  libuuid-devel
 BuildRequires:  leveldb-devel > 1.2
+BuildRequires:  snappy-devel
 
 #################################################################################
 # specific

Re: Fwd: Small fix for ceph.spec

[Danny Al-Gaaf]

Hi,

I think this is a bug in packaging of the leveldb package in this case
since the spec-file already sets dependencies on on leveldb-devel.

leveldb depends on snappy, therefore the leveldb package should set a
dependency on snappy-devel for leveldb-devel (check the SUSE spec file
for leveldb:
https://build.opensuse.org/package/view_file/home:dalgaaf:ceph:extra/leveldb/leveldb.spec?expand=1).
This way the RPM build process will pick up the correct packages needed
to build ceph.

Which distro do you use?

Danny

Am 30.07.2013 01:33, schrieb Patrick McGarry:
> ---------- Forwarded message ----------
> From: Erik Logtenberg <erik-nLcryBYLV+bMkAkIaI5Geg@public.gmane.org>
> Date: Mon, Jul 29, 2013 at 7:07 PM
> Subject: [ceph-users] Small fix for ceph.spec
> To: ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org
> 
> 
> Hi,
> 
> The spec file used for building rpm's misses a build time dependency on
> snappy-devel. Please see attached patch to fix.
> 
> Kind regards,
> 
> Erik.
> 
> _______________________________________________
> ceph-users mailing list
> ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org
> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
> 

Re: Fwd: Small fix for ceph.spec

[Erik Logtenberg]

Hi,

Fedora, in this case Fedora 19, x86_64.

Kind regards,

Erik.


On 07/30/2013 09:29 AM, Danny Al-Gaaf wrote:
> Hi,
> 
> I think this is a bug in packaging of the leveldb package in this case
> since the spec-file already sets dependencies on on leveldb-devel.
> 
> leveldb depends on snappy, therefore the leveldb package should set a
> dependency on snappy-devel for leveldb-devel (check the SUSE spec file
> for leveldb:
> https://build.opensuse.org/package/view_file/home:dalgaaf:ceph:extra/leveldb/leveldb.spec?expand=1).
> This way the RPM build process will pick up the correct packages needed
> to build ceph.
> 
> Which distro do you use?
> 
> Danny
> 
> Am 30.07.2013 01:33, schrieb Patrick McGarry:
>> ---------- Forwarded message ----------
>> From: Erik Logtenberg <erik-nLcryBYLV+bMkAkIaI5Geg@public.gmane.org>
>> Date: Mon, Jul 29, 2013 at 7:07 PM
>> Subject: [ceph-users] Small fix for ceph.spec
>> To: ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org
>>
>>
>> Hi,
>>
>> The spec file used for building rpm's misses a build time dependency on
>> snappy-devel. Please see attached patch to fix.
>>
>> Kind regards,
>>
>> Erik.
>>
>> _______________________________________________
>> ceph-users mailing list
>> ceph-users-idqoXFIVOFJgJs9I8MT0rw@public.gmane.org
>> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
>>

Re: Fwd: [ceph-users] Small fix for ceph.spec

[Danny Al-Gaaf]

Hi,

then the Fedora package is broken. If you check the spec file of:

http://dl.fedoraproject.org/pub/fedora/linux/updates/19/SRPMS/leveldb-1.12.0-3.fc19.src.rpm


You can see the spec-file sets a:

BuildRequires:  snappy-devel

But not the corresponding "Requires: snappy-devel" for the devel package.

You should report this issue to your distribution, it needs to be fixed
there instead of adding a workaround to the ceph spec.

Regards,

Danny

Am 30.07.2013 09:42, schrieb Erik Logtenberg:
> Hi,
> 
> Fedora, in this case Fedora 19, x86_64.
> 
> Kind regards,
> 
> Erik.
> 
> 
> On 07/30/2013 09:29 AM, Danny Al-Gaaf wrote:
>> Hi,
>>
>> I think this is a bug in packaging of the leveldb package in this case
>> since the spec-file already sets dependencies on on leveldb-devel.
>>
>> leveldb depends on snappy, therefore the leveldb package should set a
>> dependency on snappy-devel for leveldb-devel (check the SUSE spec file
>> for leveldb:
>> https://build.opensuse.org/package/view_file/home:dalgaaf:ceph:extra/leveldb/leveldb.spec?expand=1).
>> This way the RPM build process will pick up the correct packages needed
>> to build ceph.
>>
>> Which distro do you use?
>>
>> Danny
>>
>> Am 30.07.2013 01:33, schrieb Patrick McGarry:
>>> ---------- Forwarded message ----------
>>> From: Erik Logtenberg <erik@logtenberg.eu>
>>> Date: Mon, Jul 29, 2013 at 7:07 PM
>>> Subject: [ceph-users] Small fix for ceph.spec
>>> To: ceph-users@lists.ceph.com
>>>
>>>
>>> Hi,
>>>
>>> The spec file used for building rpm's misses a build time dependency on
>>> snappy-devel. Please see attached patch to fix.
>>>
>>> Kind regards,
>>>
>>> Erik.
>>>
>>> _______________________________________________
>>> ceph-users mailing list
>>> ceph-users@lists.ceph.com
>>> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
>>>
> 

Re: Fwd: [ceph-users] Small fix for ceph.spec

[Erik Logtenberg]

Hi,

I will report the issue there as well. Please note that Ceph seems to
support Fedora 17, even though that release is considered end-of-life by
Fedora. This issue with the leveldb package cannot be fixed for Fedora
17, only for 18 and 19.
So if Ceph wants to continue supporting Fedora 17, adding this
workaround seems to be the only way to get this (rather minor) bug fixed.

Kind regards,

Erik.


On 07/30/2013 09:56 AM, Danny Al-Gaaf wrote:
> Hi,
> 
> then the Fedora package is broken. If you check the spec file of:
> 
> http://dl.fedoraproject.org/pub/fedora/linux/updates/19/SRPMS/leveldb-1.12.0-3.fc19.src.rpm
> 
> 
> You can see the spec-file sets a:
> 
> BuildRequires:  snappy-devel
> 
> But not the corresponding "Requires: snappy-devel" for the devel package.
> 
> You should report this issue to your distribution, it needs to be fixed
> there instead of adding a workaround to the ceph spec.
> 
> Regards,
> 
> Danny
> 
> Am 30.07.2013 09:42, schrieb Erik Logtenberg:
>> Hi,
>>
>> Fedora, in this case Fedora 19, x86_64.
>>
>> Kind regards,
>>
>> Erik.
>>
>>
>> On 07/30/2013 09:29 AM, Danny Al-Gaaf wrote:
>>> Hi,
>>>
>>> I think this is a bug in packaging of the leveldb package in this case
>>> since the spec-file already sets dependencies on on leveldb-devel.
>>>
>>> leveldb depends on snappy, therefore the leveldb package should set a
>>> dependency on snappy-devel for leveldb-devel (check the SUSE spec file
>>> for leveldb:
>>> https://build.opensuse.org/package/view_file/home:dalgaaf:ceph:extra/leveldb/leveldb.spec?expand=1).
>>> This way the RPM build process will pick up the correct packages needed
>>> to build ceph.
>>>
>>> Which distro do you use?
>>>
>>> Danny
>>>
>>> Am 30.07.2013 01:33, schrieb Patrick McGarry:
>>>> ---------- Forwarded message ----------
>>>> From: Erik Logtenberg <erik@logtenberg.eu>
>>>> Date: Mon, Jul 29, 2013 at 7:07 PM
>>>> Subject: [ceph-users] Small fix for ceph.spec
>>>> To: ceph-users@lists.ceph.com
>>>>
>>>>
>>>> Hi,
>>>>
>>>> The spec file used for building rpm's misses a build time dependency on
>>>> snappy-devel. Please see attached patch to fix.
>>>>
>>>> Kind regards,
>>>>
>>>> Erik.
>>>>
>>>> _______________________________________________
>>>> ceph-users mailing list
>>>> ceph-users@lists.ceph.com
>>>> http://lists.ceph.com/listinfo.cgi/ceph-users-ceph.com
>>>>
>>