From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: [PATCH 1/7] cgroup: fix a leak when percpu_ref_init() fails
Date: Wed, 31 Jul 2013 16:16:28 +0800 [thread overview]
Message-ID: <51F8C7DC.8060306@huawei.com> (raw)
In-Reply-To: <51F8C7C5.9040608@huawei.com>
ss->css_free() is not called when perfcpu_ref_init() fails.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
kernel/cgroup.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index a64b7b8..e60eba2 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4274,8 +4274,10 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
}
err = percpu_ref_init(&css->refcnt, css_release);
- if (err)
+ if (err) {
+ ss->css_free(cgrp);
goto err_free_all;
+ }
init_cgroup_css(css, ss, cgrp);
}
--
1.8.0.2
next prev parent reply other threads:[~2013-07-31 8:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 8:16 [PATCH 0/7] some pending cgroup patches Li Zefan
2013-07-31 8:16 ` Li Zefan
2013-07-31 8:16 ` Li Zefan [this message]
[not found] ` <51F8C7DC.8060306-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 10:14 ` [PATCH 1/7] cgroup: fix a leak when percpu_ref_init() fails Tejun Heo
2013-07-31 10:14 ` Tejun Heo
2013-07-31 8:16 ` [PATCH 2/7] cgroup: remove sparse tags from offline_css() Li Zefan
[not found] ` <51F8C7E8.1080909-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 10:42 ` Tejun Heo
2013-07-31 10:42 ` Tejun Heo
2013-07-31 8:17 ` [PATCH 3/7] cgroup: restructure the failure path in cgroup_write_event_control() Li Zefan
[not found] ` <51F8C802.7070404-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 10:44 ` Tejun Heo
2013-07-31 10:44 ` Tejun Heo
[not found] ` <20130731104448.GH2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-01 1:51 ` [PATCH v2 " Li Zefan
2013-08-01 1:51 ` Li Zefan
2013-08-01 13:30 ` Tejun Heo
2013-07-31 8:17 ` [PATCH 4/7] cgroup: rename cgroup_pidlist->mutex Li Zefan
[not found] ` <51F8C818.4080308-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 11:35 ` Tejun Heo
2013-07-31 11:35 ` Tejun Heo
[not found] ` <20130731113518.GJ2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-01 1:52 ` [PATCH v2 " Li Zefan
2013-08-01 1:52 ` Li Zefan
[not found] ` <51F9BF4F.5030704-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-01 13:30 ` Tejun Heo
2013-08-01 13:30 ` Tejun Heo
2013-07-31 8:17 ` [PATCH 5/7] cgroup: remove struct cgroup_seqfile_state Li Zefan
2013-07-31 9:27 ` Li Zefan
[not found] ` <51F8D88B.2040400-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 11:35 ` Tejun Heo
2013-07-31 11:35 ` Tejun Heo
[not found] ` <20130731113557.GK2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-01 1:11 ` Li Zefan
2013-08-01 1:11 ` Li Zefan
2013-07-31 8:18 ` [PATCH 6/7] cgroup: rename current_css_set_cg_links Li Zefan
[not found] ` <51F8C83F.6010407-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 11:38 ` Tejun Heo
2013-07-31 11:38 ` Tejun Heo
[not found] ` <20130731113857.GM2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-01 1:11 ` Li Zefan
2013-08-01 1:11 ` Li Zefan
2013-07-31 8:18 ` [PATCH 7/7] cgroup: more naming cleanups Li Zefan
2013-07-31 11:39 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8C7DC.8060306@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.