From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 6/7] cgroup: rename current_css_set_cg_links
Date: Thu, 1 Aug 2013 09:11:52 +0800 [thread overview]
Message-ID: <51F9B5D8.4080707@huawei.com> (raw)
In-Reply-To: <20130731113857.GM2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
On 2013/7/31 19:38, Tejun Heo wrote:
> Hello,
>
> On Wed, Jul 31, 2013 at 04:18:07PM +0800, Li Zefan wrote:
>> As we've renamed css_set->cg_links to css_set->cgrp_links (See commit
>> 69d0206c79 "cgroup: bring some sanity to naming around cg_cgroup_link"),
>> it's better to also rename the debug file.
>>
>> As the "debug" cgroup subsystem is for debug only and acts as a sample
>> on how to write a cgroup subsystem, it's fine to change the interface.
>
> I'd rather not do this. It doesn't really buy us anything and stuff
> like cgrp_links isn't interesting to actual controllers anyway.
>
not a big deal
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH 6/7] cgroup: rename current_css_set_cg_links
Date: Thu, 1 Aug 2013 09:11:52 +0800 [thread overview]
Message-ID: <51F9B5D8.4080707@huawei.com> (raw)
In-Reply-To: <20130731113857.GM2810@htj.dyndns.org>
On 2013/7/31 19:38, Tejun Heo wrote:
> Hello,
>
> On Wed, Jul 31, 2013 at 04:18:07PM +0800, Li Zefan wrote:
>> As we've renamed css_set->cg_links to css_set->cgrp_links (See commit
>> 69d0206c79 "cgroup: bring some sanity to naming around cg_cgroup_link"),
>> it's better to also rename the debug file.
>>
>> As the "debug" cgroup subsystem is for debug only and acts as a sample
>> on how to write a cgroup subsystem, it's fine to change the interface.
>
> I'd rather not do this. It doesn't really buy us anything and stuff
> like cgrp_links isn't interesting to actual controllers anyway.
>
not a big deal
next prev parent reply other threads:[~2013-08-01 1:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 8:16 [PATCH 0/7] some pending cgroup patches Li Zefan
2013-07-31 8:16 ` Li Zefan
2013-07-31 8:16 ` [PATCH 1/7] cgroup: fix a leak when percpu_ref_init() fails Li Zefan
[not found] ` <51F8C7DC.8060306-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 10:14 ` Tejun Heo
2013-07-31 10:14 ` Tejun Heo
2013-07-31 8:16 ` [PATCH 2/7] cgroup: remove sparse tags from offline_css() Li Zefan
[not found] ` <51F8C7E8.1080909-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 10:42 ` Tejun Heo
2013-07-31 10:42 ` Tejun Heo
2013-07-31 8:17 ` [PATCH 3/7] cgroup: restructure the failure path in cgroup_write_event_control() Li Zefan
[not found] ` <51F8C802.7070404-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 10:44 ` Tejun Heo
2013-07-31 10:44 ` Tejun Heo
[not found] ` <20130731104448.GH2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-01 1:51 ` [PATCH v2 " Li Zefan
2013-08-01 1:51 ` Li Zefan
2013-08-01 13:30 ` Tejun Heo
2013-07-31 8:17 ` [PATCH 4/7] cgroup: rename cgroup_pidlist->mutex Li Zefan
[not found] ` <51F8C818.4080308-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 11:35 ` Tejun Heo
2013-07-31 11:35 ` Tejun Heo
[not found] ` <20130731113518.GJ2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-01 1:52 ` [PATCH v2 " Li Zefan
2013-08-01 1:52 ` Li Zefan
[not found] ` <51F9BF4F.5030704-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-01 13:30 ` Tejun Heo
2013-08-01 13:30 ` Tejun Heo
2013-07-31 8:17 ` [PATCH 5/7] cgroup: remove struct cgroup_seqfile_state Li Zefan
2013-07-31 9:27 ` Li Zefan
[not found] ` <51F8D88B.2040400-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 11:35 ` Tejun Heo
2013-07-31 11:35 ` Tejun Heo
[not found] ` <20130731113557.GK2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-01 1:11 ` Li Zefan
2013-08-01 1:11 ` Li Zefan
2013-07-31 8:18 ` [PATCH 6/7] cgroup: rename current_css_set_cg_links Li Zefan
[not found] ` <51F8C83F.6010407-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 11:38 ` Tejun Heo
2013-07-31 11:38 ` Tejun Heo
[not found] ` <20130731113857.GM2810-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-08-01 1:11 ` Li Zefan [this message]
2013-08-01 1:11 ` Li Zefan
2013-07-31 8:18 ` [PATCH 7/7] cgroup: more naming cleanups Li Zefan
2013-07-31 11:39 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F9B5D8.4080707@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.