From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Tuomas Tynkkynen <ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30
Date: Wed, 31 Jul 2013 16:13:59 -0600 [thread overview]
Message-ID: <51F98C27.40904@wwwdotorg.org> (raw)
In-Reply-To: <1375292543-7896-2-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote:
> Add device tree entries for the 3 USB controllers and PHYs and
> enable the third controller on Cardhu and Beaver boards.
>
> Fix VBUS regulator entries on Beaver. The GPIO pins were wrong.
That much is correct.
> Also, a third GPIO is required to power the pullup resistors that drive
> the VBUS voltage switches, so add an regulator entry for that.
That is not true. GMI_AD13 / PH5 / 61 is a signal that pulls up all of
USB1 VBUS, USB3 VBUS, and GMI_AD15, which as far as I can tell is
entirely unrelated to USB in any way.
This part of the change should be removed. I know you mentioned that
downstream does this, but that means very little; there are many
mistakes there.
Aside from that, this patch looks fine.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30
Date: Wed, 31 Jul 2013 16:13:59 -0600 [thread overview]
Message-ID: <51F98C27.40904@wwwdotorg.org> (raw)
In-Reply-To: <1375292543-7896-2-git-send-email-ttynkkynen@nvidia.com>
On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote:
> Add device tree entries for the 3 USB controllers and PHYs and
> enable the third controller on Cardhu and Beaver boards.
>
> Fix VBUS regulator entries on Beaver. The GPIO pins were wrong.
That much is correct.
> Also, a third GPIO is required to power the pullup resistors that drive
> the VBUS voltage switches, so add an regulator entry for that.
That is not true. GMI_AD13 / PH5 / 61 is a signal that pulls up all of
USB1 VBUS, USB3 VBUS, and GMI_AD15, which as far as I can tell is
entirely unrelated to USB in any way.
This part of the change should be removed. I know you mentioned that
downstream does this, but that means very little; there are many
mistakes there.
Aside from that, this patch looks fine.
next prev parent reply other threads:[~2013-07-31 22:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 17:42 [PATCH 0/2] Device tree changes for Tegra30 and Tegra114 USB Host support Tuomas Tynkkynen
2013-07-31 17:42 ` Tuomas Tynkkynen
2013-07-31 17:42 ` [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30 Tuomas Tynkkynen
2013-07-31 17:42 ` Tuomas Tynkkynen
[not found] ` <1375292543-7896-2-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-31 22:13 ` Stephen Warren [this message]
2013-07-31 22:13 ` Stephen Warren
[not found] ` <51F98C27.40904-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-01 15:15 ` Tuomas Tynkkynen
2013-08-01 15:15 ` Tuomas Tynkkynen
2013-07-31 17:42 ` [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore Tuomas Tynkkynen
2013-07-31 17:42 ` Tuomas Tynkkynen
[not found] ` <1375292543-7896-3-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-31 18:18 ` Sergei Shtylyov
2013-07-31 18:18 ` Sergei Shtylyov
2013-07-31 19:31 ` Tuomas Tynkkynen
[not found] ` <51F9660C.6090604-X3B1VOXEql0@public.gmane.org>
2013-07-31 19:53 ` Sergei Shtylyov
2013-07-31 19:53 ` Sergei Shtylyov
[not found] ` <51F96B48.10209-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-07-31 22:06 ` Stephen Warren
2013-07-31 22:06 ` Stephen Warren
[not found] ` <51F98A78.9060309-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-31 22:20 ` Sergei Shtylyov
2013-07-31 22:20 ` Sergei Shtylyov
[not found] ` <51F98D92.3010607-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-07-31 23:29 ` Stephen Warren
2013-07-31 23:29 ` Stephen Warren
[not found] ` <51F99DE4.7010503-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-01 12:37 ` Sergei Shtylyov
2013-08-01 12:37 ` Sergei Shtylyov
2013-08-15 10:54 ` Thierry Reding
2013-08-15 10:54 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F98C27.40904@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.