All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory
Date: Tue, 06 Aug 2013 17:33:03 +0200	[thread overview]
Message-ID: <5201172F.5050803@samsung.com> (raw)
In-Reply-To: <xa1ttxj2luxi.fsf@mina86.com>

On 08/06/2013 05:07 PM, Michal Nazarewicz wrote:
> On Tue, Aug 06 2013, Rob Herring wrote:
>>> >> +static void reserved_mem_release_device_from_dt(struct device *dev)
>>> >> +{
>>> >> +       struct reserved_mem *region = get_dma_memory_region(dev);
>>> >> +       if (!region)
>>> >> +               return;
>>> >> +       if (!region->cma)
>> >
>> > if (region && !region->cma)
>
> !region case is handled two lines above, so no need to check if region
> is not null.

I think Rob's suggestion was to replace two 'if' statements with a single
one, which makes sense.


Thanks,
Sylwester

WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Arnd Bergmann <arnd@arndb.de>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	Nishanth Peethambaran <nishanth.p@gmail.com>,
	linaro-mm-sig@lists.linaro.org, Marc <marc.ceeeee@gmail.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Olof Johansson <olof@lixom.net>,
	Laura Abbott <lauraa@codeaurora.org>,
	Tomasz Figa <t.figa@samsung.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory
Date: Tue, 06 Aug 2013 17:33:03 +0200	[thread overview]
Message-ID: <5201172F.5050803@samsung.com> (raw)
In-Reply-To: <xa1ttxj2luxi.fsf@mina86.com>

On 08/06/2013 05:07 PM, Michal Nazarewicz wrote:
> On Tue, Aug 06 2013, Rob Herring wrote:
>>> >> +static void reserved_mem_release_device_from_dt(struct device *dev)
>>> >> +{
>>> >> +       struct reserved_mem *region = get_dma_memory_region(dev);
>>> >> +       if (!region)
>>> >> +               return;
>>> >> +       if (!region->cma)
>> >
>> > if (region && !region->cma)
>
> !region case is handled two lines above, so no need to check if region
> is not null.

I think Rob's suggestion was to replace two 'if' statements with a single
one, which makes sense.


Thanks,
Sylwester

  reply	other threads:[~2013-08-06 15:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31 12:51 [PATCH v4 0/4] Device Tree support for CMA (Contiguous Memory Allocator) Marek Szyprowski
2013-07-31 12:51 ` Marek Szyprowski
2013-07-31 12:51 ` [PATCH v4 1/4] drivers: dma-contiguous: clean source code and prepare for device tree Marek Szyprowski
2013-07-31 12:51   ` Marek Szyprowski
2013-08-05 14:06   ` Michal Nazarewicz
2013-08-05 14:06     ` Michal Nazarewicz
2013-07-31 12:51 ` [PATCH v4 2/4] drivers: of: add function to scan fdt nodes given by path Marek Szyprowski
2013-07-31 12:51   ` Marek Szyprowski
2013-08-05 14:30   ` Michal Nazarewicz
2013-08-05 14:30     ` Michal Nazarewicz
2013-07-31 12:51 ` [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory Marek Szyprowski
2013-07-31 12:51   ` Marek Szyprowski
2013-08-05 18:59   ` Michal Nazarewicz
2013-08-05 18:59     ` Michal Nazarewicz
2013-08-06 13:30   ` Rob Herring
2013-08-06 13:30     ` Rob Herring
2013-08-06 15:07     ` Michal Nazarewicz
2013-08-06 15:07       ` Michal Nazarewicz
2013-08-06 15:33       ` Sylwester Nawrocki [this message]
2013-08-06 15:33         ` Sylwester Nawrocki
2013-08-07 12:38         ` Michal Nazarewicz
2013-08-07 12:38           ` Michal Nazarewicz
2013-08-07 13:08       ` Rob Herring
2013-08-07 13:08         ` Rob Herring
2013-08-07 15:07   ` Kumar Gala
2013-08-07 15:07     ` Kumar Gala
2013-07-31 12:51 ` [PATCH v4 4/4] ARM: init: add support for reserved memory defined by device tree Marek Szyprowski
2013-07-31 12:51   ` Marek Szyprowski
2013-08-05 14:31   ` Michal Nazarewicz
2013-08-05 14:31     ` Michal Nazarewicz
  -- strict thread matches above, loose matches on Subject: below --
2013-08-05  6:53 [PATCH v4 0/4] [RESEND] Device Tree support for CMA (Contiguous Memory Allocator) Marek Szyprowski
2013-08-05  6:53 ` [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5201172F.5050803@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.