[PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory

From: mina86@mina86.com (Michal Nazarewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory
Date: Wed, 07 Aug 2013 14:38:06 +0200	[thread overview]
Message-ID: <xa1ta9kt1xsh.fsf@mina86.com> (raw)
In-Reply-To: <5201172F.5050803@samsung.com>

On Tue, Aug 06 2013, Sylwester Nawrocki wrote:
> On 08/06/2013 05:07 PM, Michal Nazarewicz wrote:
>> On Tue, Aug 06 2013, Rob Herring wrote:
>>>> >> +static void reserved_mem_release_device_from_dt(struct device *dev)
>>>> >> +{
>>>> >> +       struct reserved_mem *region = get_dma_memory_region(dev);
>>>> >> +       if (!region)
>>>> >> +               return;
>>>> >> +       if (!region->cma)
>>> >
>>> > if (region && !region->cma)
>>
>> !region case is handled two lines above, so no need to check if region
>> is not null.
>
> I think Rob's suggestion was to replace two 'if' statements with a single
> one, which makes sense.

Ah, yes, silly me...

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Micha? ?mina86? Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130807/16d7436a/attachment.sig>