From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org"
<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Matthew Longnecker
<MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 1/3] hwmon: (lm90) Add power control
Date: Thu, 08 Aug 2013 11:33:13 -0600 [thread overview]
Message-ID: <5203D659.4050907@wwwdotorg.org> (raw)
In-Reply-To: <52037F9A.7070802-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On 08/08/2013 05:23 AM, Guenter Roeck wrote:
> On 08/08/2013 02:47 AM, Wei Ni wrote:
...
>> I think get_regulator() will return error values, not only
>> -EPROBE_DEFER, so we should set data->lm90_reg to NULL to handle other
>> error values.
>>
> Matter of opinion if you want to check for IS_ERR or NULL later on.
No, if regulator returns either:
* Something valid
* Someting IS_ERR()
... then everywhere has to check the value using IS_ERR().
If regulator returns either:
* Something valid
* Someting NULL
... then everywhere has to check the value against NULL.
checking against both IS_ERR() and NULL shouldn't ever happen, and
likewise IS_ERR_OR_NULL() is deprecated.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org"
<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Matthew Longnecker
<MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) Add power control
Date: Thu, 08 Aug 2013 17:33:13 +0000 [thread overview]
Message-ID: <5203D659.4050907@wwwdotorg.org> (raw)
In-Reply-To: <52037F9A.7070802-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On 08/08/2013 05:23 AM, Guenter Roeck wrote:
> On 08/08/2013 02:47 AM, Wei Ni wrote:
...
>> I think get_regulator() will return error values, not only
>> -EPROBE_DEFER, so we should set data->lm90_reg to NULL to handle other
>> error values.
>>
> Matter of opinion if you want to check for IS_ERR or NULL later on.
No, if regulator returns either:
* Something valid
* Someting IS_ERR()
... then everywhere has to check the value using IS_ERR().
If regulator returns either:
* Something valid
* Someting NULL
... then everywhere has to check the value against NULL.
checking against both IS_ERR() and NULL shouldn't ever happen, and
likewise IS_ERR_OR_NULL() is deprecated.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] hwmon: (lm90) Add power control
Date: Thu, 08 Aug 2013 11:33:13 -0600 [thread overview]
Message-ID: <5203D659.4050907@wwwdotorg.org> (raw)
In-Reply-To: <52037F9A.7070802@roeck-us.net>
On 08/08/2013 05:23 AM, Guenter Roeck wrote:
> On 08/08/2013 02:47 AM, Wei Ni wrote:
...
>> I think get_regulator() will return error values, not only
>> -EPROBE_DEFER, so we should set data->lm90_reg to NULL to handle other
>> error values.
>>
> Matter of opinion if you want to check for IS_ERR or NULL later on.
No, if regulator returns either:
* Something valid
* Someting IS_ERR()
... then everywhere has to check the value using IS_ERR().
If regulator returns either:
* Something valid
* Someting NULL
... then everywhere has to check the value against NULL.
checking against both IS_ERR() and NULL shouldn't ever happen, and
likewise IS_ERR_OR_NULL() is deprecated.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wei Ni <wni@nvidia.com>,
"khali@linux-fr.org" <khali@linux-fr.org>,
Matthew Longnecker <MLongnecker@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] hwmon: (lm90) Add power control
Date: Thu, 08 Aug 2013 11:33:13 -0600 [thread overview]
Message-ID: <5203D659.4050907@wwwdotorg.org> (raw)
In-Reply-To: <52037F9A.7070802@roeck-us.net>
On 08/08/2013 05:23 AM, Guenter Roeck wrote:
> On 08/08/2013 02:47 AM, Wei Ni wrote:
...
>> I think get_regulator() will return error values, not only
>> -EPROBE_DEFER, so we should set data->lm90_reg to NULL to handle other
>> error values.
>>
> Matter of opinion if you want to check for IS_ERR or NULL later on.
No, if regulator returns either:
* Something valid
* Someting IS_ERR()
... then everywhere has to check the value using IS_ERR().
If regulator returns either:
* Something valid
* Someting NULL
... then everywhere has to check the value against NULL.
checking against both IS_ERR() and NULL shouldn't ever happen, and
likewise IS_ERR_OR_NULL() is deprecated.
next prev parent reply other threads:[~2013-08-08 17:33 UTC|newest]
Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 6:56 [PATCH v2 0/3] Add power control for lm90 Wei Ni
2013-08-08 6:56 ` Wei Ni
2013-08-08 6:56 ` Wei Ni
2013-08-08 6:56 ` [lm-sensors] " Wei Ni
2013-08-08 6:56 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-08 6:56 ` Wei Ni
2013-08-08 6:56 ` Wei Ni
2013-08-08 6:56 ` [lm-sensors] " Wei Ni
2013-08-08 7:13 ` Alexander Shiyan
2013-08-08 7:13 ` Alexander Shiyan
2013-08-08 7:13 ` Alexander Shiyan
2013-08-08 7:13 ` [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) Add Alexander Shiyan
[not found] ` <1375946022.222322391-uDhCb/4LxRRsdVUOrk1QfQ@public.gmane.org>
2013-08-08 9:26 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-08 9:26 ` Wei Ni
2013-08-08 9:26 ` Wei Ni
2013-08-08 9:26 ` [lm-sensors] " Wei Ni
[not found] ` <1375944991-29182-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-08 8:42 ` Guenter Roeck
2013-08-08 8:42 ` Guenter Roeck
2013-08-08 8:42 ` Guenter Roeck
2013-08-08 8:42 ` [lm-sensors] " Guenter Roeck
[not found] ` <520359E9.1000600-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-08-08 9:47 ` Wei Ni
2013-08-08 9:47 ` Wei Ni
2013-08-08 9:47 ` Wei Ni
2013-08-08 9:47 ` [lm-sensors] " Wei Ni
2013-08-08 9:57 ` Alexander Shiyan
2013-08-08 9:57 ` Alexander Shiyan
2013-08-08 9:57 ` Alexander Shiyan
2013-08-08 9:57 ` [lm-sensors] [PATCH v2 1/3] hwmon: (lm90) Add Alexander Shiyan
[not found] ` <1375955834.368114617-VbvbiqT9YuJsdVUOrk1QfQ@public.gmane.org>
2013-08-08 9:59 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-08 9:59 ` Wei Ni
2013-08-08 9:59 ` Wei Ni
2013-08-08 9:59 ` [lm-sensors] " Wei Ni
2013-08-08 10:07 ` Wei Ni
2013-08-08 10:07 ` Wei Ni
2013-08-08 10:07 ` Wei Ni
2013-08-08 10:07 ` [lm-sensors] " Wei Ni
[not found] ` <52036920.4050808-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-08 11:23 ` Guenter Roeck
2013-08-08 11:23 ` Guenter Roeck
2013-08-08 11:23 ` Guenter Roeck
2013-08-08 11:23 ` [lm-sensors] " Guenter Roeck
[not found] ` <52037F9A.7070802-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-08-08 17:33 ` Stephen Warren [this message]
2013-08-08 17:33 ` Stephen Warren
2013-08-08 17:33 ` Stephen Warren
2013-08-08 17:33 ` [lm-sensors] " Stephen Warren
[not found] ` <5203D659.4050907-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 17:59 ` [lm-sensors] " Guenter Roeck
[not found] ` <20130808175918.GA15013-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-08-08 18:45 ` Stephen Warren
2013-08-08 18:45 ` Stephen Warren
2013-08-08 18:45 ` Stephen Warren
2013-08-08 18:45 ` [lm-sensors] " Stephen Warren
2013-08-08 17:30 ` Stephen Warren
2013-08-08 17:30 ` Stephen Warren
2013-08-08 17:30 ` Stephen Warren
2013-08-08 17:30 ` [lm-sensors] " Stephen Warren
[not found] ` <5203D5B6.3060806-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 17:59 ` [lm-sensors] " Guenter Roeck
2013-08-08 19:27 ` Mark Brown
2013-08-08 19:27 ` Mark Brown
2013-08-08 19:27 ` Mark Brown
2013-08-08 19:27 ` [lm-sensors] " Mark Brown
2013-08-08 11:01 ` Mark Brown
2013-08-08 11:01 ` Mark Brown
2013-08-08 11:01 ` Mark Brown
2013-08-08 11:01 ` [lm-sensors] " Mark Brown
[not found] ` <20130808110136.GA6427-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-08-08 11:25 ` Guenter Roeck
2013-08-08 11:25 ` Guenter Roeck
2013-08-08 11:25 ` Guenter Roeck
2013-08-08 11:25 ` [lm-sensors] " Guenter Roeck
[not found] ` <52038035.7030803-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-08-08 13:08 ` Mark Brown
2013-08-08 13:08 ` Mark Brown
2013-08-08 13:08 ` Mark Brown
2013-08-08 13:08 ` [lm-sensors] " Mark Brown
2013-08-08 15:21 ` Guenter Roeck
2013-08-08 15:21 ` Guenter Roeck
2013-08-08 15:21 ` [lm-sensors] " Guenter Roeck
[not found] ` <5203B78C.7010101-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-08-08 17:15 ` Mark Brown
2013-08-08 17:15 ` Mark Brown
2013-08-08 17:15 ` Mark Brown
2013-08-08 17:15 ` [lm-sensors] " Mark Brown
[not found] ` <20130808171554.GI6427-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-08-08 20:00 ` Guenter Roeck
2013-08-08 20:00 ` Guenter Roeck
2013-08-08 20:00 ` Guenter Roeck
2013-08-08 20:00 ` [lm-sensors] " Guenter Roeck
[not found] ` <20130808200026.GA18226-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-08-08 21:18 ` Mark Brown
2013-08-08 21:18 ` Mark Brown
2013-08-08 21:18 ` Mark Brown
2013-08-08 21:18 ` [lm-sensors] " Mark Brown
[not found] ` <20130808211825.GN6427-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-08-08 21:30 ` Guenter Roeck
2013-08-08 21:30 ` Guenter Roeck
2013-08-08 21:30 ` Guenter Roeck
2013-08-08 21:30 ` [lm-sensors] " Guenter Roeck
[not found] ` <52040DE2.50201-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-08-09 5:57 ` Proposal: I2C device power (Was: hwmon: (lm90) Add power control) Alexander Shiyan
2013-08-09 5:57 ` Alexander Shiyan
2013-08-09 5:57 ` [lm-sensors] Proposal: I2C device power (Was: hwm =?utf-8?q?on=3A_=28lm90=29_Add_p Alexander Shiyan
2013-08-09 10:27 ` Proposal: I2C device power (Was: hwmon: (lm90) Add power control) Mark Brown
2013-08-09 10:27 ` Mark Brown
2013-08-09 10:27 ` [lm-sensors] " Mark Brown
2013-08-09 10:50 ` Alexander Shiyan
2013-08-09 10:50 ` Alexander Shiyan
2013-08-09 10:50 ` Alexander Shiyan
2013-08-09 10:50 ` [lm-sensors] Proposal: I2C device power (Was: hwm Alexander Shiyan
[not found] ` <1376045411.585130456-gOtJ1i61JehsdVUOrk1QfQ@public.gmane.org>
2013-08-09 11:09 ` Proposal: I2C device power (Was: hwmon: (lm90) Add power control) Mark Brown
2013-08-09 11:09 ` Mark Brown
2013-08-09 11:09 ` Mark Brown
2013-08-09 11:09 ` [lm-sensors] " Mark Brown
2013-08-09 7:23 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-09 7:23 ` Wei Ni
2013-08-09 7:23 ` Wei Ni
2013-08-09 7:23 ` [lm-sensors] " Wei Ni
[not found] ` <520498F3.8030101-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-09 10:56 ` Mark Brown
2013-08-09 10:56 ` Mark Brown
2013-08-09 10:56 ` Mark Brown
2013-08-09 10:56 ` [lm-sensors] " Mark Brown
2013-08-08 6:56 ` [PATCH v2 2/3] ARM: dt: t114 dalmore: add dt entry for nct1008 Wei Ni
2013-08-08 6:56 ` Wei Ni
2013-08-08 6:56 ` Wei Ni
2013-08-08 6:56 ` [lm-sensors] " Wei Ni
[not found] ` <1375944991-29182-3-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-08 17:35 ` Stephen Warren
2013-08-08 17:35 ` Stephen Warren
2013-08-08 17:35 ` Stephen Warren
2013-08-08 17:35 ` [lm-sensors] " Stephen Warren
2013-08-09 6:06 ` Wei Ni
2013-08-09 6:06 ` Wei Ni
2013-08-09 6:06 ` Wei Ni
2013-08-09 6:06 ` [lm-sensors] " Wei Ni
2013-08-08 20:36 ` Sergei Shtylyov
2013-08-08 20:36 ` Sergei Shtylyov
2013-08-08 20:36 ` [lm-sensors] " Sergei Shtylyov
[not found] ` <52040146.7060703-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2013-08-08 20:40 ` Stephen Warren
2013-08-08 20:40 ` Stephen Warren
2013-08-08 20:40 ` Stephen Warren
2013-08-08 20:40 ` [lm-sensors] " Stephen Warren
2013-08-08 21:33 ` Guenter Roeck
2013-08-08 21:33 ` Guenter Roeck
2013-08-08 21:33 ` [lm-sensors] " Guenter Roeck
2013-08-09 6:16 ` Wei Ni
2013-08-09 6:16 ` Wei Ni
2013-08-09 6:16 ` [lm-sensors] " Wei Ni
2013-08-08 6:56 ` [PATCH v2 3/3] Documentation: dt: hwmon: add OF document for lm90 Wei Ni
2013-08-08 6:56 ` Wei Ni
2013-08-08 6:56 ` Wei Ni
2013-08-08 6:56 ` [lm-sensors] " Wei Ni
[not found] ` <1375944991-29182-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-08 17:37 ` Stephen Warren
2013-08-08 17:37 ` Stephen Warren
2013-08-08 17:37 ` Stephen Warren
2013-08-08 17:37 ` [lm-sensors] " Stephen Warren
2013-08-09 6:10 ` Wei Ni
2013-08-09 6:10 ` Wei Ni
2013-08-09 6:10 ` [lm-sensors] " Wei Ni
[not found] ` <520487C7.5080901-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-09 16:35 ` Stephen Warren
2013-08-09 16:35 ` Stephen Warren
2013-08-09 16:35 ` Stephen Warren
2013-08-09 16:35 ` [lm-sensors] " Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203D659.4050907@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.