* Quick failover question
@ 2013-08-09 12:39 Karl Heiss
2013-08-09 13:03 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: Karl Heiss @ 2013-08-09 12:39 UTC (permalink / raw)
To: linux-sctp
Hello,
I happened to be perusing the SCTP code in Linus' tree and noticed
that the following is happening in net/sctp/associola.c,
sctp_assoc_control_transport():
/* Don't inform ULP about transition from PF to
* active state and set cwnd to 1, see SCTP
* Quick failover draft section 5.1, point 5
*/
if (transport->state = SCTP_PF) {
ulp_notify = false;
transport->cwnd = 1;
}
From the quick failover draft, I see that the cwnd should be 1*MTU.
This doesn't seem correct as other places set the cwnd as:
transport->cwnd = asoc->pathmtu;
Am I missing something or is this just a simplification?
Thanks,
Karl
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Quick failover question
2013-08-09 12:39 Quick failover question Karl Heiss
@ 2013-08-09 13:03 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2013-08-09 13:03 UTC (permalink / raw)
To: linux-sctp
On 08/09/2013 02:39 PM, Karl Heiss wrote:
> Hello,
>
> I happened to be perusing the SCTP code in Linus' tree and noticed
> that the following is happening in net/sctp/associola.c,
> sctp_assoc_control_transport():
>
> /* Don't inform ULP about transition from PF to
> * active state and set cwnd to 1, see SCTP
> * Quick failover draft section 5.1, point 5
> */
> if (transport->state = SCTP_PF) {
> ulp_notify = false;
> transport->cwnd = 1;
> }
>
> From the quick failover draft, I see that the cwnd should be 1*MTU.
> This doesn't seem correct as other places set the cwnd as:
>
> transport->cwnd = asoc->pathmtu;
>
> Am I missing something or is this just a simplification?
I think you are correct, that doesn't seem right.
Fix is on its way.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-09 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-09 12:39 Quick failover question Karl Heiss
2013-08-09 13:03 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.