From: Vlad Yasevich <vyasevich@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-sctp@vger.kernel.org, dborkman@redhat.com
Subject: Re: [PATCH] net: sctp: fix panic during skb_orphan()
Date: Sat, 10 Aug 2013 01:34:26 +0000 [thread overview]
Message-ID: <520598A2.8040206@gmail.com> (raw)
In-Reply-To: <1376097622.20509.19.camel@edumazet-glaptop>
On 08/09/2013 09:20 PM, Eric Dumazet wrote:
> On Fri, 2013-08-09 at 20:39 -0400, Vlad Yasevich wrote:
>> On 08/09/2013 07:20 PM, Eric Dumazet wrote:
>
>>> Why not using a dummy destructor ?
>>
>> It would just be useless once we do proper accounting for all chunks.
>> But, I'll send a different idea if this is just too ugly.
>
> Setting skb->sk is no accounting.
Right. It is only really used right now when constructing a packet to
transmit out of a set of chunks.
>
> It seems you would better use skb->cb[] so that you are 100% sure this
> skb->sk doesn't leak outside of SCTP code.
Hmm.. That might work too. I am building a framework right now that
we can use to add proper buffer accounting. That's probably a better
long term solution.
-vlad
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vyasevich@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-sctp@vger.kernel.org, dborkman@redhat.com
Subject: Re: [PATCH] net: sctp: fix panic during skb_orphan()
Date: Fri, 09 Aug 2013 21:34:26 -0400 [thread overview]
Message-ID: <520598A2.8040206@gmail.com> (raw)
In-Reply-To: <1376097622.20509.19.camel@edumazet-glaptop>
On 08/09/2013 09:20 PM, Eric Dumazet wrote:
> On Fri, 2013-08-09 at 20:39 -0400, Vlad Yasevich wrote:
>> On 08/09/2013 07:20 PM, Eric Dumazet wrote:
>
>>> Why not using a dummy destructor ?
>>
>> It would just be useless once we do proper accounting for all chunks.
>> But, I'll send a different idea if this is just too ugly.
>
> Setting skb->sk is no accounting.
Right. It is only really used right now when constructing a packet to
transmit out of a set of chunks.
>
> It seems you would better use skb->cb[] so that you are 100% sure this
> skb->sk doesn't leak outside of SCTP code.
Hmm.. That might work too. I am building a framework right now that
we can use to add proper buffer accounting. That's probably a better
long term solution.
-vlad
next prev parent reply other threads:[~2013-08-10 1:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 10:42 [PATCH net-next] net: sctp: sctp_set_owner_w: fix panic during skb orphaning Daniel Borkmann
2013-08-07 10:42 ` Daniel Borkmann
2013-08-08 5:57 ` Neil Horman
2013-08-08 5:57 ` Neil Horman
2013-08-09 20:37 ` David Miller
2013-08-09 20:37 ` David Miller
2013-08-09 20:47 ` Daniel Borkmann
2013-08-09 20:47 ` Daniel Borkmann
2013-08-09 21:58 ` [PATCH] net: sctp: fix panic during skb_orphan() Vlad Yasevich
2013-08-09 21:58 ` Vlad Yasevich
2013-08-09 23:20 ` Eric Dumazet
2013-08-09 23:20 ` Eric Dumazet
2013-08-10 0:39 ` Vlad Yasevich
2013-08-10 0:39 ` Vlad Yasevich
2013-08-10 1:20 ` Eric Dumazet
2013-08-10 1:20 ` Eric Dumazet
2013-08-10 1:34 ` Vlad Yasevich [this message]
2013-08-10 1:34 ` Vlad Yasevich
2013-08-10 2:05 ` [PATCH net-next] net: sctp: Add rudimentary infrastructure to account for control chunks Vlad Yasevich
2013-08-10 2:05 ` Vlad Yasevich
2013-08-13 22:04 ` David Miller
2013-08-13 22:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520598A2.8040206@gmail.com \
--to=vyasevich@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.