* [lm-sensors] [PATCH 1/1] hwmon: (asus_atk0110) Fix incorrect placement of __initconst
@ 2013-08-12 9:32 Sachin Kamat
2013-08-12 11:18 ` Guenter Roeck
2013-08-27 15:27 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-08-12 9:32 UTC (permalink / raw)
To: lm-sensors
__initconst should be placed between the variable name and equal
sign for the variable to be placed in the intended section.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Luca Tettamanti <kronos.it@gmail.com>
---
drivers/hwmon/asus_atk0110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
index b25c643..9ddadb3 100644
--- a/drivers/hwmon/asus_atk0110.c
+++ b/drivers/hwmon/asus_atk0110.c
@@ -29,7 +29,7 @@ static bool new_if;
module_param(new_if, bool, 0);
MODULE_PARM_DESC(new_if, "Override detection heuristic and force the use of the new ATK0110 interface");
-static const struct dmi_system_id __initconst atk_force_new_if[] = {
+static const struct dmi_system_id atk_force_new_if[] __initconst = {
{
/* Old interface has broken MCH temp monitoring */
.ident = "Asus Sabertooth X58",
--
1.7.9.5
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 1/1] hwmon: (asus_atk0110) Fix incorrect placement of __initconst
2013-08-12 9:32 [lm-sensors] [PATCH 1/1] hwmon: (asus_atk0110) Fix incorrect placement of __initconst Sachin Kamat
@ 2013-08-12 11:18 ` Guenter Roeck
2013-08-27 15:27 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-08-12 11:18 UTC (permalink / raw)
To: lm-sensors
On 08/12/2013 02:20 AM, Sachin Kamat wrote:
> __initconst should be placed between the variable name and equal
> sign for the variable to be placed in the intended section.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Luca Tettamanti <kronos.it@gmail.com>
> ---
Applied to -next.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 1/1] hwmon: (asus_atk0110) Fix incorrect placement of __initconst
2013-08-12 9:32 [lm-sensors] [PATCH 1/1] hwmon: (asus_atk0110) Fix incorrect placement of __initconst Sachin Kamat
2013-08-12 11:18 ` Guenter Roeck
@ 2013-08-27 15:27 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2013-08-27 15:27 UTC (permalink / raw)
To: lm-sensors
On Mon, Aug 12, 2013 at 02:50:40PM +0530, Sachin Kamat wrote:
> __initconst should be placed between the variable name and equal
> sign for the variable to be placed in the intended section.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Luca Tettamanti <kronos.it@gmail.com>
> ---
> drivers/hwmon/asus_atk0110.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
> index b25c643..9ddadb3 100644
> --- a/drivers/hwmon/asus_atk0110.c
> +++ b/drivers/hwmon/asus_atk0110.c
> @@ -29,7 +29,7 @@ static bool new_if;
> module_param(new_if, bool, 0);
> MODULE_PARM_DESC(new_if, "Override detection heuristic and force the use of the new ATK0110 interface");
>
> -static const struct dmi_system_id __initconst atk_force_new_if[] = {
> +static const struct dmi_system_id atk_force_new_if[] __initconst = {
> {
> /* Old interface has broken MCH temp monitoring */
> .ident = "Asus Sabertooth X58",
Based on the other discussion we just had, this patch is unnecessary.
I will therefore drop it from my queue.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-27 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-12 9:32 [lm-sensors] [PATCH 1/1] hwmon: (asus_atk0110) Fix incorrect placement of __initconst Sachin Kamat
2013-08-12 11:18 ` Guenter Roeck
2013-08-27 15:27 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.