From: Stephen Warren <swarren@wwwdotorg.org>
To: dinguyen@altera.com
Cc: dinh.linux@gmail.com, Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>,
devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3] ARM: socfpga: dts: Add support for SD/MMC
Date: Tue, 13 Aug 2013 13:52:17 -0600 [thread overview]
Message-ID: <520A8E71.4090508@wwwdotorg.org> (raw)
In-Reply-To: <1376322589-17606-1-git-send-email-dinguyen@altera.com>
On 08/12/2013 09:49 AM, dinguyen@altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Add bindings for SD/MMC for SOCFPGA.
> Add "syscon" to the "altr,sys-mgr" binding.
> diff --git a/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt
I think it's reasonable to define one binding as being based on another
plus some additions, so, the binding,
Acked-by: Stephen Warren <swarren@nvidia.com>
> +Example:
> + dwmmc0@ff704000 {
> + compatible = "altr,socfpga-dw-mshc", "snps,dw-mshc";
> + altr,dw-mshc-sdr-timing = <0 3>;
> + };
It'd be nice to provide a complete example though, rather than only
including the properties that this binding adds to the base binding.
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> sysmgr@ffd08000 {
> - compatible = "altr,sys-mgr";
> + compatible = "altr,sys-mgr", "syscon";
That seems like an unrelated change?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] ARM: socfpga: dts: Add support for SD/MMC
Date: Tue, 13 Aug 2013 13:52:17 -0600 [thread overview]
Message-ID: <520A8E71.4090508@wwwdotorg.org> (raw)
In-Reply-To: <1376322589-17606-1-git-send-email-dinguyen@altera.com>
On 08/12/2013 09:49 AM, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Add bindings for SD/MMC for SOCFPGA.
> Add "syscon" to the "altr,sys-mgr" binding.
> diff --git a/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/socfpga-dw-mshc.txt
I think it's reasonable to define one binding as being based on another
plus some additions, so, the binding,
Acked-by: Stephen Warren <swarren@nvidia.com>
> +Example:
> + dwmmc0 at ff704000 {
> + compatible = "altr,socfpga-dw-mshc", "snps,dw-mshc";
> + altr,dw-mshc-sdr-timing = <0 3>;
> + };
It'd be nice to provide a complete example though, rather than only
including the properties that this binding adds to the base binding.
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> sysmgr at ffd08000 {
> - compatible = "altr,sys-mgr";
> + compatible = "altr,sys-mgr", "syscon";
That seems like an unrelated change?
next prev parent reply other threads:[~2013-08-13 19:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 15:49 [PATCHv3] ARM: socfpga: dts: Add support for SD/MMC dinguyen
2013-08-12 15:49 ` dinguyen at altera.com
2013-08-13 19:52 ` Stephen Warren [this message]
2013-08-13 19:52 ` Stephen Warren
2013-08-13 19:58 ` Dinh Nguyen
2013-08-13 19:58 ` Dinh Nguyen
2013-08-13 20:10 ` Stephen Warren
2013-08-13 20:10 ` Stephen Warren
2013-08-13 20:17 ` Dinh Nguyen
2013-08-13 20:17 ` Dinh Nguyen
2013-08-13 20:24 ` Stephen Warren
2013-08-13 20:24 ` Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2013-06-28 5:35 dinh.linux
2013-06-28 5:35 ` dinh.linux
2013-06-28 11:28 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A8E71.4090508@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.