* [PATCH] mmc: omap_hsmmc: fix dependency on indirect header inclusion
@ 2013-07-11 13:09 Felipe Balbi
2013-08-16 16:29 ` Balaji T K
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2013-07-11 13:09 UTC (permalink / raw)
To: cjb
Cc: linux-mmc, linux-omap, Balaji T K, a-bindra, Tony Lindgren,
ezequiel.garcia, nm, Felipe Balbi
omap_hsmmc.c depends on <linux/sizes.h> being
included indirectly by another header. Once we
enable COMPILE_TEST for this driver, we might
compile under architectures which won't include
<linux/sizes.h> for us. In fact, one such case
is x86.
In order to prevent compile breakages, let's
explicitly include <linux/sizes.h>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
This should be applied before http://marc.info/?l=linux-omap&m=137347241524118&w=2
in order to maintain bisectability.
cheers
drivers/mmc/host/omap_hsmmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 1865321..c937ffc 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -21,6 +21,7 @@
#include <linux/debugfs.h>
#include <linux/dmaengine.h>
#include <linux/seq_file.h>
+#include <linux/sizes.h>
#include <linux/interrupt.h>
#include <linux/delay.h>
#include <linux/dma-mapping.h>
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: fix dependency on indirect header inclusion
2013-07-11 13:09 [PATCH] mmc: omap_hsmmc: fix dependency on indirect header inclusion Felipe Balbi
@ 2013-08-16 16:29 ` Balaji T K
2013-08-25 2:51 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Balaji T K @ 2013-08-16 16:29 UTC (permalink / raw)
To: cjb, linux-mmc
Cc: Felipe Balbi, linux-omap, a-bindra, Tony Lindgren,
ezequiel.garcia, nm
On Thursday 11 July 2013 06:39 PM, Felipe Balbi wrote:
> omap_hsmmc.c depends on <linux/sizes.h> being
> included indirectly by another header. Once we
> enable COMPILE_TEST for this driver, we might
> compile under architectures which won't include
> <linux/sizes.h> for us. In fact, one such case
> is x86.
>
> In order to prevent compile breakages, let's
> explicitly include <linux/sizes.h>
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>
> This should be applied before http://marc.info/?l=linux-omap&m=137347241524118&w=2
> in order to maintain bisectability.
Thanks Felipe
Acked-by: Balaji T K <balajitk@ti.com>
>
> cheers
>
> drivers/mmc/host/omap_hsmmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 1865321..c937ffc 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -21,6 +21,7 @@
> #include <linux/debugfs.h>
> #include <linux/dmaengine.h>
> #include <linux/seq_file.h>
> +#include <linux/sizes.h>
> #include <linux/interrupt.h>
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: omap_hsmmc: fix dependency on indirect header inclusion
2013-08-16 16:29 ` Balaji T K
@ 2013-08-25 2:51 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2013-08-25 2:51 UTC (permalink / raw)
To: Balaji T K
Cc: linux-mmc, Felipe Balbi, linux-omap, a-bindra, Tony Lindgren,
ezequiel.garcia, nm
Hi,
On Fri, Aug 16 2013, Balaji T K wrote:
> On Thursday 11 July 2013 06:39 PM, Felipe Balbi wrote:
>> omap_hsmmc.c depends on <linux/sizes.h> being
>> included indirectly by another header. Once we
>> enable COMPILE_TEST for this driver, we might
>> compile under architectures which won't include
>> <linux/sizes.h> for us. In fact, one such case
>> is x86.
>>
>> In order to prevent compile breakages, let's
>> explicitly include <linux/sizes.h>
>>
>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>> ---
>>
>> This should be applied before
>> http://marc.info/?l=linux-omap&m=137347241524118&w=2
>> in order to maintain bisectability.
> Thanks Felipe
>
> Acked-by: Balaji T K <balajitk@ti.com>
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-25 2:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-11 13:09 [PATCH] mmc: omap_hsmmc: fix dependency on indirect header inclusion Felipe Balbi
2013-08-16 16:29 ` Balaji T K
2013-08-25 2:51 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.