All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajendra Nayak <rnayak@ti.com>
To: Afzal Mohammed <afzal@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
	benoit.cousson@gmail.com, Ambresh K <ambresh@ti.com>,
	Benoit Cousson <benoit.cousson@linaro.org>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 10/13] ARM: OMAP2+: hwmod: AM43x operations
Date: Wed, 21 Aug 2013 17:00:29 +0530	[thread overview]
Message-ID: <5214A4D5.4000700@ti.com> (raw)
In-Reply-To: <838ab5ad788f64cef1e8859409490aa2b495d1ee.1375443858.git.afzal@ti.com>

On Friday 02 August 2013 07:08 PM, Afzal Mohammed wrote:
> Reuse OMAP4 operations on AM43x.
> 
> Signed-off-by: Ambresh K <ambresh@ti.com>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 7f4db12..a1b7e20 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -4123,6 +4123,14 @@ void __init omap_hwmod_init(void)
>  		soc_ops.init_clkdm = _init_clkdm;
>  		soc_ops.update_context_lost = _omap4_update_context_lost;
>  		soc_ops.get_context_lost = _omap4_get_context_lost;
> +	} else if (soc_is_am43xx()) {
> +		soc_ops.enable_module = _omap4_enable_module;
> +		soc_ops.disable_module = _omap4_disable_module;
> +		soc_ops.wait_target_ready = _omap4_wait_target_ready;
> +		soc_ops.assert_hardreset = _omap4_assert_hardreset;
> +		soc_ops.deassert_hardreset = _omap4_deassert_hardreset;
> +		soc_ops.is_hardreset_asserted = _omap4_is_hardreset_asserted;
> +		soc_ops.init_clkdm = _init_clkdm;

Did you leave out soc_ops.update_context_lost and soc_ops.get_context_lost on
purpose?

>  	} else if (soc_is_am33xx()) {
>  		soc_ops.enable_module = _am33xx_enable_module;
>  		soc_ops.disable_module = _am33xx_disable_module;
> 

WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 10/13] ARM: OMAP2+: hwmod: AM43x operations
Date: Wed, 21 Aug 2013 17:00:29 +0530	[thread overview]
Message-ID: <5214A4D5.4000700@ti.com> (raw)
In-Reply-To: <838ab5ad788f64cef1e8859409490aa2b495d1ee.1375443858.git.afzal@ti.com>

On Friday 02 August 2013 07:08 PM, Afzal Mohammed wrote:
> Reuse OMAP4 operations on AM43x.
> 
> Signed-off-by: Ambresh K <ambresh@ti.com>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 7f4db12..a1b7e20 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -4123,6 +4123,14 @@ void __init omap_hwmod_init(void)
>  		soc_ops.init_clkdm = _init_clkdm;
>  		soc_ops.update_context_lost = _omap4_update_context_lost;
>  		soc_ops.get_context_lost = _omap4_get_context_lost;
> +	} else if (soc_is_am43xx()) {
> +		soc_ops.enable_module = _omap4_enable_module;
> +		soc_ops.disable_module = _omap4_disable_module;
> +		soc_ops.wait_target_ready = _omap4_wait_target_ready;
> +		soc_ops.assert_hardreset = _omap4_assert_hardreset;
> +		soc_ops.deassert_hardreset = _omap4_deassert_hardreset;
> +		soc_ops.is_hardreset_asserted = _omap4_is_hardreset_asserted;
> +		soc_ops.init_clkdm = _init_clkdm;

Did you leave out soc_ops.update_context_lost and soc_ops.get_context_lost on
purpose?

>  	} else if (soc_is_am33xx()) {
>  		soc_ops.enable_module = _am33xx_enable_module;
>  		soc_ops.disable_module = _am33xx_disable_module;
> 

  reply	other threads:[~2013-08-21 11:30 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02 13:35 [PATCH v2 00/13] ARM: OMAP2+: AM43x PRCM support Afzal Mohammed
2013-08-02 13:35 ` Afzal Mohammed
2013-08-02 13:36 ` [PATCH v2 01/13] ARM: OMAP2+: CM: reintroduce SW_SLEEP for OMAP4 Afzal Mohammed
2013-08-02 13:36   ` Afzal Mohammed
2013-08-21  7:13   ` Rajendra Nayak
2013-08-21  7:13     ` Rajendra Nayak
2013-08-28 12:14     ` Afzal Mohammed
2013-08-28 12:14       ` Afzal Mohammed
2013-08-30 18:04     ` Vaibhav Bedia
2013-08-30 18:04       ` Vaibhav Bedia
2013-08-02 13:36 ` [PATCH v2 02/13] ARM: OMAP2+: hwmod: AM335x: prepare for AM43x reuse Afzal Mohammed
2013-08-02 13:36   ` Afzal Mohammed
2013-08-21  8:37   ` Rajendra Nayak
2013-08-21  8:37     ` Rajendra Nayak
2013-08-02 13:36 ` [PATCH v2 03/13] ARM: OMAP2+: hwmod: AMx3: runtime AM335x handling Afzal Mohammed
2013-08-02 13:36   ` Afzal Mohammed
2013-08-21 11:28   ` Rajendra Nayak
2013-08-21 11:28     ` Rajendra Nayak
2013-08-02 13:37 ` [PATCH v2 04/13] ARM: OMAP2+: hwmod: AMx3: remove common static fields Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 05/13] ARM: OMAP2+: CM: cm_inst offset s16->u16 Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 06/13] ARM: OMAP2+: PRCM: AM43x definitions Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-21  3:20   ` Paul Walmsley
2013-08-21  3:20     ` Paul Walmsley
2013-08-28 12:03     ` Afzal Mohammed
2013-08-28 12:03       ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 07/13] ARM: OMAP2+: PM: AM43x powerdomain data Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 08/13] ARM: OMAP2+: CM: AM43x clockdomain data Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 09/13] ARM: OMAP2+: hwmod: AMx3: runtime AM43x handling Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 10/13] ARM: OMAP2+: hwmod: AM43x operations Afzal Mohammed
2013-08-02 13:38   ` Afzal Mohammed
2013-08-21 11:30   ` Rajendra Nayak [this message]
2013-08-21 11:30     ` Rajendra Nayak
2013-08-28 12:29     ` Afzal Mohammed
2013-08-28 12:29       ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 11/13] ARM: OMAP2+: AM43x: PRCM kbuild Afzal Mohammed
2013-08-02 13:38   ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 12/13] ARM: OMAP2+: AM43x PRCM init Afzal Mohammed
2013-08-02 13:38   ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 13/13] ARM: OMAP2+: hwmod: AM43x: new w.r.t AM335x Afzal Mohammed
2013-08-02 13:38   ` Afzal Mohammed
2013-08-21 11:33   ` Rajendra Nayak
2013-08-21 11:33     ` Rajendra Nayak
2013-08-13  8:01 ` [PATCH v2 00/13] ARM: OMAP2+: AM43x PRCM support Tony Lindgren
2013-08-13  8:01   ` Tony Lindgren
2013-08-19  6:36   ` Afzal Mohammed
2013-08-19  6:36     ` Afzal Mohammed
2013-08-20  9:18     ` Benoit Cousson
2013-08-20  9:18       ` Benoit Cousson
2013-08-28 12:09       ` Afzal Mohammed
2013-08-28 12:09         ` Afzal Mohammed
2013-08-21  2:53 ` Paul Walmsley
2013-08-21  2:53   ` Paul Walmsley
2013-08-28 12:03   ` Afzal Mohammed
2013-08-28 12:03     ` Afzal Mohammed
2013-08-21 11:44 ` Rajendra Nayak
2013-08-21 11:44   ` Rajendra Nayak
2013-08-29 14:00   ` Afzal Mohammed
2013-08-29 14:00     ` Afzal Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5214A4D5.4000700@ti.com \
    --to=rnayak@ti.com \
    --cc=afzal@ti.com \
    --cc=ambresh@ti.com \
    --cc=benoit.cousson@gmail.com \
    --cc=benoit.cousson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.