All of lore.kernel.org
 help / color / mirror / Atom feed
From: Afzal Mohammed <afzal@ti.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Tony Lindgren <tony@atomide.com>,
	Benoit Cousson <benoit.cousson@linaro.org>,
	Paul Walmsley <paul@pwsan.com>,
	benoit.cousson@gmail.com, Vaibhav Bedia <vaibhav.bedia@ti.com>
Subject: Re: [PATCH v2 01/13] ARM: OMAP2+: CM: reintroduce SW_SLEEP for OMAP4
Date: Wed, 28 Aug 2013 17:44:15 +0530	[thread overview]
Message-ID: <521DE997.1050106@ti.com> (raw)
In-Reply-To: <5214688C.9030801@ti.com>

Hi Rajendra,

On Wednesday 21 August 2013 12:43 PM, Rajendra Nayak wrote:

>> +void omap4_cminst_clkdm_force_sleep(u8 part, s16 inst, u16 cdoffs)
>> +{
>> +	_clktrctrl_write(OMAP34XX_CLKSTCTRL_FORCE_SLEEP, part, inst, cdoffs);
> 
> I guess this won't work on omap4/5 where some clockdomains do not support
> SW_SLEEP and only support HW_AUTO. We might need to have different clkdm
> operations for the different omap4 variants.

Yes, this has to be reworked using clockdomain flag to handle
appropriately the above scenario.

Regards
Afzal

>>  static int omap4_clkdm_sleep(struct clockdomain *clkdm)
>>  {
>> -	omap4_cminst_clkdm_enable_hwsup(clkdm->prcm_partition,
>> -					clkdm->cm_inst, clkdm->clkdm_offs);
>> +	omap4_cminst_clkdm_force_sleep(clkdm->prcm_partition,
>> +				       clkdm->cm_inst, clkdm->clkdm_offs);
>>  	return 0;
>>  }
>>  
>>
> 


WARNING: multiple messages have this Message-ID (diff)
From: afzal@ti.com (Afzal Mohammed)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/13] ARM: OMAP2+: CM: reintroduce SW_SLEEP for OMAP4
Date: Wed, 28 Aug 2013 17:44:15 +0530	[thread overview]
Message-ID: <521DE997.1050106@ti.com> (raw)
In-Reply-To: <5214688C.9030801@ti.com>

Hi Rajendra,

On Wednesday 21 August 2013 12:43 PM, Rajendra Nayak wrote:

>> +void omap4_cminst_clkdm_force_sleep(u8 part, s16 inst, u16 cdoffs)
>> +{
>> +	_clktrctrl_write(OMAP34XX_CLKSTCTRL_FORCE_SLEEP, part, inst, cdoffs);
> 
> I guess this won't work on omap4/5 where some clockdomains do not support
> SW_SLEEP and only support HW_AUTO. We might need to have different clkdm
> operations for the different omap4 variants.

Yes, this has to be reworked using clockdomain flag to handle
appropriately the above scenario.

Regards
Afzal

>>  static int omap4_clkdm_sleep(struct clockdomain *clkdm)
>>  {
>> -	omap4_cminst_clkdm_enable_hwsup(clkdm->prcm_partition,
>> -					clkdm->cm_inst, clkdm->clkdm_offs);
>> +	omap4_cminst_clkdm_force_sleep(clkdm->prcm_partition,
>> +				       clkdm->cm_inst, clkdm->clkdm_offs);
>>  	return 0;
>>  }
>>  
>>
> 

  reply	other threads:[~2013-08-28 12:14 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02 13:35 [PATCH v2 00/13] ARM: OMAP2+: AM43x PRCM support Afzal Mohammed
2013-08-02 13:35 ` Afzal Mohammed
2013-08-02 13:36 ` [PATCH v2 01/13] ARM: OMAP2+: CM: reintroduce SW_SLEEP for OMAP4 Afzal Mohammed
2013-08-02 13:36   ` Afzal Mohammed
2013-08-21  7:13   ` Rajendra Nayak
2013-08-21  7:13     ` Rajendra Nayak
2013-08-28 12:14     ` Afzal Mohammed [this message]
2013-08-28 12:14       ` Afzal Mohammed
2013-08-30 18:04     ` Vaibhav Bedia
2013-08-30 18:04       ` Vaibhav Bedia
2013-08-02 13:36 ` [PATCH v2 02/13] ARM: OMAP2+: hwmod: AM335x: prepare for AM43x reuse Afzal Mohammed
2013-08-02 13:36   ` Afzal Mohammed
2013-08-21  8:37   ` Rajendra Nayak
2013-08-21  8:37     ` Rajendra Nayak
2013-08-02 13:36 ` [PATCH v2 03/13] ARM: OMAP2+: hwmod: AMx3: runtime AM335x handling Afzal Mohammed
2013-08-02 13:36   ` Afzal Mohammed
2013-08-21 11:28   ` Rajendra Nayak
2013-08-21 11:28     ` Rajendra Nayak
2013-08-02 13:37 ` [PATCH v2 04/13] ARM: OMAP2+: hwmod: AMx3: remove common static fields Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 05/13] ARM: OMAP2+: CM: cm_inst offset s16->u16 Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 06/13] ARM: OMAP2+: PRCM: AM43x definitions Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-21  3:20   ` Paul Walmsley
2013-08-21  3:20     ` Paul Walmsley
2013-08-28 12:03     ` Afzal Mohammed
2013-08-28 12:03       ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 07/13] ARM: OMAP2+: PM: AM43x powerdomain data Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 08/13] ARM: OMAP2+: CM: AM43x clockdomain data Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:37 ` [PATCH v2 09/13] ARM: OMAP2+: hwmod: AMx3: runtime AM43x handling Afzal Mohammed
2013-08-02 13:37   ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 10/13] ARM: OMAP2+: hwmod: AM43x operations Afzal Mohammed
2013-08-02 13:38   ` Afzal Mohammed
2013-08-21 11:30   ` Rajendra Nayak
2013-08-21 11:30     ` Rajendra Nayak
2013-08-28 12:29     ` Afzal Mohammed
2013-08-28 12:29       ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 11/13] ARM: OMAP2+: AM43x: PRCM kbuild Afzal Mohammed
2013-08-02 13:38   ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 12/13] ARM: OMAP2+: AM43x PRCM init Afzal Mohammed
2013-08-02 13:38   ` Afzal Mohammed
2013-08-02 13:38 ` [PATCH v2 13/13] ARM: OMAP2+: hwmod: AM43x: new w.r.t AM335x Afzal Mohammed
2013-08-02 13:38   ` Afzal Mohammed
2013-08-21 11:33   ` Rajendra Nayak
2013-08-21 11:33     ` Rajendra Nayak
2013-08-13  8:01 ` [PATCH v2 00/13] ARM: OMAP2+: AM43x PRCM support Tony Lindgren
2013-08-13  8:01   ` Tony Lindgren
2013-08-19  6:36   ` Afzal Mohammed
2013-08-19  6:36     ` Afzal Mohammed
2013-08-20  9:18     ` Benoit Cousson
2013-08-20  9:18       ` Benoit Cousson
2013-08-28 12:09       ` Afzal Mohammed
2013-08-28 12:09         ` Afzal Mohammed
2013-08-21  2:53 ` Paul Walmsley
2013-08-21  2:53   ` Paul Walmsley
2013-08-28 12:03   ` Afzal Mohammed
2013-08-28 12:03     ` Afzal Mohammed
2013-08-21 11:44 ` Rajendra Nayak
2013-08-21 11:44   ` Rajendra Nayak
2013-08-29 14:00   ` Afzal Mohammed
2013-08-29 14:00     ` Afzal Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521DE997.1050106@ti.com \
    --to=afzal@ti.com \
    --cc=benoit.cousson@gmail.com \
    --cc=benoit.cousson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    --cc=tony@atomide.com \
    --cc=vaibhav.bedia@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.