From: Stefan Weil <sw@weilnetz.de>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: linaro-kernel@lists.linaro.org, qemu-devel@nongnu.org,
patches@linaro.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [Qemu-devel] [PATCH] migration: Fix debug print type
Date: Fri, 23 Aug 2013 09:11:21 +0200 [thread overview]
Message-ID: <52170B19.2080909@weilnetz.de> (raw)
In-Reply-To: <1377241601-29105-1-git-send-email-christoffer.dall@linaro.org>
See my comment below.
Am 23.08.2013 09:06, schrieb Christoffer Dall:
> The printf args are uint64_t and with -Werr QEMU doesn't compile with
> migration debugging turned on unless this is fixed. Fix it.
>
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
> migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration.c b/migration.c
> index 1402fa7..0d8706f 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -566,7 +566,7 @@ static void *migration_thread(void *opaque)
> if (!qemu_file_rate_limit(s->file)) {
> DPRINTF("iterate\n");
> pending_size = qemu_savevm_state_pending(s->file, max_size);
> - DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
> + DPRINTF("pending size %llu max %llu\n", pending_size, max_size);
Please use PRIu64 for uint64_t.
> if (pending_size && pending_size >= max_size) {
> qemu_savevm_state_iterate(s->file);
> } else {
prev parent reply other threads:[~2013-08-23 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 7:06 [Qemu-devel] [PATCH] migration: Fix debug print type Christoffer Dall
2013-08-23 7:11 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52170B19.2080909@weilnetz.de \
--to=sw@weilnetz.de \
--cc=christoffer.dall@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linaro-kernel@lists.linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.