* [Qemu-devel] [PATCH] migration: Fix debug print type
@ 2013-08-23 7:06 Christoffer Dall
2013-08-23 7:11 ` Stefan Weil
0 siblings, 1 reply; 2+ messages in thread
From: Christoffer Dall @ 2013-08-23 7:06 UTC (permalink / raw)
To: qemu-devel; +Cc: linaro-kernel, kvmarm, Christoffer Dall, patches
The printf args are uint64_t and with -Werr QEMU doesn't compile with
migration debugging turned on unless this is fixed. Fix it.
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index 1402fa7..0d8706f 100644
--- a/migration.c
+++ b/migration.c
@@ -566,7 +566,7 @@ static void *migration_thread(void *opaque)
if (!qemu_file_rate_limit(s->file)) {
DPRINTF("iterate\n");
pending_size = qemu_savevm_state_pending(s->file, max_size);
- DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
+ DPRINTF("pending size %llu max %llu\n", pending_size, max_size);
if (pending_size && pending_size >= max_size) {
qemu_savevm_state_iterate(s->file);
} else {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] migration: Fix debug print type
2013-08-23 7:06 [Qemu-devel] [PATCH] migration: Fix debug print type Christoffer Dall
@ 2013-08-23 7:11 ` Stefan Weil
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Weil @ 2013-08-23 7:11 UTC (permalink / raw)
To: Christoffer Dall; +Cc: linaro-kernel, qemu-devel, patches, kvmarm
See my comment below.
Am 23.08.2013 09:06, schrieb Christoffer Dall:
> The printf args are uint64_t and with -Werr QEMU doesn't compile with
> migration debugging turned on unless this is fixed. Fix it.
>
> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
> migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration.c b/migration.c
> index 1402fa7..0d8706f 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -566,7 +566,7 @@ static void *migration_thread(void *opaque)
> if (!qemu_file_rate_limit(s->file)) {
> DPRINTF("iterate\n");
> pending_size = qemu_savevm_state_pending(s->file, max_size);
> - DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
> + DPRINTF("pending size %llu max %llu\n", pending_size, max_size);
Please use PRIu64 for uint64_t.
> if (pending_size && pending_size >= max_size) {
> qemu_savevm_state_iterate(s->file);
> } else {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-23 7:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23 7:06 [Qemu-devel] [PATCH] migration: Fix debug print type Christoffer Dall
2013-08-23 7:11 ` Stefan Weil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.