From: Brian Norris <computersforpeace@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org, b44548@freescale.com,
dedekind1@gmail.com, b18965@freescale.com,
linux-spi@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
shawn.guo@linaro.org, dwmw2@infradead.org,
wangyuhang <wangyuhang2014@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V1 3/5] mtd: m25p80: add the quad-read support
Date: Fri, 23 Aug 2013 04:23:44 -0700 [thread overview]
Message-ID: <52174640.701@gmail.com> (raw)
In-Reply-To: <20130822195559.GU26118@sirena.org.uk>
On 08/22/2013 12:55 PM, Mark Brown wrote:
> On Thu, Aug 22, 2013 at 12:34:53PM -0700, Brian Norris wrote:
>> What you're really missing from device-tree (and the SPI subystem in
>> general) is how to detect those SPI controllers which support dual and
>> quad mode transfers, and how to communicate that a particular SPI
>> transaction should be performed on 1 or 4 IO lines. We shouldn't have
>> this just hacked in via assumptions.
>
> That bit does need to be fixed in this driver, yes. The SPI core now
> has quad mode support.
Where? Perhaps I'm missing the obvious, but I don't see SPI core quad
support in linux-next or in Linus' tree.
Brian
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V1 3/5] mtd: m25p80: add the quad-read support
Date: Fri, 23 Aug 2013 04:23:44 -0700 [thread overview]
Message-ID: <52174640.701@gmail.com> (raw)
In-Reply-To: <20130822195559.GU26118@sirena.org.uk>
On 08/22/2013 12:55 PM, Mark Brown wrote:
> On Thu, Aug 22, 2013 at 12:34:53PM -0700, Brian Norris wrote:
>> What you're really missing from device-tree (and the SPI subystem in
>> general) is how to detect those SPI controllers which support dual and
>> quad mode transfers, and how to communicate that a particular SPI
>> transaction should be performed on 1 or 4 IO lines. We shouldn't have
>> this just hacked in via assumptions.
>
> That bit does need to be fixed in this driver, yes. The SPI core now
> has quad mode support.
Where? Perhaps I'm missing the obvious, but I don't see SPI core quad
support in linux-next or in Linus' tree.
Brian
next prev parent reply other threads:[~2013-08-23 11:23 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 4:09 [PATCH V1 0/5] Add the Quadspi driver for vf610-twr Huang Shijie
2013-08-19 4:09 ` Huang Shijie
2013-08-19 4:09 ` [PATCH V1 1/5] mtd: m25p80: move the spi-nor commands to a header Huang Shijie
2013-08-19 4:09 ` Huang Shijie
2013-08-19 4:10 ` [PATCH V1 2/5] mtd: m25p80: add support for Spansion s25fl128s chip Huang Shijie
2013-08-19 4:10 ` Huang Shijie
2013-08-19 4:10 ` [PATCH V1 3/5] mtd: m25p80: add the quad-read support Huang Shijie
2013-08-19 4:10 ` Huang Shijie
2013-08-22 19:34 ` Brian Norris
2013-08-22 19:34 ` Brian Norris
2013-08-22 19:55 ` Mark Brown
2013-08-22 19:55 ` Mark Brown
2013-08-22 20:29 ` Marek Vasut
2013-08-22 20:29 ` Marek Vasut
2013-08-22 23:36 ` Mark Brown
2013-08-22 23:36 ` Mark Brown
2013-08-22 23:58 ` Marek Vasut
2013-08-22 23:58 ` Marek Vasut
2013-08-23 9:41 ` Mark Brown
2013-08-23 9:41 ` Mark Brown
2013-08-23 10:42 ` Marek Vasut
2013-08-23 10:42 ` Marek Vasut
2013-08-23 11:46 ` Brian Norris
2013-08-23 11:46 ` Brian Norris
2013-08-23 11:53 ` Brian Norris
2013-08-23 11:53 ` Brian Norris
2013-08-23 12:01 ` Mark Brown
2013-08-23 12:01 ` Mark Brown
2013-08-23 13:20 ` yuhang wang
2013-08-23 13:20 ` yuhang wang
2013-08-23 6:26 ` Huang Shijie
2013-08-23 6:26 ` Huang Shijie
2013-08-23 11:23 ` Brian Norris [this message]
2013-08-23 11:23 ` Brian Norris
2013-08-23 11:27 ` Sourav Poddar
2013-08-23 11:27 ` Sourav Poddar
2013-08-23 11:30 ` Mark Brown
2013-08-23 11:30 ` Mark Brown
2013-08-23 9:05 ` yuhang wang
2013-08-23 9:05 ` yuhang wang
2013-08-23 9:25 ` Huang Shijie
2013-08-23 9:25 ` Huang Shijie
2013-08-23 9:57 ` Sourav Poddar
2013-08-23 9:57 ` Sourav Poddar
2013-08-24 2:45 ` Huang Shijie
2013-08-24 2:45 ` Huang Shijie
2013-08-23 15:59 ` Sourav Poddar
2013-08-23 15:59 ` Sourav Poddar
2013-08-23 13:59 ` yuhang wang
2013-08-23 13:59 ` yuhang wang
2013-08-24 3:01 ` Huang Shijie
2013-08-24 3:01 ` Huang Shijie
2013-08-19 4:10 ` [PATCH V1 4/5] spi: Add Freescale QuadSpi driver Huang Shijie
2013-08-19 4:10 ` Huang Shijie
2013-08-22 19:21 ` Brian Norris
2013-08-22 19:21 ` Brian Norris
2013-08-23 2:14 ` Huang Shijie
2013-08-23 2:14 ` Huang Shijie
2013-08-23 6:59 ` Huang Shijie
2013-08-23 6:59 ` Huang Shijie
2013-08-23 16:44 ` Mark Brown
2013-08-23 16:44 ` Mark Brown
2013-08-24 7:11 ` Brian Norris
2013-08-24 7:11 ` Brian Norris
2013-08-24 13:42 ` Huang Shijie
2013-08-24 13:42 ` Huang Shijie
2013-08-19 4:10 ` [PATCH V1 5/5] ARM: dts: vf610-twr: Add SPI NOR support Huang Shijie
2013-08-19 4:10 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52174640.701@gmail.com \
--to=computersforpeace@gmail.com \
--cc=b18965@freescale.com \
--cc=b32955@freescale.com \
--cc=b44548@freescale.com \
--cc=broonie@kernel.org \
--cc=dedekind1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
--cc=shawn.guo@linaro.org \
--cc=wangyuhang2014@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.