All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Gerlach <d-gerlach@ti.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, bcousson@baylibre.com
Subject: Re: [PATCH 1/2] ARM: AM335x: Get rid of unused sram init function
Date: Tue, 27 Aug 2013 11:06:35 -0500	[thread overview]
Message-ID: <521CCE8B.4050907@ti.com> (raw)
In-Reply-To: <1377598305-15539-2-git-send-email-rnayak@ti.com>

On 08/27/2013 05:11 AM, Rajendra Nayak wrote:
> Remove the empty am33xx_sram_init() function.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> ---
>   arch/arm/mach-omap2/sram.c |    7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/sram.c b/arch/arm/mach-omap2/sram.c
> index 4bd0968..305fc2b 100644
> --- a/arch/arm/mach-omap2/sram.c
> +++ b/arch/arm/mach-omap2/sram.c
> @@ -285,11 +285,6 @@ static inline int omap34xx_sram_init(void)
>   }
>   #endif /* CONFIG_ARCH_OMAP3 */
>
> -static inline int am33xx_sram_init(void)
> -{
> -	return 0;
> -}
> -
>   int __init omap_sram_init(void)
>   {
>   	omap_detect_sram();
> @@ -299,8 +294,6 @@ int __init omap_sram_init(void)
>   		omap242x_sram_init();
>   	else if (cpu_is_omap2430())
>   		omap243x_sram_init();
> -	else if (soc_is_am33xx())
> -		am33xx_sram_init();
>   	else if (cpu_is_omap34xx())
>   		omap34xx_sram_init();
>
>

Suspend resume for AM33xx as of right now uses this function. This patch 
[1] uses this function to push the low-level suspend code to sram, it 
was added here to be consistent with other platforms that utilize the 
same type of functionality (omap34xx).

Regards,
Dave

[1] http://marc.info/?l=linux-omap&m=137581164813160&w=2

WARNING: multiple messages have this Message-ID (diff)
From: d-gerlach@ti.com (Dave Gerlach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: AM335x: Get rid of unused sram init function
Date: Tue, 27 Aug 2013 11:06:35 -0500	[thread overview]
Message-ID: <521CCE8B.4050907@ti.com> (raw)
In-Reply-To: <1377598305-15539-2-git-send-email-rnayak@ti.com>

On 08/27/2013 05:11 AM, Rajendra Nayak wrote:
> Remove the empty am33xx_sram_init() function.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> ---
>   arch/arm/mach-omap2/sram.c |    7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/sram.c b/arch/arm/mach-omap2/sram.c
> index 4bd0968..305fc2b 100644
> --- a/arch/arm/mach-omap2/sram.c
> +++ b/arch/arm/mach-omap2/sram.c
> @@ -285,11 +285,6 @@ static inline int omap34xx_sram_init(void)
>   }
>   #endif /* CONFIG_ARCH_OMAP3 */
>
> -static inline int am33xx_sram_init(void)
> -{
> -	return 0;
> -}
> -
>   int __init omap_sram_init(void)
>   {
>   	omap_detect_sram();
> @@ -299,8 +294,6 @@ int __init omap_sram_init(void)
>   		omap242x_sram_init();
>   	else if (cpu_is_omap2430())
>   		omap243x_sram_init();
> -	else if (soc_is_am33xx())
> -		am33xx_sram_init();
>   	else if (cpu_is_omap34xx())
>   		omap34xx_sram_init();
>
>

Suspend resume for AM33xx as of right now uses this function. This patch 
[1] uses this function to push the low-level suspend code to sram, it 
was added here to be consistent with other platforms that utilize the 
same type of functionality (omap34xx).

Regards,
Dave

[1] http://marc.info/?l=linux-omap&m=137581164813160&w=2

  reply	other threads:[~2013-08-27 16:06 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 10:11 [PATCH 0/2] OMAP4+: Get rid of internal SRAM handling Rajendra Nayak
2013-08-27 10:11 ` Rajendra Nayak
2013-08-27 10:11 ` [PATCH 1/2] ARM: AM335x: Get rid of unused sram init function Rajendra Nayak
2013-08-27 10:11   ` Rajendra Nayak
2013-08-27 16:06   ` Dave Gerlach [this message]
2013-08-27 16:06     ` Dave Gerlach
2013-08-28  6:17     ` Rajendra Nayak
2013-08-28  6:17       ` Rajendra Nayak
2013-08-27 10:11 ` [PATCH 2/2] ARM: OMAP4+: Move SRAM data to DT Rajendra Nayak
2013-08-27 10:11   ` Rajendra Nayak
2013-08-27 11:23   ` Sekhar Nori
2013-08-27 11:23     ` Sekhar Nori
2013-08-28  6:23     ` Rajendra Nayak
2013-08-28  6:23       ` Rajendra Nayak
2013-08-28 10:24       ` Sekhar Nori
2013-08-28 10:24         ` Sekhar Nori
2013-08-29 11:02         ` Rajendra Nayak
2013-08-29 11:02           ` Rajendra Nayak
2013-09-03 13:56   ` Russ Dill
2013-09-03 13:56     ` Russ Dill
2013-09-03 14:35     ` Lucas Stach
2013-09-03 14:35       ` Lucas Stach
2013-09-03 15:07       ` Russ Dill
2013-09-03 15:07         ` Russ Dill
2013-08-27 13:25 ` [PATCH 0/2] OMAP4+: Get rid of internal SRAM handling Santosh Shilimkar
2013-08-27 13:25   ` Santosh Shilimkar
2013-08-28  6:29   ` Rajendra Nayak
2013-08-28  6:29     ` Rajendra Nayak
2013-08-28 13:38     ` Santosh Shilimkar
2013-08-28 13:38       ` Santosh Shilimkar
2013-08-28 13:42       ` Rajendra Nayak
2013-08-28 13:42         ` Rajendra Nayak
2013-08-28 14:46         ` Santosh Shilimkar
2013-08-28 14:46           ` Santosh Shilimkar
2013-10-08 18:34 ` Tony Lindgren
2013-10-08 18:34   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521CCE8B.4050907@ti.com \
    --to=d-gerlach@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rnayak@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.