* [PATCH] h8300/kernel/timer/timer8.c: add the missing semicolon
@ 2013-08-29 3:51 Chen Gang
2013-08-29 4:44 ` Chen Gang
2013-08-29 4:47 ` [PATCH v2] " Chen Gang
0 siblings, 2 replies; 4+ messages in thread
From: Chen Gang @ 2013-08-29 3:51 UTC (permalink / raw)
To: Yoshinori Sato, Geert Uytterhoeven, ak
Cc: Andrew Morton, linux-kernel@vger.kernel.org
Add the missing semicolon to fix the typo issue.
The related error: (defconfig for H8S):
arch/h8300/kernel/timer/timer8.c: In function 'h8300_timer_setup':
arch/h8300/kernel/timer/timer8.c:98:2: error: expected ';' before 'ctrl_outw'
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/h8300/Makefile | 2 +-
arch/h8300/kernel/timer/timer8.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/h8300/Makefile b/arch/h8300/Makefile
index a556447..d2ba710 100644
--- a/arch/h8300/Makefile
+++ b/arch/h8300/Makefile
@@ -25,7 +25,7 @@ model-$(CONFIG_RAMKERNEL) := ram
model-$(CONFIG_ROMKERNEL) := rom
MODEL := $(model-y)
-cflags-$(CONFIG_CPU_H8300H) := -mh
+cflags-$(CONFIG_CPU_H8300H) := -mh -mcpu=h8300h
ldflags-$(CONFIG_CPU_H8300H) := -mh8300helf
cflags-$(CONFIG_CPU_H8S) := -ms
ldflags-$(CONFIG_CPU_H8S) := -mh8300self
diff --git a/arch/h8300/kernel/timer/timer8.c b/arch/h8300/kernel/timer/timer8.c
index 505f341..8aac2a7 100644
--- a/arch/h8300/kernel/timer/timer8.c
+++ b/arch/h8300/kernel/timer/timer8.c
@@ -91,7 +91,7 @@ void __init h8300_timer_setup(void)
#if defined(CONFIG_CPU_H8S)
/* Timer module enable */
- ctrl_bclr(0, MSTPCRL)
+ ctrl_bclr(0, MSTPCRL);
#endif
/* initialize timer */
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] h8300/kernel/timer/timer8.c: add the missing semicolon
2013-08-29 3:51 [PATCH] h8300/kernel/timer/timer8.c: add the missing semicolon Chen Gang
@ 2013-08-29 4:44 ` Chen Gang
2013-08-29 4:47 ` [PATCH v2] " Chen Gang
1 sibling, 0 replies; 4+ messages in thread
From: Chen Gang @ 2013-08-29 4:44 UTC (permalink / raw)
To: Yoshinori Sato, Geert Uytterhoeven, ak
Cc: Andrew Morton, linux-kernel@vger.kernel.org
On 08/29/2013 11:51 AM, Chen Gang wrote:
> Add the missing semicolon to fix the typo issue.
>
> The related error: (defconfig for H8S):
>
> arch/h8300/kernel/timer/timer8.c: In function 'h8300_timer_setup':
> arch/h8300/kernel/timer/timer8.c:98:2: error: expected ';' before 'ctrl_outw'
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/h8300/Makefile | 2 +-
> arch/h8300/kernel/timer/timer8.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/h8300/Makefile b/arch/h8300/Makefile
> index a556447..d2ba710 100644
> --- a/arch/h8300/Makefile
> +++ b/arch/h8300/Makefile
> @@ -25,7 +25,7 @@ model-$(CONFIG_RAMKERNEL) := ram
> model-$(CONFIG_ROMKERNEL) := rom
> MODEL := $(model-y)
>
> -cflags-$(CONFIG_CPU_H8300H) := -mh
> +cflags-$(CONFIG_CPU_H8300H) := -mh -mcpu=h8300h
Oh, sorry, it contents some waste things, I should send patch v2.
> ldflags-$(CONFIG_CPU_H8300H) := -mh8300helf
> cflags-$(CONFIG_CPU_H8S) := -ms
> ldflags-$(CONFIG_CPU_H8S) := -mh8300self
> diff --git a/arch/h8300/kernel/timer/timer8.c b/arch/h8300/kernel/timer/timer8.c
> index 505f341..8aac2a7 100644
> --- a/arch/h8300/kernel/timer/timer8.c
> +++ b/arch/h8300/kernel/timer/timer8.c
> @@ -91,7 +91,7 @@ void __init h8300_timer_setup(void)
>
> #if defined(CONFIG_CPU_H8S)
> /* Timer module enable */
> - ctrl_bclr(0, MSTPCRL)
> + ctrl_bclr(0, MSTPCRL);
> #endif
>
> /* initialize timer */
>
--
Chen Gang
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] h8300/kernel/timer/timer8.c: add the missing semicolon
2013-08-29 3:51 [PATCH] h8300/kernel/timer/timer8.c: add the missing semicolon Chen Gang
2013-08-29 4:44 ` Chen Gang
@ 2013-08-29 4:47 ` Chen Gang
2013-08-29 9:42 ` [PATCH] drivers: ide: Kconfig: let IDE_H8300 depends on H8300H_AKI3068NET or H8300H_H8MAX Chen Gang
1 sibling, 1 reply; 4+ messages in thread
From: Chen Gang @ 2013-08-29 4:47 UTC (permalink / raw)
To: Yoshinori Sato, Geert Uytterhoeven, ak
Cc: Andrew Morton, linux-kernel@vger.kernel.org
Add the missing semicolon to fix the typo issue.
The related error: (defconfig for H8S):
arch/h8300/kernel/timer/timer8.c: In function 'h8300_timer_setup':
arch/h8300/kernel/timer/timer8.c:98:2: error: expected ';' before 'ctrl_outw'
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/h8300/kernel/timer/timer8.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/h8300/kernel/timer/timer8.c b/arch/h8300/kernel/timer/timer8.c
index 505f341..8aac2a7 100644
--- a/arch/h8300/kernel/timer/timer8.c
+++ b/arch/h8300/kernel/timer/timer8.c
@@ -91,7 +91,7 @@ void __init h8300_timer_setup(void)
#if defined(CONFIG_CPU_H8S)
/* Timer module enable */
- ctrl_bclr(0, MSTPCRL)
+ ctrl_bclr(0, MSTPCRL);
#endif
/* initialize timer */
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drivers: ide: Kconfig: let IDE_H8300 depends on H8300H_AKI3068NET or H8300H_H8MAX
2013-08-29 4:47 ` [PATCH v2] " Chen Gang
@ 2013-08-29 9:42 ` Chen Gang
0 siblings, 0 replies; 4+ messages in thread
From: Chen Gang @ 2013-08-29 9:42 UTC (permalink / raw)
To: Yoshinori Sato, Geert Uytterhoeven, David Miller
Cc: linux-kernel@vger.kernel.org, linux-ide
According to the code in "arch/h8300/Kbuild.ide", IDE_H8300 need depend
on "H8300H_AKI3068NET || H8300H_H8MAX", or can not pass compiling with
allmodconfig for h8300.
The related error:
drivers/ide/ide-h8300.c: In function 'hw_setup':
drivers/ide/ide-h8300.c:73:27: error: 'CONFIG_H8300_IDE_BASE' undeclared (first use in this function)
drivers/ide/ide-h8300.c:73:27: note: each undeclared identifier is reported only once for each function it appears in
drivers/ide/ide-h8300.c:74:26: error: 'CONFIG_H8300_IDE_ALT' undeclared (first use in this function)
drivers/ide/ide-h8300.c:75:23: error: 'CONFIG_H8300_IDE_IRQ' undeclared (first use in this function)
drivers/ide/ide-h8300.c: In function 'h8300_ide_init':
drivers/ide/ide-h8300.c:90:7: error: 'CONFIG_H8300_IDE_BASE' undeclared (first use in this function)
drivers/ide/ide-h8300.c:92:7: error: 'CONFIG_H8300_IDE_ALT' undeclared (first use in this function)
drivers/ide/ide-h8300.c: At top level:
drivers/ide/ide-h8300.c:109:16: error: expected declaration specifiers or '...' before string constant
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/ide/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index 02906ca..f79b49f 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -724,7 +724,7 @@ config BLK_DEV_IDE_RAPIDE
config IDE_H8300
tristate "H8300 IDE support"
- depends on H8300
+ depends on H8300H_AKI3068NET || H8300H_H8MAX
default y
help
Enables the H8300 IDE driver.
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-29 9:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-29 3:51 [PATCH] h8300/kernel/timer/timer8.c: add the missing semicolon Chen Gang
2013-08-29 4:44 ` Chen Gang
2013-08-29 4:47 ` [PATCH v2] " Chen Gang
2013-08-29 9:42 ` [PATCH] drivers: ide: Kconfig: let IDE_H8300 depends on H8300H_AKI3068NET or H8300H_H8MAX Chen Gang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.