All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-trivial] [PATCH] slirp/arp_table.c: Avoid shifting into sign bit of signed integers
Date: Sun, 01 Sep 2013 19:09:47 +0400	[thread overview]
Message-ID: <522358BB.7030206@msgid.tls.msk.ru> (raw)
In-Reply-To: <1377275808-9017-1-git-send-email-peter.maydell@linaro.org>

23.08.2013 20:36, Peter Maydell wrote:
> "0xf << 28" shifts right into the sign bit, since 0xf is a signed
> integer. Use the 'U' suffix to force an unsigned shift to avoid
> this undefined behaviour and a clang sanitizer warning.

Thanks, applied to the trivial-patches queue.

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp/arp_table.c: Avoid shifting into sign bit of signed integers
Date: Sun, 01 Sep 2013 19:09:47 +0400	[thread overview]
Message-ID: <522358BB.7030206@msgid.tls.msk.ru> (raw)
In-Reply-To: <1377275808-9017-1-git-send-email-peter.maydell@linaro.org>

23.08.2013 20:36, Peter Maydell wrote:
> "0xf << 28" shifts right into the sign bit, since 0xf is a signed
> integer. Use the 'U' suffix to force an unsigned shift to avoid
> this undefined behaviour and a clang sanitizer warning.

Thanks, applied to the trivial-patches queue.

/mjt

  parent reply	other threads:[~2013-09-01 15:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 16:36 [Qemu-trivial] [PATCH] slirp/arp_table.c: Avoid shifting into sign bit of signed integers Peter Maydell
2013-08-23 16:36 ` [Qemu-devel] " Peter Maydell
2013-08-23 16:42 ` [Qemu-trivial] " Eric Blake
2013-08-23 16:42   ` Eric Blake
2013-08-23 16:55 ` [Qemu-trivial] " Jan Kiszka
2013-08-23 16:55   ` [Qemu-devel] " Jan Kiszka
2013-09-01 15:09 ` Michael Tokarev [this message]
2013-09-01 15:09   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522358BB.7030206@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=jan.kiszka@siemens.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.