[meta-fsl-arm-extra][PATCH 0/8] Split crystalfontz boards

[meta-fsl-arm-extra][PATCH 0/8] Split crystalfontz boards

[Alexandre Belloni]

This patch series splits the machine configuration for all the crystalfontz
boards. This is required as we need to be able to diferrentiate boards to apply
different configuration (eg for the touchscreens)

The first patch ensures the kernel link will always have the name barebox is
looking for so that we don't break previous deployments.

The second one splits the cfa-10036 in an include file, common for all boards
and the actual configuration file.

The lasts patches add each boards.

Alexandre Belloni (8):
  linux-cfa: always use cfa10036 as MACHINE for the kernel link
  cfa10036: split configuration
  Add a machine configuration for cfa-10037
  Add a machine configuration for cfa-10049
  Add a machine configuration for cfa-10055
  Add a machine configuration for cfa-10056
  Add a machine configuration for cfa-10057
  Add a machine configuration for cfa-10058

 conf/machine/cfa10036.conf             | 34 +---------------------------------
 conf/machine/cfa10037.conf             |  9 +++++++++
 conf/machine/cfa10049.conf             | 11 +++++++++++
 conf/machine/cfa10055.conf             | 12 ++++++++++++
 conf/machine/cfa10056.conf             | 12 ++++++++++++
 conf/machine/cfa10057.conf             | 11 +++++++++++
 conf/machine/cfa10058.conf             | 11 +++++++++++
 conf/machine/include/cfa10036.inc      | 30 ++++++++++++++++++++++++++++++
 recipes-kernel/linux/linux-cfa_3.10.bb |  2 +-
 9 files changed, 98 insertions(+), 34 deletions(-)
 create mode 100644 conf/machine/cfa10037.conf
 create mode 100644 conf/machine/cfa10049.conf
 create mode 100644 conf/machine/cfa10055.conf
 create mode 100644 conf/machine/cfa10056.conf
 create mode 100644 conf/machine/cfa10057.conf
 create mode 100644 conf/machine/cfa10058.conf
 create mode 100644 conf/machine/include/cfa10036.inc

-- 
1.8.1.2

[meta-fsl-arm-extra][PATCH 1/8] linux-cfa: always use cfa10036 as MACHINE for the kernel link

[Alexandre Belloni]

Barebox is configured to always look for a kernel image named
zImage-cfa10036.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 recipes-kernel/linux/linux-cfa_3.10.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-kernel/linux/linux-cfa_3.10.bb b/recipes-kernel/linux/linux-cfa_3.10.bb
index 2c2a723..bccca1c 100644
--- a/recipes-kernel/linux/linux-cfa_3.10.bb
+++ b/recipes-kernel/linux/linux-cfa_3.10.bb
@@ -26,7 +26,7 @@ pkg_postinst_kernel-devicetree_append () {
 }
 
 pkg_postinst_kernel-image_append () {
-	update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${MACHINE} ${KERNEL_IMAGETYPE}-${MACHINE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
+	update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-cfa10036 ${KERNEL_IMAGETYPE}-cfa10036 ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
 }
 
 COMPATIBLE_MACHINE = "cfa10036"
-- 
1.8.1.2

[meta-fsl-arm-extra][PATCH 2/8] cfa10036: split configuration

[Alexandre Belloni]

Introduce an include file to be able to support multiple boards using
the cfa10036 by reusing the imx-bootlets, barebox and kernel
configurations.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 conf/machine/cfa10036.conf        | 34 +---------------------------------
 conf/machine/include/cfa10036.inc | 30 ++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 33 deletions(-)
 create mode 100644 conf/machine/include/cfa10036.inc

diff --git a/conf/machine/cfa10036.conf b/conf/machine/cfa10036.conf
index b7cdd8d..242d352 100644
--- a/conf/machine/cfa10036.conf
+++ b/conf/machine/cfa10036.conf
@@ -3,36 +3,4 @@
 #@SOC: i.MX28
 #@DESCRIPTION: Machine configuration for CFA-10036
 
-include conf/machine/include/mxs-base.inc
-
-SOC_FAMILY = "mxs:mx28"
-
-PREFERRED_PROVIDER_virtual/kernel = "linux-cfa"
-
-IMAGE_BOOTLOADER = "barebox"
-BAREBOX_BINARY = "barebox"
-
-IMXBOOTLETS_MACHINE = "cfa10036"
-
-KERNEL_IMAGETYPE = "zImage"
-KERNEL_DEVICETREE = "imx28-cfa10036.dtb \
-                     imx28-cfa10037.dtb \
-                     imx28-cfa10049.dtb \
-                     imx28-cfa10055.dtb \
-                     imx28-cfa10056.dtb \
-                     imx28-cfa10057.dtb \
-                     imx28-cfa10058.dtb \
-"
-
-# we need the kernel to be installed in the final image
-IMAGE_INSTALL_append = " kernel-image kernel-devicetree"
-
-SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "tar.bz2 ext3 barebox.mxsboot-sdcard sdcard"
-
-SERIAL_CONSOLE = "115200 ttyAMA0"
-
-MACHINE_FEATURES = "apm usbgadget usbhost vfat"
-
-# Gstreamer plugin
-MACHINE_GSTREAMER_PLUGIN ?= "gst-fsl-plugin"
+include conf/machine/include/cfa10036.inc
diff --git a/conf/machine/include/cfa10036.inc b/conf/machine/include/cfa10036.inc
new file mode 100644
index 0000000..0adea54
--- /dev/null
+++ b/conf/machine/include/cfa10036.inc
@@ -0,0 +1,30 @@
+# Common definitions for cfa-10036 boards
+
+include conf/machine/include/mxs-base.inc
+
+SOC_FAMILY = "mxs:mx28"
+
+MACHINEOVERRIDES =. "cfa10036:"
+
+PREFERRED_PROVIDER_virtual/kernel = "linux-cfa"
+
+IMAGE_BOOTLOADER = "barebox"
+BAREBOX_BINARY = "barebox"
+
+IMXBOOTLETS_MACHINE = "cfa10036"
+
+KERNEL_IMAGETYPE = "zImage"
+KERNEL_DEVICETREE = "imx28-cfa10036.dtb"
+
+# we need the kernel to be installed in the final image
+IMAGE_INSTALL_append = " kernel-image kernel-devicetree"
+
+SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
+IMAGE_FSTYPES ?= "tar.bz2 ext3 barebox.mxsboot-sdcard sdcard"
+
+SERIAL_CONSOLE = "115200 ttyAMA0"
+
+MACHINE_FEATURES = "apm usbgadget usbhost vfat"
+
+# Gstreamer plugin
+MACHINE_GSTREAMER_PLUGIN ?= "gst-fsl-plugin"
-- 
1.8.1.2

[meta-fsl-arm-extra][PATCH 3/8] Add a machine configuration for cfa-10037

[Alexandre Belloni]

The cfa-10037 is a breakout board for the cfa-10036.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 conf/machine/cfa10037.conf | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 conf/machine/cfa10037.conf

diff --git a/conf/machine/cfa10037.conf b/conf/machine/cfa10037.conf
new file mode 100644
index 0000000..7dbdd55
--- /dev/null
+++ b/conf/machine/cfa10037.conf
@@ -0,0 +1,9 @@
+#@TYPE: Machine
+#@NAME: Crystalfontz CFA-10037
+#@SOC: i.MX28
+#@DESCRIPTION: Machine configuration for CFA-10037
+
+include conf/machine/include/cfa10036.inc
+
+KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
+
-- 
1.8.1.2

[meta-fsl-arm-extra][PATCH 4/8] Add a machine configuration for cfa-10049

[Alexandre Belloni]

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 conf/machine/cfa10049.conf | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 conf/machine/cfa10049.conf

diff --git a/conf/machine/cfa10049.conf b/conf/machine/cfa10049.conf
new file mode 100644
index 0000000..3492f36
--- /dev/null
+++ b/conf/machine/cfa10049.conf
@@ -0,0 +1,11 @@
+#@TYPE: Machine
+#@NAME: Crystalfontz CFA-10049
+#@SOC: i.MX28
+#@DESCRIPTION: Machine configuration for CFA-10049
+
+include conf/machine/include/cfa10036.inc
+
+KERNEL_DEVICETREE += "imx28-cfa10049.dtb"
+
+MACHINE_FEATURES += "touchscreen"
+
-- 
1.8.1.2

[meta-fsl-arm-extra][PATCH 5/8] Add a machine configuration for cfa-10055

[Alexandre Belloni]

The cfa-10055 is a cfa-10037 with a 3.5" touchscreen attached.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 conf/machine/cfa10055.conf | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 conf/machine/cfa10055.conf

diff --git a/conf/machine/cfa10055.conf b/conf/machine/cfa10055.conf
new file mode 100644
index 0000000..a5a6246
--- /dev/null
+++ b/conf/machine/cfa10055.conf
@@ -0,0 +1,12 @@
+#@TYPE: Machine
+#@NAME: Crystalfontz CFA-10055
+#@SOC: i.MX28
+#@DESCRIPTION: Machine configuration for CFA-10055
+
+include conf/machine/include/cfa10036.inc
+
+KERNEL_DEVICETREE += "imx28-cfa10037.dtb \
+                      imx28-cfa10055.dtb"
+
+MACHINE_FEATURES += "touchscreen"
+
-- 
1.8.1.2

[meta-fsl-arm-extra][PATCH 6/8] Add a machine configuration for cfa-10056

[Alexandre Belloni]

The cfa-10056 is a cfa-10037 with a 4" LCD screen.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 conf/machine/cfa10056.conf | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 conf/machine/cfa10056.conf

diff --git a/conf/machine/cfa10056.conf b/conf/machine/cfa10056.conf
new file mode 100644
index 0000000..8e12a0a
--- /dev/null
+++ b/conf/machine/cfa10056.conf
@@ -0,0 +1,12 @@
+#@TYPE: Machine
+#@NAME: Crystalfontz CFA-10056
+#@SOC: i.MX28
+#@DESCRIPTION: Machine configuration for CFA-10056
+
+include conf/machine/include/cfa10036.inc
+
+KERNEL_DEVICETREE += "imx28-cfa10037.dtb \
+                      imx28-cfa10056.dtb"
+
+MACHINE_FEATURES += "screen"
+
-- 
1.8.1.2

[meta-fsl-arm-extra][PATCH 7/8] Add a machine configuration for cfa-10057

[Alexandre Belloni]

cfa-10057, also called cfa-920 is a cfa-10036 plus ethernet, usb, mems
and a 3.5" touchscreen.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 conf/machine/cfa10057.conf | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 conf/machine/cfa10057.conf

diff --git a/conf/machine/cfa10057.conf b/conf/machine/cfa10057.conf
new file mode 100644
index 0000000..1e96692
--- /dev/null
+++ b/conf/machine/cfa10057.conf
@@ -0,0 +1,11 @@
+#@TYPE: Machine
+#@NAME: Crystalfontz CFA-10057
+#@SOC: i.MX28
+#@DESCRIPTION: Machine configuration for CFA-10057, also called CFA-920
+
+include conf/machine/include/cfa10036.inc
+
+KERNEL_DEVICETREE += "imx28-cfa10057.dtb"
+
+MACHINE_FEATURES += "touchscreen"
+
-- 
1.8.1.2

[meta-fsl-arm-extra][PATCH 8/8] Add a machine configuration for cfa-10058

[Alexandre Belloni]

cfa-10058, also called cfa-921 is a cfa-10036 plus ethernet, usb, mems
and a 4" touchscreen.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 conf/machine/cfa10058.conf | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 conf/machine/cfa10058.conf

diff --git a/conf/machine/cfa10058.conf b/conf/machine/cfa10058.conf
new file mode 100644
index 0000000..4158051
--- /dev/null
+++ b/conf/machine/cfa10058.conf
@@ -0,0 +1,11 @@
+#@TYPE: Machine
+#@NAME: Crystalfontz CFA-10058
+#@SOC: i.MX28
+#@DESCRIPTION: Machine configuration for CFA-10058, also called CFA-921
+
+include conf/machine/include/cfa10036.inc
+
+KERNEL_DEVICETREE += "imx28-cfa10058.dtb"
+
+MACHINE_FEATURES += "touchscreen"
+
-- 
1.8.1.2

Re: [meta-fsl-arm-extra][PATCH 1/8] linux-cfa: always use cfa10036 as MACHINE for the kernel link

[Daiane Angolini]

On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
> Barebox is configured to always look for a kernel image named
> zImage-cfa10036.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>   recipes-kernel/linux/linux-cfa_3.10.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-kernel/linux/linux-cfa_3.10.bb b/recipes-kernel/linux/linux-cfa_3.10.bb
> index 2c2a723..bccca1c 100644
> --- a/recipes-kernel/linux/linux-cfa_3.10.bb
> +++ b/recipes-kernel/linux/linux-cfa_3.10.bb
> @@ -26,7 +26,7 @@ pkg_postinst_kernel-devicetree_append () {
>   }
>
>   pkg_postinst_kernel-image_append () {
> -	update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${MACHINE} ${KERNEL_IMAGETYPE}-${MACHINE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> +	update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-cfa10036 ${KERNEL_IMAGETYPE}-cfa10036 ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true

why do you need to explicitly use cfa10036 if your bbappend is 
COMPATIBLE_MACHINE on "cfa10036"?

will you use zImage-cfa10036 for other boards with a different name? And 
when you include a that new machine will increase the COMPATIBLE_MACHINE 
string?

>   }
>
>   COMPATIBLE_MACHINE = "cfa10036"
>


-- 
Daiane

Re: [meta-fsl-arm-extra][PATCH 2/8] cfa10036: split configuration

[Daiane Angolini]

On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
> Introduce an include file to be able to support multiple boards using
> the cfa10036 by reusing the imx-bootlets, barebox and kernel
> configurations.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>   conf/machine/cfa10036.conf        | 34 +---------------------------------
>   conf/machine/include/cfa10036.inc | 30 ++++++++++++++++++++++++++++++
>   2 files changed, 31 insertions(+), 33 deletions(-)
>   create mode 100644 conf/machine/include/cfa10036.inc
>
> diff --git a/conf/machine/cfa10036.conf b/conf/machine/cfa10036.conf
> index b7cdd8d..242d352 100644
> --- a/conf/machine/cfa10036.conf
> +++ b/conf/machine/cfa10036.conf
> @@ -3,36 +3,4 @@
>   #@SOC: i.MX28
>   #@DESCRIPTION: Machine configuration for CFA-10036
>
> -include conf/machine/include/mxs-base.inc
> -
> -SOC_FAMILY = "mxs:mx28"
> -
> -PREFERRED_PROVIDER_virtual/kernel = "linux-cfa"
> -
> -IMAGE_BOOTLOADER = "barebox"
> -BAREBOX_BINARY = "barebox"
> -
> -IMXBOOTLETS_MACHINE = "cfa10036"
> -
> -KERNEL_IMAGETYPE = "zImage"
> -KERNEL_DEVICETREE = "imx28-cfa10036.dtb \
> -                     imx28-cfa10037.dtb \
> -                     imx28-cfa10049.dtb \
> -                     imx28-cfa10055.dtb \
> -                     imx28-cfa10056.dtb \
> -                     imx28-cfa10057.dtb \
> -                     imx28-cfa10058.dtb \
> -"
> -
> -# we need the kernel to be installed in the final image
> -IMAGE_INSTALL_append = " kernel-image kernel-devicetree"
> -
> -SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> -IMAGE_FSTYPES ?= "tar.bz2 ext3 barebox.mxsboot-sdcard sdcard"
> -
> -SERIAL_CONSOLE = "115200 ttyAMA0"
> -
> -MACHINE_FEATURES = "apm usbgadget usbhost vfat"
> -
> -# Gstreamer plugin
> -MACHINE_GSTREAMER_PLUGIN ?= "gst-fsl-plugin"
> +include conf/machine/include/cfa10036.inc
> diff --git a/conf/machine/include/cfa10036.inc b/conf/machine/include/cfa10036.inc
> new file mode 100644
> index 0000000..0adea54
> --- /dev/null
> +++ b/conf/machine/include/cfa10036.inc
> @@ -0,0 +1,30 @@
> +# Common definitions for cfa-10036 boards
> +
> +include conf/machine/include/mxs-base.inc
> +
> +SOC_FAMILY = "mxs:mx28"
> +
> +MACHINEOVERRIDES =. "cfa10036:"
> +
> +PREFERRED_PROVIDER_virtual/kernel = "linux-cfa"
> +
> +IMAGE_BOOTLOADER = "barebox"
> +BAREBOX_BINARY = "barebox"
> +
> +IMXBOOTLETS_MACHINE = "cfa10036"
> +
> +KERNEL_IMAGETYPE = "zImage"
> +KERNEL_DEVICETREE = "imx28-cfa10036.dtb"

Would KERNEL_DEVICETREE be part of the machine conf file?

> +
> +# we need the kernel to be installed in the final image
> +IMAGE_INSTALL_append = " kernel-image kernel-devicetree"
> +
> +SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> +IMAGE_FSTYPES ?= "tar.bz2 ext3 barebox.mxsboot-sdcard sdcard"
> +
> +SERIAL_CONSOLE = "115200 ttyAMA0"
> +
> +MACHINE_FEATURES = "apm usbgadget usbhost vfat"
> +
> +# Gstreamer plugin
> +MACHINE_GSTREAMER_PLUGIN ?= "gst-fsl-plugin"
>


-- 
Daiane

Re: [meta-fsl-arm-extra][PATCH 3/8] Add a machine configuration for cfa-10037

[Daiane Angolini]

On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
> The cfa-10037 is a breakout board for the cfa-10036.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>   conf/machine/cfa10037.conf | 9 +++++++++
>   1 file changed, 9 insertions(+)
>   create mode 100644 conf/machine/cfa10037.conf
>
> diff --git a/conf/machine/cfa10037.conf b/conf/machine/cfa10037.conf
> new file mode 100644
> index 0000000..7dbdd55
> --- /dev/null
> +++ b/conf/machine/cfa10037.conf
> @@ -0,0 +1,9 @@
> +#@TYPE: Machine
> +#@NAME: Crystalfontz CFA-10037
> +#@SOC: i.MX28
> +#@DESCRIPTION: Machine configuration for CFA-10037
> +
> +include conf/machine/include/cfa10036.inc
> +
> +KERNEL_DEVICETREE += "imx28-cfa10037.dtb"

oh, you need both devicetree files....


> +
>


-- 
Daiane

Re: [meta-fsl-arm-extra][PATCH 3/8] Add a machine configuration for cfa-10037

[Otavio Salvador]

On Fri, Sep 6, 2013 at 8:59 AM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
>>
>> The cfa-10037 is a breakout board for the cfa-10036.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> ---
>>   conf/machine/cfa10037.conf | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>   create mode 100644 conf/machine/cfa10037.conf
>>
>> diff --git a/conf/machine/cfa10037.conf b/conf/machine/cfa10037.conf
>> new file mode 100644
>> index 0000000..7dbdd55
>> --- /dev/null
>> +++ b/conf/machine/cfa10037.conf
>> @@ -0,0 +1,9 @@
>> +#@TYPE: Machine
>> +#@NAME: Crystalfontz CFA-10037
>> +#@SOC: i.MX28
>> +#@DESCRIPTION: Machine configuration for CFA-10037
>> +
>> +include conf/machine/include/cfa10036.inc
>> +
>> +KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
>
> oh, you need both devicetree files....

Really? I think it is not loading both. Alexandre, can you comment on this?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm-extra][PATCH 1/8] linux-cfa: always use cfa10036 as MACHINE for the kernel link

[Alexandre Belloni]

On 06/09/2013 13:55, Daiane Angolini wrote:
> On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
>> Barebox is configured to always look for a kernel image named
>> zImage-cfa10036.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> ---
>>   recipes-kernel/linux/linux-cfa_3.10.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-kernel/linux/linux-cfa_3.10.bb
>> b/recipes-kernel/linux/linux-cfa_3.10.bb
>> index 2c2a723..bccca1c 100644
>> --- a/recipes-kernel/linux/linux-cfa_3.10.bb
>> +++ b/recipes-kernel/linux/linux-cfa_3.10.bb
>> @@ -26,7 +26,7 @@ pkg_postinst_kernel-devicetree_append () {
>>   }
>>
>>   pkg_postinst_kernel-image_append () {
>> -    update-alternatives --install
>> /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${MACHINE}
>> ${KERNEL_IMAGETYPE}-${MACHINE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION}
>> ${KERNEL_PRIORITY} || true
>> +    update-alternatives --install
>> /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-cfa10036
>> ${KERNEL_IMAGETYPE}-cfa10036 ${KERNEL_IMAGETYPE}-${KERNEL_VERSION}
>> ${KERNEL_PRIORITY} || true
>
> why do you need to explicitly use cfa10036 if your bbappend is
> COMPATIBLE_MACHINE on "cfa10036"?
>
> will you use zImage-cfa10036 for other boards with a different name?
> And when you include a that new machine will increase the
> COMPATIBLE_MACHINE string?

Actually, barebox is looking for a kernel named zImage-cfa10036 for all
the cfa-10036 based boards (that means all the crystalfontz boards for
now). Then, it is reading an eeprom to know what exactly is the board
and will load the DT accordingly. I don't have to change
COMPATIBLE_MACHINE because I'm adding cfa10036 to the MACHINEOVERRIDES
for those cfa-10036 based boards.

>
>>   }
>>
>>   COMPATIBLE_MACHINE = "cfa10036"
>>
>
>


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [meta-fsl-arm-extra][PATCH 3/8] Add a machine configuration for cfa-10037

[Alexandre Belloni]

On 06/09/2013 14:10, Otavio Salvador wrote:
> On Fri, Sep 6, 2013 at 8:59 AM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
>>> The cfa-10037 is a breakout board for the cfa-10036.
>>>
>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>> ---
>>>   conf/machine/cfa10037.conf | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>   create mode 100644 conf/machine/cfa10037.conf
>>>
>>> diff --git a/conf/machine/cfa10037.conf b/conf/machine/cfa10037.conf
>>> new file mode 100644
>>> index 0000000..7dbdd55
>>> --- /dev/null
>>> +++ b/conf/machine/cfa10037.conf
>>> @@ -0,0 +1,9 @@
>>> +#@TYPE: Machine
>>> +#@NAME: Crystalfontz CFA-10037
>>> +#@SOC: i.MX28
>>> +#@DESCRIPTION: Machine configuration for CFA-10037
>>> +
>>> +include conf/machine/include/cfa10036.inc
>>> +
>>> +KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
>> oh, you need both devicetree files....
> Really? I think it is not loading both. Alexandre, can you comment on this?
>
Sure, you are right, it is only loading one. But in the case the eeprom
is not yet written, you may end up with barebox trying to use the
cfa-10036 DT. Hence, I'm letting that DT so that you can still boot. You
may also detach the cfa-10036 from the peripheral board and so end up
booting only on the cfa-10036.

I did the same for cfa-10055 and cfa-10056 which are actually cfa-10037
with an attached touchscreen. If you ever want to remove it, you
probably want to still be able to boot it.

Actually, I was wondering whether it wouldn't be better to simply always
include all the DTs.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [meta-fsl-arm-extra][PATCH 3/8] Add a machine configuration for cfa-10037

[Otavio Salvador]

On Fri, Sep 6, 2013 at 1:34 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 06/09/2013 14:10, Otavio Salvador wrote:
>> On Fri, Sep 6, 2013 at 8:59 AM, Daiane Angolini
>> <daiane.angolini@freescale.com> wrote:
>>> On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
>>>> The cfa-10037 is a breakout board for the cfa-10036.
>>>>
>>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>>> ---
>>>>   conf/machine/cfa10037.conf | 9 +++++++++
>>>>   1 file changed, 9 insertions(+)
>>>>   create mode 100644 conf/machine/cfa10037.conf
>>>>
>>>> diff --git a/conf/machine/cfa10037.conf b/conf/machine/cfa10037.conf
>>>> new file mode 100644
>>>> index 0000000..7dbdd55
>>>> --- /dev/null
>>>> +++ b/conf/machine/cfa10037.conf
>>>> @@ -0,0 +1,9 @@
>>>> +#@TYPE: Machine
>>>> +#@NAME: Crystalfontz CFA-10037
>>>> +#@SOC: i.MX28
>>>> +#@DESCRIPTION: Machine configuration for CFA-10037
>>>> +
>>>> +include conf/machine/include/cfa10036.inc
>>>> +
>>>> +KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
>>> oh, you need both devicetree files....
>> Really? I think it is not loading both. Alexandre, can you comment on this?
>>
> Sure, you are right, it is only loading one. But in the case the eeprom
> is not yet written, you may end up with barebox trying to use the
> cfa-10036 DT. Hence, I'm letting that DT so that you can still boot. You
> may also detach the cfa-10036 from the peripheral board and so end up
> booting only on the cfa-10036.
>
> I did the same for cfa-10055 and cfa-10056 which are actually cfa-10037
> with an attached touchscreen. If you ever want to remove it, you
> probably want to still be able to boot it.
>
> Actually, I was wondering whether it wouldn't be better to simply always
> include all the DTs.

Personally I disagree with this approach. We are not working with PC
so people are expected to know what they're doing and choose the right
board.

I will let you to decide on this as I am clueless about the boards and
you're the maintainer of these. So in the end it is your call.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm-extra][PATCH 3/8] Add a machine configuration for cfa-10037

[Alexandre Belloni]

On 06/09/2013 18:40, Otavio Salvador wrote:
> On Fri, Sep 6, 2013 at 1:34 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
>> On 06/09/2013 14:10, Otavio Salvador wrote:
>>> On Fri, Sep 6, 2013 at 8:59 AM, Daiane Angolini
>>> <daiane.angolini@freescale.com> wrote:
>>>> On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
>>>>> The cfa-10037 is a breakout board for the cfa-10036.
>>>>>
>>>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>>>> ---
>>>>>   conf/machine/cfa10037.conf | 9 +++++++++
>>>>>   1 file changed, 9 insertions(+)
>>>>>   create mode 100644 conf/machine/cfa10037.conf
>>>>>
>>>>> diff --git a/conf/machine/cfa10037.conf b/conf/machine/cfa10037.conf
>>>>> new file mode 100644
>>>>> index 0000000..7dbdd55
>>>>> --- /dev/null
>>>>> +++ b/conf/machine/cfa10037.conf
>>>>> @@ -0,0 +1,9 @@
>>>>> +#@TYPE: Machine
>>>>> +#@NAME: Crystalfontz CFA-10037
>>>>> +#@SOC: i.MX28
>>>>> +#@DESCRIPTION: Machine configuration for CFA-10037
>>>>> +
>>>>> +include conf/machine/include/cfa10036.inc
>>>>> +
>>>>> +KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
>>>> oh, you need both devicetree files....
>>> Really? I think it is not loading both. Alexandre, can you comment on this?
>>>
>> Sure, you are right, it is only loading one. But in the case the eeprom
>> is not yet written, you may end up with barebox trying to use the
>> cfa-10036 DT. Hence, I'm letting that DT so that you can still boot. You
>> may also detach the cfa-10036 from the peripheral board and so end up
>> booting only on the cfa-10036.
>>
>> I did the same for cfa-10055 and cfa-10056 which are actually cfa-10037
>> with an attached touchscreen. If you ever want to remove it, you
>> probably want to still be able to boot it.
>>
>> Actually, I was wondering whether it wouldn't be better to simply always
>> include all the DTs.
> Personally I disagree with this approach. We are not working with PC
> so people are expected to know what they're doing and choose the right
> board.
>
> I will let you to decide on this as I am clueless about the boards and
> you're the maintainer of these. So in the end it is your call.
>

I personnally don't mind removing the cfa-10037 from the cfa-10055 and
cfa-10056 but I would prefer keeping the cfa-10036 DT for all the board,
as explained, you may end up with a board with an empty eeprom and still
want to boot (for example, to flash that eeprom ;) ).

Also, I believe those boards may end up being used by unexperienced
people (think raspberry pi ;) ) or by people wanting to use the same SD
card on multiple different boards or event moving the cfa-10036+sdcard
to another peripheral board.

Just to be clear enough, the cfa-10036 is a SoM including the imx28,
RAM, sdcard and usb with a 200 pin SO-DIMM connector. You can then host
that SoM on different peripheral boards. See:
http://www.crystalfontz.com/products/index-linux-SOM.html

I can send a v2 with the extre cfa-10037 dt removed.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [meta-fsl-arm-extra][PATCH 3/8] Add a machine configuration for cfa-10037

[Otavio Salvador]

On Fri, Sep 6, 2013 at 2:11 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 06/09/2013 18:40, Otavio Salvador wrote:
>> On Fri, Sep 6, 2013 at 1:34 PM, Alexandre Belloni
>> <alexandre.belloni@free-electrons.com> wrote:
>>> On 06/09/2013 14:10, Otavio Salvador wrote:
>>>> On Fri, Sep 6, 2013 at 8:59 AM, Daiane Angolini
>>>> <daiane.angolini@freescale.com> wrote:
>>>>> On 09/05/2013 06:21 PM, Alexandre Belloni wrote:
>>>>>> The cfa-10037 is a breakout board for the cfa-10036.
>>>>>>
>>>>>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>>>>> ---
>>>>>>   conf/machine/cfa10037.conf | 9 +++++++++
>>>>>>   1 file changed, 9 insertions(+)
>>>>>>   create mode 100644 conf/machine/cfa10037.conf
>>>>>>
>>>>>> diff --git a/conf/machine/cfa10037.conf b/conf/machine/cfa10037.conf
>>>>>> new file mode 100644
>>>>>> index 0000000..7dbdd55
>>>>>> --- /dev/null
>>>>>> +++ b/conf/machine/cfa10037.conf
>>>>>> @@ -0,0 +1,9 @@
>>>>>> +#@TYPE: Machine
>>>>>> +#@NAME: Crystalfontz CFA-10037
>>>>>> +#@SOC: i.MX28
>>>>>> +#@DESCRIPTION: Machine configuration for CFA-10037
>>>>>> +
>>>>>> +include conf/machine/include/cfa10036.inc
>>>>>> +
>>>>>> +KERNEL_DEVICETREE += "imx28-cfa10037.dtb"
>>>>> oh, you need both devicetree files....
>>>> Really? I think it is not loading both. Alexandre, can you comment on this?
>>>>
>>> Sure, you are right, it is only loading one. But in the case the eeprom
>>> is not yet written, you may end up with barebox trying to use the
>>> cfa-10036 DT. Hence, I'm letting that DT so that you can still boot. You
>>> may also detach the cfa-10036 from the peripheral board and so end up
>>> booting only on the cfa-10036.
>>>
>>> I did the same for cfa-10055 and cfa-10056 which are actually cfa-10037
>>> with an attached touchscreen. If you ever want to remove it, you
>>> probably want to still be able to boot it.
>>>
>>> Actually, I was wondering whether it wouldn't be better to simply always
>>> include all the DTs.
>> Personally I disagree with this approach. We are not working with PC
>> so people are expected to know what they're doing and choose the right
>> board.
>>
>> I will let you to decide on this as I am clueless about the boards and
>> you're the maintainer of these. So in the end it is your call.
>>
>
> I personnally don't mind removing the cfa-10037 from the cfa-10055 and
> cfa-10056 but I would prefer keeping the cfa-10036 DT for all the board,
> as explained, you may end up with a board with an empty eeprom and still
> want to boot (for example, to flash that eeprom ;) ).

I see.

> Also, I believe those boards may end up being used by unexperienced
> people (think raspberry pi ;) ) or by people wanting to use the same SD
> card on multiple different boards or event moving the cfa-10036+sdcard
> to another peripheral board.
>
> Just to be clear enough, the cfa-10036 is a SoM including the imx28,
> RAM, sdcard and usb with a 200 pin SO-DIMM connector. You can then host
> that SoM on different peripheral boards. See:
> http://www.crystalfontz.com/products/index-linux-SOM.html
>
> I can send a v2 with the extre cfa-10037 dt removed.

Please do.

Regards,

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750