From: James Hogan <james.hogan@imgtec.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>,
<blogic@openwrt.org>, <richard@nod.at>
Subject: Re: [PATCH v2] MIPS: do not allow building vmlinuz when !ZBOOT
Date: Wed, 11 Sep 2013 12:11:14 +0100 [thread overview]
Message-ID: <52304FD2.8030602@imgtec.com> (raw)
In-Reply-To: <1378895688-16641-1-git-send-email-f.fainelli@gmail.com>
Hi Florian
On 11/09/13 11:34, Florian Fainelli wrote:
> +vmlinuz: FORCE
> + @echo ' CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'; \
> + /bin/false
Nit: You don't really need the echo and /bin/false as part of the same
command (i.e. the "; \" at end of echo), but no big deal.
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
blogic@openwrt.org, richard@nod.at
Subject: Re: [PATCH v2] MIPS: do not allow building vmlinuz when !ZBOOT
Date: Wed, 11 Sep 2013 12:11:14 +0100 [thread overview]
Message-ID: <52304FD2.8030602@imgtec.com> (raw)
Message-ID: <20130911111114.TL9pswJaByEMIH3fh5v8Rt4LBkzf9KivmsexxcNVdvY@z> (raw)
In-Reply-To: <1378895688-16641-1-git-send-email-f.fainelli@gmail.com>
Hi Florian
On 11/09/13 11:34, Florian Fainelli wrote:
> +vmlinuz: FORCE
> + @echo ' CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'; \
> + /bin/false
Nit: You don't really need the echo and /bin/false as part of the same
command (i.e. the "; \" at end of echo), but no big deal.
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
next prev parent reply other threads:[~2013-09-11 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 10:34 [PATCH v2] MIPS: do not allow building vmlinuz when !ZBOOT Florian Fainelli
2013-09-11 11:11 ` James Hogan [this message]
2013-09-11 11:11 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52304FD2.8030602@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=blogic@openwrt.org \
--cc=f.fainelli@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.