Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle mov/movi in tcg_out_op

[Claudio Fontana <claudio.fontana@huawei.com>]

On 02.09.2013 19:54, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/aarch64/tcg-target.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 
> diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c
> index bde4c72..79a447d 100644
> --- a/tcg/aarch64/tcg-target.c
> +++ b/tcg/aarch64/tcg-target.c
> @@ -1162,18 +1162,6 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
>                       args[0], args[1], args[2]);
>          break;
>  
> -    case INDEX_op_mov_i64:
> -    case INDEX_op_mov_i32:
> -        tcg_out_movr(s, ext, args[0], args[1]);
> -        break;
> -
> -    case INDEX_op_movi_i64:
> -        tcg_out_movi(s, TCG_TYPE_I64, args[0], args[1]);
> -        break;
> -    case INDEX_op_movi_i32:
> -        tcg_out_movi(s, TCG_TYPE_I32, args[0], args[1]);
> -        break;
> -
>      case INDEX_op_add_i64:
>      case INDEX_op_add_i32:
>          tcg_out_arith(s, ARITH_ADD, ext, args[0], args[1], args[2], 0);
> @@ -1337,8 +1325,14 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc,
>          tcg_out_movr(s, 0, args[0], args[1]);
>          break;
>  
> +    case INDEX_op_mov_i64:
> +    case INDEX_op_mov_i32:
> +    case INDEX_op_movi_i64:
> +    case INDEX_op_movi_i32:
> +        /* Always implemented with tcg_out_mov/i, never with tcg_out_op.  */
>      default:
> -        tcg_abort(); /* opcode not implemented */
> +        /* Opcode not implemented.  */
> +        tcg_abort();
>      }
>  }
>  

Ok



-- 
Claudio Fontana
Server OS Architect
Huawei Technologies Duesseldorf GmbH
Riesstraße 25 - 80992 München

office: +49 89 158834 4135
mobile: +49 15253060158