From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
Date: Thu, 12 Sep 2013 11:39:08 -0700 [thread overview]
Message-ID: <52320A4C.6020202@twiddle.net> (raw)
In-Reply-To: <1379009870-18323-1-git-send-email-sw@weilnetz.de>
On 09/12/2013 11:17 AM, Stefan Weil wrote:
> @@ -1093,7 +1093,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
> tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(&tb_ptr));
> #else
> host_addr = (tcg_target_ulong)taddr;
> - assert(taddr == host_addr);
> tmp8 = *(uint8_t *)(host_addr + GUEST_BASE);
> #endif
I noticed first that g2h would be better than fiddling GUEST_BASE
by hand. But then I noticed failure to handle endianness and
failure to handle unaligned accesses too.
You should be using
tmp8 = ldub(taddr);
et al. See include/exec/cpu-all.h, beginning line 253.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
Date: Thu, 12 Sep 2013 11:39:08 -0700 [thread overview]
Message-ID: <52320A4C.6020202@twiddle.net> (raw)
In-Reply-To: <1379009870-18323-1-git-send-email-sw@weilnetz.de>
On 09/12/2013 11:17 AM, Stefan Weil wrote:
> @@ -1093,7 +1093,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
> tmp8 = helper_ldb_mmu(env, taddr, tci_read_i(&tb_ptr));
> #else
> host_addr = (tcg_target_ulong)taddr;
> - assert(taddr == host_addr);
> tmp8 = *(uint8_t *)(host_addr + GUEST_BASE);
> #endif
I noticed first that g2h would be better than fiddling GUEST_BASE
by hand. But then I noticed failure to handle endianness and
failure to handle unaligned accesses too.
You should be using
tmp8 = ldub(taddr);
et al. See include/exec/cpu-all.h, beginning line 253.
r~
next prev parent reply other threads:[~2013-09-12 18:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 18:17 [Qemu-trivial] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions) Stefan Weil
2013-09-12 18:17 ` [Qemu-devel] " Stefan Weil
2013-09-12 18:39 ` Richard Henderson [this message]
2013-09-12 18:39 ` Richard Henderson
2013-09-12 18:57 ` [Qemu-trivial] " Stefan Weil
2013-09-12 18:57 ` Stefan Weil
2013-09-12 20:07 ` [Qemu-trivial] " Richard Henderson
2013-09-12 20:07 ` Richard Henderson
2013-09-12 20:28 ` Stefan Weil
2013-09-12 20:44 ` Stefan Weil
2013-09-14 9:02 ` [Qemu-trivial] " Michael Tokarev
2013-09-14 9:02 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52320A4C.6020202@twiddle.net \
--to=rth@twiddle.net \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.