All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
Date: Thu, 12 Sep 2013 13:07:43 -0700	[thread overview]
Message-ID: <52321F0F.4080903@twiddle.net> (raw)
In-Reply-To: <52320EB5.9030208@weilnetz.de>

On 09/12/2013 11:57 AM, Stefan Weil wrote:
> Thanks for your hint. Yes, as you can see from tcg/tci/README,the test
> matrix of TCI
> did not include big endian hosts up to now. Testing on an emulated big
> endian Malta
> system is terribly slow, and I have no access to real big endian
> hardware fortests.

Recall that we're not necessarily talking about big-endian host,
but big-endian target on little-endian host.  I don't see any
byte swapping going on here at all.

FYI, the smoke-test I use for big-endian is

$ qemu-system-sparc -nographic
Configuration device id QEMU version 1 machine id 32
CPUs: 1 x FMI,MB86904
UUID: 00000000-0000-0000-0000-000000000000
Welcome to OpenBIOS v1.1 built on Jul 30 2013 21:43
  Type 'help' for detailed information
Trying disk...
No valid state has been set by load or init-program

0 >

At which point you can signal the monitor to exit with ctrl-a x.

> But I think that such changes are independent of this patchwhich can be
> applied as it is.

Fair enough.  In which case

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~



WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
Date: Thu, 12 Sep 2013 13:07:43 -0700	[thread overview]
Message-ID: <52321F0F.4080903@twiddle.net> (raw)
In-Reply-To: <52320EB5.9030208@weilnetz.de>

On 09/12/2013 11:57 AM, Stefan Weil wrote:
> Thanks for your hint. Yes, as you can see from tcg/tci/README,the test
> matrix of TCI
> did not include big endian hosts up to now. Testing on an emulated big
> endian Malta
> system is terribly slow, and I have no access to real big endian
> hardware fortests.

Recall that we're not necessarily talking about big-endian host,
but big-endian target on little-endian host.  I don't see any
byte swapping going on here at all.

FYI, the smoke-test I use for big-endian is

$ qemu-system-sparc -nographic
Configuration device id QEMU version 1 machine id 32
CPUs: 1 x FMI,MB86904
UUID: 00000000-0000-0000-0000-000000000000
Welcome to OpenBIOS v1.1 built on Jul 30 2013 21:43
  Type 'help' for detailed information
Trying disk...
No valid state has been set by load or init-program

0 >

At which point you can signal the monitor to exit with ctrl-a x.

> But I think that such changes are independent of this patchwhich can be
> applied as it is.

Fair enough.  In which case

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

  reply	other threads:[~2013-09-12 20:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12 18:17 [Qemu-trivial] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions) Stefan Weil
2013-09-12 18:17 ` [Qemu-devel] " Stefan Weil
2013-09-12 18:39 ` [Qemu-trivial] " Richard Henderson
2013-09-12 18:39   ` Richard Henderson
2013-09-12 18:57   ` [Qemu-trivial] " Stefan Weil
2013-09-12 18:57     ` Stefan Weil
2013-09-12 20:07     ` Richard Henderson [this message]
2013-09-12 20:07       ` Richard Henderson
2013-09-12 20:28       ` Stefan Weil
2013-09-12 20:44         ` Stefan Weil
2013-09-14  9:02 ` [Qemu-trivial] " Michael Tokarev
2013-09-14  9:02   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52321F0F.4080903@twiddle.net \
    --to=rth@twiddle.net \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.