All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph Salisbury <joseph.salisbury@canonical.com>
To: thomas@m3y3r.de, Jiri Kosina <jkosina@suse.cz>
Cc: list@osuosl.org, Haiyang Zhang <haiyangz@microsoft.com>,
	LKML <linux-kernel@vger.kernel.org>,
	open@osuosl.org, HID CORE LAYER <linux-input@vger.kernel.org>,
	devel@linuxdriverproject.org
Subject: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup
Date: Mon, 16 Sep 2013 13:42:35 -0400	[thread overview]
Message-ID: <5237430B.5040009@canonical.com> (raw)

Hi Thomas,

A bug was opened against the Ubuntu kernel[0].  After a kernel bisect,
it was found that reverting the following commit resolved
this bug:

commit a4a23f6d68ad2c86ee8df6a6f89c9d315c0a761c
Author: Thomas Meyer <thomas@m3y3r.de>
Date:   Sat Jun 1 11:40:31 2013 +0200

    HID: hyperv: convert alloc+memcpy to memdup


The regression was introduced as of v3.11-rc1.  The bug causes a system
to lockup when connecting a bluetooth trackpad and has been reported on
multiple machines. 

I wanted to ping you since you are the author of this patch.  I was
thinking of requesting a revert for v3.12 and v3.11, but I wanted to get
your feedback first.

Reverting the patch changes the driver back to useing kzalloc() and
memcpy() instead of  kmemdup.  Doing so has uncovered another bug, which
causes an oops on memcpy()[1].  We are in the process of bisecting that
one now and will provide the results.


Thanks,

Joe

[0] pad.lv/1218004
[1]
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1218004/+attachment/3818671/+files/kern.log

             reply	other threads:[~2013-09-16 17:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16 17:42 Joseph Salisbury [this message]
2013-09-16 20:38 ` [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup Dan Carpenter
2013-09-16 20:38   ` Dan Carpenter
2013-09-16 20:49   ` Joseph Salisbury
2013-09-16 20:49     ` Joseph Salisbury
2013-09-16 21:05     ` Dan Carpenter
2013-09-16 21:05       ` Dan Carpenter
2013-09-17  0:44       ` Joseph Salisbury
2013-09-17  0:44         ` Joseph Salisbury
2013-09-24  9:29         ` Jiri Kosina
2013-09-24 13:52           ` Joseph Salisbury
2013-09-24 18:25           ` Joseph Salisbury
2013-09-24 18:25             ` Joseph Salisbury
2013-09-25 17:45           ` Joseph Salisbury
2013-09-27 10:50             ` Jiri Kosina
2013-09-27 10:50               ` Jiri Kosina
2013-09-27 14:42               ` Joseph Salisbury
2013-09-27 14:42                 ` Joseph Salisbury
2013-09-27 15:24                 ` Dan Carpenter
2013-09-27 15:24                   ` Dan Carpenter
2013-09-27 15:59                   ` Dan Carpenter
2013-09-30 14:35                   ` Jiri Kosina
2013-09-30 14:59                     ` Dan Carpenter
2013-09-30 14:59                       ` Dan Carpenter
2013-12-16 13:01                 ` Jiri Kosina
2013-12-19  9:55                   ` David Herrmann
2013-12-19  9:59                     ` Jiri Kosina
2013-12-19 10:08                       ` David Herrmann
2013-12-19 10:08                         ` David Herrmann
2013-12-19 11:22                         ` David Herrmann
2013-12-19 11:22                           ` David Herrmann
2013-12-19 12:59                           ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5237430B.5040009@canonical.com \
    --to=joseph.salisbury@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=list@osuosl.org \
    --cc=open@osuosl.org \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.