From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: list@osuosl.org, Jiri Kosina <jkosina@suse.cz>,
Haiyang Zhang <haiyangz@microsoft.com>,
LKML <linux-kernel@vger.kernel.org>,
open@osuosl.org, HID CORE LAYER <linux-input@vger.kernel.org>,
devel@linuxdriverproject.org, thomas@m3y3r.de
Subject: Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup
Date: Fri, 27 Sep 2013 18:24:12 +0300 [thread overview]
Message-ID: <20130927152412.GF6192@mwanda> (raw)
In-Reply-To: <52459942.3020600@canonical.com>
On Fri, Sep 27, 2013 at 10:42:10AM -0400, Joseph Salisbury wrote:
> On 09/27/2013 06:50 AM, Jiri Kosina wrote:
> > On Wed, 25 Sep 2013, Joseph Salisbury wrote:
> >
> >> After further testing reverting the following commit does in fact
> >> resolve the bug:
> >>
> >> commit b1a1442a23776756b254b69786848a94d92445ba
> >> Author: Jiri Kosina <jkosina@suse.cz>
> >> Date: Mon Jun 3 11:27:48 2013 +0200
> >>
> >> HID: core: fix reporting of raw events
> >>
> >> Reverting this commit in v3.12-rc2 prevents the system from locking up,
> >> which happens when connecting a bluetooth trackpad.
> >>
> >> Jiri, do you think we should revert this patch, or is there some further
> >> debugging/data collecting you would like to do?
> > Hi Joseph,
> >
> > in this mail:
> >
> > Message-ID: <5241992E.3090805@canonical.com>
> > Date: Tue, 24 Sep 2013 09:52:46 -0400
> >
> > you said that reverting this commit doesn't prevent the lockups, so I am
> > rather confused ... ?
> >
> > Thanks,
> >
> The testing was invalid. Reverting commit b1a1442 does resolve the bug
> and stop the lockups.
>
It looks like magicmouse_raw_event() returns 1 on success and 0 on
failure.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
list@osuosl.org, Haiyang Zhang <haiyangz@microsoft.com>,
LKML <linux-kernel@vger.kernel.org>,
open@osuosl.org, HID CORE LAYER <linux-input@vger.kernel.org>,
devel@linuxdriverproject.org, thomas@m3y3r.de
Subject: Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup
Date: Fri, 27 Sep 2013 18:24:12 +0300 [thread overview]
Message-ID: <20130927152412.GF6192@mwanda> (raw)
In-Reply-To: <52459942.3020600@canonical.com>
On Fri, Sep 27, 2013 at 10:42:10AM -0400, Joseph Salisbury wrote:
> On 09/27/2013 06:50 AM, Jiri Kosina wrote:
> > On Wed, 25 Sep 2013, Joseph Salisbury wrote:
> >
> >> After further testing reverting the following commit does in fact
> >> resolve the bug:
> >>
> >> commit b1a1442a23776756b254b69786848a94d92445ba
> >> Author: Jiri Kosina <jkosina@suse.cz>
> >> Date: Mon Jun 3 11:27:48 2013 +0200
> >>
> >> HID: core: fix reporting of raw events
> >>
> >> Reverting this commit in v3.12-rc2 prevents the system from locking up,
> >> which happens when connecting a bluetooth trackpad.
> >>
> >> Jiri, do you think we should revert this patch, or is there some further
> >> debugging/data collecting you would like to do?
> > Hi Joseph,
> >
> > in this mail:
> >
> > Message-ID: <5241992E.3090805@canonical.com>
> > Date: Tue, 24 Sep 2013 09:52:46 -0400
> >
> > you said that reverting this commit doesn't prevent the lockups, so I am
> > rather confused ... ?
> >
> > Thanks,
> >
> The testing was invalid. Reverting commit b1a1442 does resolve the bug
> and stop the lockups.
>
It looks like magicmouse_raw_event() returns 1 on success and 0 on
failure.
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-27 15:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 17:42 [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup Joseph Salisbury
2013-09-16 20:38 ` Dan Carpenter
2013-09-16 20:38 ` Dan Carpenter
2013-09-16 20:49 ` Joseph Salisbury
2013-09-16 20:49 ` Joseph Salisbury
2013-09-16 21:05 ` Dan Carpenter
2013-09-16 21:05 ` Dan Carpenter
2013-09-17 0:44 ` Joseph Salisbury
2013-09-17 0:44 ` Joseph Salisbury
2013-09-24 9:29 ` Jiri Kosina
2013-09-24 13:52 ` Joseph Salisbury
2013-09-24 18:25 ` Joseph Salisbury
2013-09-24 18:25 ` Joseph Salisbury
2013-09-25 17:45 ` Joseph Salisbury
2013-09-27 10:50 ` Jiri Kosina
2013-09-27 10:50 ` Jiri Kosina
2013-09-27 14:42 ` Joseph Salisbury
2013-09-27 14:42 ` Joseph Salisbury
2013-09-27 15:24 ` Dan Carpenter [this message]
2013-09-27 15:24 ` Dan Carpenter
2013-09-27 15:59 ` Dan Carpenter
2013-09-30 14:35 ` Jiri Kosina
2013-09-30 14:59 ` Dan Carpenter
2013-09-30 14:59 ` Dan Carpenter
2013-12-16 13:01 ` Jiri Kosina
2013-12-19 9:55 ` David Herrmann
2013-12-19 9:59 ` Jiri Kosina
2013-12-19 10:08 ` David Herrmann
2013-12-19 10:08 ` David Herrmann
2013-12-19 11:22 ` David Herrmann
2013-12-19 11:22 ` David Herrmann
2013-12-19 12:59 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927152412.GF6192@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jkosina@suse.cz \
--cc=joseph.salisbury@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=list@osuosl.org \
--cc=open@osuosl.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.