* Re: [next:master 1495/1772] drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' [not found] <524106f9.teHmhjmgqBH0qZNH%fengguang.wu@intel.com> @ 2013-09-25 7:27 ` Lars-Peter Clausen 2013-09-25 16:16 ` Jonathan Cameron 0 siblings, 1 reply; 5+ messages in thread From: Lars-Peter Clausen @ 2013-09-25 7:27 UTC (permalink / raw) To: Jonathan Cameron; +Cc: linux-iio@vger.kernel.org On 09/24/2013 05:28 AM, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 1fa8f71dfa6e28c89afad7ac71dcb19b8c8da8b7 > commit: 09a799d04eb17e19bbc80cb0e350a3ec89552b01 [1495/1772] staging:iio:dummy: Use iio_push_to_buffers_with_timestamp() > config: i386-randconfig-j6-09240827 (attached as .config) > > All error/warnings: > > drivers/staging/iio/iio_simple_dummy_buffer.c: In function 'iio_simple_dummy_trigger_h': >>> drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' [-Werror=implicit-function-declaration] > iio_push_to_buffers_with_timestamp(indio_dev, data, iio_get_time_ns()); > ^ > drivers/staging/iio/iio_simple_dummy_buffer.c: At top level: > drivers/staging/iio/iio_simple_dummy_buffer.c:108:16: error: 'iio_sw_buffer_preenable' undeclared here (not in a function) > .preenable = &iio_sw_buffer_preenable, > ^ > drivers/staging/iio/iio_simple_dummy_buffer.c: In function 'iio_simple_dummy_configure_buffer': > drivers/staging/iio/iio_simple_dummy_buffer.c:141:8: error: dereferencing pointer to incomplete type > buffer->scan_timestamp = true; > ^ > cc1: some warnings being treated as errors > > vim +/iio_push_to_buffers_with_timestamp +86 drivers/staging/iio/iio_simple_dummy_buffer.c > > 80 /* random access read from the 'device' */ > 81 data[i] = fakedata[j]; > 82 len += 2; > 83 } > 84 } > 85 > > 86 iio_push_to_buffers_with_timestamp(indio_dev, data, iio_get_time_ns()); > 87 > 88 kfree(data); > 89 Hm, the config that generated this has: CONFIG_IIO=m # CONFIG_IIO_BUFFER is not set CONFIG_IIO_KFIFO_BUF=m How is it possible that IIO_KFIFO_BUF is selected but not IIO_BUFFER? - Lars ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [next:master 1495/1772] drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' 2013-09-25 7:27 ` [next:master 1495/1772] drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' Lars-Peter Clausen @ 2013-09-25 16:16 ` Jonathan Cameron 2013-09-25 16:22 ` Jonathan Cameron 0 siblings, 1 reply; 5+ messages in thread From: Jonathan Cameron @ 2013-09-25 16:16 UTC (permalink / raw) To: Lars-Peter Clausen; +Cc: linux-iio@vger.kernel.org Lars-Peter Clausen <lars@metafoo.de> wrote: >On 09/24/2013 05:28 AM, kbuild test robot wrote: >> tree: >git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >master >> head: 1fa8f71dfa6e28c89afad7ac71dcb19b8c8da8b7 >> commit: 09a799d04eb17e19bbc80cb0e350a3ec89552b01 [1495/1772] >staging:iio:dummy: Use iio_push_to_buffers_with_timestamp() >> config: i386-randconfig-j6-09240827 (attached as .config) >> >> All error/warnings: >> >> drivers/staging/iio/iio_simple_dummy_buffer.c: In function >'iio_simple_dummy_trigger_h': >>>> drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit >declaration of function 'iio_push_to_buffers_with_timestamp' >[-Werror=implicit-function-declaration] >> iio_push_to_buffers_with_timestamp(indio_dev, data, >iio_get_time_ns()); >> ^ >> drivers/staging/iio/iio_simple_dummy_buffer.c: At top level: >> drivers/staging/iio/iio_simple_dummy_buffer.c:108:16: error: >'iio_sw_buffer_preenable' undeclared here (not in a function) >> .preenable = &iio_sw_buffer_preenable, >> ^ >> drivers/staging/iio/iio_simple_dummy_buffer.c: In function >'iio_simple_dummy_configure_buffer': >> drivers/staging/iio/iio_simple_dummy_buffer.c:141:8: error: >dereferencing pointer to incomplete type >> buffer->scan_timestamp = true; >> ^ >> cc1: some warnings being treated as errors >> >> vim +/iio_push_to_buffers_with_timestamp +86 >drivers/staging/iio/iio_simple_dummy_buffer.c >> >> 80 /* random access read from the 'device' */ >> 81 data[i] = fakedata[j]; >> 82 len += 2; >> 83 } >> 84 } >> 85 >> > 86 iio_push_to_buffers_with_timestamp(indio_dev, data, >iio_get_time_ns()); >> 87 >> 88 kfree(data); >> 89 > > >Hm, the config that generated this has: > >CONFIG_IIO=m ># CONFIG_IIO_BUFFER is not set >CONFIG_IIO_KFIFO_BUF=m > >How is it possible that IIO_KFIFO_BUF is selected but not IIO_BUFFER? > How does a SELECT interact with an IF in kconfig? I am not sure.. We select the kfifo_buf and that is under IF IIO_BUFFER. >- Lars -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [next:master 1495/1772] drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' 2013-09-25 16:16 ` Jonathan Cameron @ 2013-09-25 16:22 ` Jonathan Cameron 2013-09-25 16:29 ` Lars-Peter Clausen 0 siblings, 1 reply; 5+ messages in thread From: Jonathan Cameron @ 2013-09-25 16:22 UTC (permalink / raw) To: Lars-Peter Clausen; +Cc: linux-iio@vger.kernel.org Jonathan Cameron <jic23@kernel.org> wrote: > > >Lars-Peter Clausen <lars@metafoo.de> wrote: >>On 09/24/2013 05:28 AM, kbuild test robot wrote: >>> tree: >>git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>master >>> head: 1fa8f71dfa6e28c89afad7ac71dcb19b8c8da8b7 >>> commit: 09a799d04eb17e19bbc80cb0e350a3ec89552b01 [1495/1772] >>staging:iio:dummy: Use iio_push_to_buffers_with_timestamp() >>> config: i386-randconfig-j6-09240827 (attached as .config) >>> >>> All error/warnings: >>> >>> drivers/staging/iio/iio_simple_dummy_buffer.c: In function >>'iio_simple_dummy_trigger_h': >>>>> drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: >implicit >>declaration of function 'iio_push_to_buffers_with_timestamp' >>[-Werror=implicit-function-declaration] >>> iio_push_to_buffers_with_timestamp(indio_dev, data, >>iio_get_time_ns()); >>> ^ >>> drivers/staging/iio/iio_simple_dummy_buffer.c: At top level: >>> drivers/staging/iio/iio_simple_dummy_buffer.c:108:16: error: >>'iio_sw_buffer_preenable' undeclared here (not in a function) >>> .preenable = &iio_sw_buffer_preenable, >>> ^ >>> drivers/staging/iio/iio_simple_dummy_buffer.c: In function >>'iio_simple_dummy_configure_buffer': >>> drivers/staging/iio/iio_simple_dummy_buffer.c:141:8: error: >>dereferencing pointer to incomplete type >>> buffer->scan_timestamp = true; >>> ^ >>> cc1: some warnings being treated as errors >>> >>> vim +/iio_push_to_buffers_with_timestamp +86 >>drivers/staging/iio/iio_simple_dummy_buffer.c >>> >>> 80 /* random access read from the 'device' */ >>> 81 data[i] = fakedata[j]; >>> 82 len += 2; >>> 83 } >>> 84 } >>> 85 >>> > 86 iio_push_to_buffers_with_timestamp(indio_dev, data, >>iio_get_time_ns()); >>> 87 >>> 88 kfree(data); >>> 89 >> >> >>Hm, the config that generated this has: >> >>CONFIG_IIO=m >># CONFIG_IIO_BUFFER is not set >>CONFIG_IIO_KFIFO_BUF=m >> >>How is it possible that IIO_KFIFO_BUF is selected but not IIO_BUFFER? >> >How does a SELECT interact with an IF in kconfig? I am not sure.. > >We select the kfifo_buf and that is under IF IIO_BUFFER. The documentation for select makes it clear that it does not enforce dependencies so I guess any select of Kfifo_buf must also select iio_buffer? Sometimes there seems to be no right way of doing this stuff... Oh for a dependency solver. > > >>- Lars -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [next:master 1495/1772] drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' 2013-09-25 16:22 ` Jonathan Cameron @ 2013-09-25 16:29 ` Lars-Peter Clausen 2013-09-25 17:09 ` Jonathan Cameron 0 siblings, 1 reply; 5+ messages in thread From: Lars-Peter Clausen @ 2013-09-25 16:29 UTC (permalink / raw) To: Jonathan Cameron; +Cc: linux-iio@vger.kernel.org, Zubair Lutfullah On 09/25/2013 06:22 PM, Jonathan Cameron wrote: > > > Jonathan Cameron <jic23@kernel.org> wrote: >> >> >> Lars-Peter Clausen <lars@metafoo.de> wrote: >>> On 09/24/2013 05:28 AM, kbuild test robot wrote: >>>> tree: >>> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>> master >>>> head: 1fa8f71dfa6e28c89afad7ac71dcb19b8c8da8b7 >>>> commit: 09a799d04eb17e19bbc80cb0e350a3ec89552b01 [1495/1772] >>> staging:iio:dummy: Use iio_push_to_buffers_with_timestamp() >>>> config: i386-randconfig-j6-09240827 (attached as .config) >>>> >>>> All error/warnings: >>>> >>>> drivers/staging/iio/iio_simple_dummy_buffer.c: In function >>> 'iio_simple_dummy_trigger_h': >>>>>> drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: >> implicit >>> declaration of function 'iio_push_to_buffers_with_timestamp' >>> [-Werror=implicit-function-declaration] >>>> iio_push_to_buffers_with_timestamp(indio_dev, data, >>> iio_get_time_ns()); >>>> ^ >>>> drivers/staging/iio/iio_simple_dummy_buffer.c: At top level: >>>> drivers/staging/iio/iio_simple_dummy_buffer.c:108:16: error: >>> 'iio_sw_buffer_preenable' undeclared here (not in a function) >>>> .preenable = &iio_sw_buffer_preenable, >>>> ^ >>>> drivers/staging/iio/iio_simple_dummy_buffer.c: In function >>> 'iio_simple_dummy_configure_buffer': >>>> drivers/staging/iio/iio_simple_dummy_buffer.c:141:8: error: >>> dereferencing pointer to incomplete type >>>> buffer->scan_timestamp = true; >>>> ^ >>>> cc1: some warnings being treated as errors >>>> >>>> vim +/iio_push_to_buffers_with_timestamp +86 >>> drivers/staging/iio/iio_simple_dummy_buffer.c >>>> >>>> 80 /* random access read from the 'device' */ >>>> 81 data[i] = fakedata[j]; >>>> 82 len += 2; >>>> 83 } >>>> 84 } >>>> 85 >>>> > 86 iio_push_to_buffers_with_timestamp(indio_dev, data, >>> iio_get_time_ns()); >>>> 87 >>>> 88 kfree(data); >>>> 89 >>> >>> >>> Hm, the config that generated this has: >>> >>> CONFIG_IIO=m >>> # CONFIG_IIO_BUFFER is not set >>> CONFIG_IIO_KFIFO_BUF=m >>> >>> How is it possible that IIO_KFIFO_BUF is selected but not IIO_BUFFER? >>> >> How does a SELECT interact with an IF in kconfig? I am not sure.. >> >> We select the kfifo_buf and that is under IF IIO_BUFFER. > > The documentation for select makes it clear that it does not enforce dependencies so I guess any select of Kfifo_buf must also select iio_buffer? Sometimes there seems to be no right way of doing this stuff... Just wanted to say that we never do this, but then looked at the latest iio/togreg and the commit that causes it seems to be "ca9a5638 iio: ti_am335x_adc: Add continuous sampling support". Which selects the KFIFO buffer without either selecting IIO_BUFFER as well or depending on IIO_BUFFER. - Lars ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [next:master 1495/1772] drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' 2013-09-25 16:29 ` Lars-Peter Clausen @ 2013-09-25 17:09 ` Jonathan Cameron 0 siblings, 0 replies; 5+ messages in thread From: Jonathan Cameron @ 2013-09-25 17:09 UTC (permalink / raw) To: Lars-Peter Clausen; +Cc: linux-iio@vger.kernel.org, Zubair Lutfullah Lars-Peter Clausen <lars@metafoo.de> wrote: >On 09/25/2013 06:22 PM, Jonathan Cameron wrote: >> >> >> Jonathan Cameron <jic23@kernel.org> wrote: >>> >>> >>> Lars-Peter Clausen <lars@metafoo.de> wrote: >>>> On 09/24/2013 05:28 AM, kbuild test robot wrote: >>>>> tree: >>>> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>>> master >>>>> head: 1fa8f71dfa6e28c89afad7ac71dcb19b8c8da8b7 >>>>> commit: 09a799d04eb17e19bbc80cb0e350a3ec89552b01 [1495/1772] >>>> staging:iio:dummy: Use iio_push_to_buffers_with_timestamp() >>>>> config: i386-randconfig-j6-09240827 (attached as .config) >>>>> >>>>> All error/warnings: >>>>> >>>>> drivers/staging/iio/iio_simple_dummy_buffer.c: In function >>>> 'iio_simple_dummy_trigger_h': >>>>>>> drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: >>> implicit >>>> declaration of function 'iio_push_to_buffers_with_timestamp' >>>> [-Werror=implicit-function-declaration] >>>>> iio_push_to_buffers_with_timestamp(indio_dev, data, >>>> iio_get_time_ns()); >>>>> ^ >>>>> drivers/staging/iio/iio_simple_dummy_buffer.c: At top level: >>>>> drivers/staging/iio/iio_simple_dummy_buffer.c:108:16: error: >>>> 'iio_sw_buffer_preenable' undeclared here (not in a function) >>>>> .preenable = &iio_sw_buffer_preenable, >>>>> ^ >>>>> drivers/staging/iio/iio_simple_dummy_buffer.c: In function >>>> 'iio_simple_dummy_configure_buffer': >>>>> drivers/staging/iio/iio_simple_dummy_buffer.c:141:8: error: >>>> dereferencing pointer to incomplete type >>>>> buffer->scan_timestamp = true; >>>>> ^ >>>>> cc1: some warnings being treated as errors >>>>> >>>>> vim +/iio_push_to_buffers_with_timestamp +86 >>>> drivers/staging/iio/iio_simple_dummy_buffer.c >>>>> >>>>> 80 /* random access read from the 'device' */ >>>>> 81 data[i] = fakedata[j]; >>>>> 82 len += 2; >>>>> 83 } >>>>> 84 } >>>>> 85 >>>>> > 86 iio_push_to_buffers_with_timestamp(indio_dev, data, >>>> iio_get_time_ns()); >>>>> 87 >>>>> 88 kfree(data); >>>>> 89 >>>> >>>> >>>> Hm, the config that generated this has: >>>> >>>> CONFIG_IIO=m >>>> # CONFIG_IIO_BUFFER is not set >>>> CONFIG_IIO_KFIFO_BUF=m >>>> >>>> How is it possible that IIO_KFIFO_BUF is selected but not >IIO_BUFFER? >>>> >>> How does a SELECT interact with an IF in kconfig? I am not sure.. >>> >>> We select the kfifo_buf and that is under IF IIO_BUFFER. >> >> The documentation for select makes it clear that it does not enforce >dependencies so I guess any select of Kfifo_buf must also select >iio_buffer? Sometimes there seems to be no right way of doing this >stuff... > >Just wanted to say that we never do this, but then looked at the latest >iio/togreg and the commit that causes it seems to be "ca9a5638 iio: >ti_am335x_adc: Add continuous sampling support". Which selects the >KFIFO >buffer without either selecting IIO_BUFFER as well or depending on >IIO_BUFFER. Yup my bad given I put that in the original patch based on an earlier autobuilder message and didn't think it through properly. Sorry about that. Will get a fix in place shortly. Jonathan > >- Lars -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-25 17:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <524106f9.teHmhjmgqBH0qZNH%fengguang.wu@intel.com>
2013-09-25 7:27 ` [next:master 1495/1772] drivers/staging/iio/iio_simple_dummy_buffer.c:86:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' Lars-Peter Clausen
2013-09-25 16:16 ` Jonathan Cameron
2013-09-25 16:22 ` Jonathan Cameron
2013-09-25 16:29 ` Lars-Peter Clausen
2013-09-25 17:09 ` Jonathan Cameron
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.