From: Maxime COQUELIN <maxime.coquelin@st.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Srinivas KANDAGATLA <srinivas.kandagatla@st.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Stephen GALLIMORE <stephen.gallimore@st.com>,
Stuart MENEFY <stuart.menefy@st.com>,
Lee Jones <lee.jones@linaro.org>,
Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
Olivier CLERGEAUD <olivier.clergeaud@st.co>
Subject: Re: [PATCH 1/4] i2c: busses: i2c-st: Add ST I2C controller
Date: Thu, 26 Sep 2013 11:30:23 +0200 [thread overview]
Message-ID: <5243FEAF.4090506@st.com> (raw)
In-Reply-To: <20130924155925.GA2995@katana>
On 09/24/2013 05:59 PM, Wolfram Sang wrote:
>> "glitch" is is used to tune the I2C timing requirements, and has a
>> nanosecond granularity.
>> These values are added to default timing values.
>> I'm not 100% sure, but it looks like the "samsung,i2c-sda-delay" in the
>> i2c-s3c2410 driver.
> For that, we have the generic "i2c-sda-hold-time-ns" property. The s3c
> driver hasn't been converted to use it, sadly.
>
Ok, thank you for pointing this out.
After some checks, this property doesn't match with what is done in this
driver.
In the v2 series I am sending, I removed the I2C timing tuning as it
works on all
the boards I have tested with.
I will only keep the anti-glitch filtering, using private properties as
I didn't find any generic
ones that could fit.
Regards,
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: maxime.coquelin@st.com (Maxime COQUELIN)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] i2c: busses: i2c-st: Add ST I2C controller
Date: Thu, 26 Sep 2013 11:30:23 +0200 [thread overview]
Message-ID: <5243FEAF.4090506@st.com> (raw)
In-Reply-To: <20130924155925.GA2995@katana>
On 09/24/2013 05:59 PM, Wolfram Sang wrote:
>> "glitch" is is used to tune the I2C timing requirements, and has a
>> nanosecond granularity.
>> These values are added to default timing values.
>> I'm not 100% sure, but it looks like the "samsung,i2c-sda-delay" in the
>> i2c-s3c2410 driver.
> For that, we have the generic "i2c-sda-hold-time-ns" property. The s3c
> driver hasn't been converted to use it, sadly.
>
Ok, thank you for pointing this out.
After some checks, this property doesn't match with what is done in this
driver.
In the v2 series I am sending, I removed the I2C timing tuning as it
works on all
the boards I have tested with.
I will only keep the anti-glitch filtering, using private properties as
I didn't find any generic
ones that could fit.
Regards,
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Maxime COQUELIN <maxime.coquelin@st.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Srinivas KANDAGATLA <srinivas.kandagatla@st.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Stephen GALLIMORE <stephen.gallimore@st.com>,
Stuart MENEFY <stuart.menefy@st.com>,
Lee Jones <lee.jones@linaro.org>,
Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
Olivier CLERGEAUD <olivier.clergeaud@st.com>
Subject: Re: [PATCH 1/4] i2c: busses: i2c-st: Add ST I2C controller
Date: Thu, 26 Sep 2013 11:30:23 +0200 [thread overview]
Message-ID: <5243FEAF.4090506@st.com> (raw)
In-Reply-To: <20130924155925.GA2995@katana>
On 09/24/2013 05:59 PM, Wolfram Sang wrote:
>> "glitch" is is used to tune the I2C timing requirements, and has a
>> nanosecond granularity.
>> These values are added to default timing values.
>> I'm not 100% sure, but it looks like the "samsung,i2c-sda-delay" in the
>> i2c-s3c2410 driver.
> For that, we have the generic "i2c-sda-hold-time-ns" property. The s3c
> driver hasn't been converted to use it, sadly.
>
Ok, thank you for pointing this out.
After some checks, this property doesn't match with what is done in this
driver.
In the v2 series I am sending, I removed the I2C timing tuning as it
works on all
the boards I have tested with.
I will only keep the anti-glitch filtering, using private properties as
I didn't find any generic
ones that could fit.
Regards,
Maxime
next prev parent reply other threads:[~2013-09-26 9:30 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 10:01 [PATCH 0/4] Add I2C support to ST SoCs Maxime COQUELIN
2013-09-18 10:01 ` Maxime COQUELIN
2013-09-18 10:01 ` [PATCH 1/4] i2c: busses: i2c-st: Add ST I2C controller Maxime COQUELIN
2013-09-18 10:01 ` Maxime COQUELIN
2013-09-18 12:47 ` Gabriel FERNANDEZ
2013-09-18 12:47 ` Gabriel FERNANDEZ
2013-09-18 12:47 ` Gabriel FERNANDEZ
[not found] ` <5239A0ED.6010606-qxv4g6HH51o@public.gmane.org>
2013-09-23 20:55 ` Stephen Warren
2013-09-23 20:55 ` Stephen Warren
2013-09-23 20:55 ` Stephen Warren
[not found] ` <1379498483-4236-2-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2013-09-23 21:06 ` Stephen Warren
2013-09-23 21:06 ` Stephen Warren
2013-09-23 21:06 ` Stephen Warren
[not found] ` <5240AD6E.4090905-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-24 15:38 ` Maxime COQUELIN
2013-09-24 15:38 ` Maxime COQUELIN
2013-09-24 15:38 ` Maxime COQUELIN
[not found] ` <5241B1FA.6020500-qxv4g6HH51o@public.gmane.org>
2013-09-24 15:59 ` Wolfram Sang
2013-09-24 15:59 ` Wolfram Sang
2013-09-24 15:59 ` Wolfram Sang
2013-09-26 9:30 ` Maxime COQUELIN [this message]
2013-09-26 9:30 ` Maxime COQUELIN
2013-09-26 9:30 ` Maxime COQUELIN
[not found] ` <1379498483-4236-1-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2013-09-18 10:01 ` [PATCH 2/4] ARM: STi: Supply I2C configuration to STiH416 SoC Maxime COQUELIN
2013-09-18 10:01 ` Maxime COQUELIN
2013-09-18 10:01 ` Maxime COQUELIN
[not found] ` <1379498483-4236-3-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2013-09-18 12:03 ` Lee Jones
2013-09-18 12:03 ` Lee Jones
2013-09-18 12:03 ` Lee Jones
2013-09-18 12:46 ` Maxime COQUELIN
2013-09-18 12:46 ` Maxime COQUELIN
2013-09-18 12:46 ` Maxime COQUELIN
[not found] ` <84625B87D65BCF478CC1E9C886A4C314DEF1BD9578-+EwDPpWUVoSs+H57zxxw29BPR1lH4CV8@public.gmane.org>
2013-09-18 12:57 ` Srinivas KANDAGATLA
2013-09-18 12:57 ` Srinivas KANDAGATLA
2013-09-18 12:57 ` Srinivas KANDAGATLA
2013-09-19 7:16 ` Maxime COQUELIN
2013-09-19 7:16 ` Maxime COQUELIN
2013-09-19 7:16 ` Maxime COQUELIN
2013-09-19 12:59 ` Srinivas KANDAGATLA
2013-09-19 12:59 ` Srinivas KANDAGATLA
2013-09-19 15:22 ` Maxime COQUELIN
2013-09-19 15:22 ` Maxime COQUELIN
[not found] ` <84625B87D65BCF478CC1E9C886A4C314DEF1BD957D-+EwDPpWUVoSs+H57zxxw29BPR1lH4CV8@public.gmane.org>
2013-09-19 15:32 ` Lee Jones
2013-09-19 15:32 ` Lee Jones
2013-09-19 15:32 ` Lee Jones
2013-09-18 10:01 ` [PATCH 3/4] ARM: STi: Supply I2C configuration to STiH415 SoC Maxime COQUELIN
2013-09-18 10:01 ` Maxime COQUELIN
2013-09-18 12:00 ` Lee Jones
2013-09-18 12:00 ` Lee Jones
2013-09-18 12:38 ` Maxime COQUELIN
2013-09-18 12:38 ` Maxime COQUELIN
2013-09-18 12:38 ` Maxime COQUELIN
2013-09-18 10:01 ` [PATCH 4/4] ARM: STi: Add I2C config to B2000 and B2020 boards Maxime COQUELIN
2013-09-18 10:01 ` Maxime COQUELIN
2013-09-18 11:40 ` Lee Jones
2013-09-18 11:40 ` Lee Jones
2013-09-18 12:36 ` Maxime COQUELIN
2013-09-18 12:36 ` Maxime COQUELIN
2013-09-18 12:36 ` Maxime COQUELIN
-- strict thread matches above, loose matches on Subject: below --
2013-10-01 10:39 [PATCH v3 0/4] Add I2C support to ST SoCs Maxime COQUELIN
[not found] ` <1380623952-4252-1-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2013-10-01 10:39 ` [PATCH 1/4] i2c: busses: i2c-st: Add ST I2C controller Maxime COQUELIN
2013-10-01 10:39 ` Maxime COQUELIN
2013-10-01 10:39 ` Maxime COQUELIN
[not found] ` <1380623952-4252-2-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2013-10-01 20:45 ` Stephen Warren
2013-10-01 20:45 ` Stephen Warren
2013-10-01 20:45 ` Stephen Warren
2013-10-02 8:36 ` Maxime COQUELIN
2013-10-02 8:36 ` Maxime COQUELIN
2013-10-02 8:36 ` Maxime COQUELIN
2013-10-02 9:02 ` Wolfram Sang
2013-10-02 9:02 ` Wolfram Sang
2013-10-02 9:35 ` Maxime COQUELIN
2013-10-02 9:35 ` Maxime COQUELIN
[not found] ` <524BE8FB.40000-qxv4g6HH51o@public.gmane.org>
2013-10-02 13:56 ` Maxime COQUELIN
2013-10-02 13:56 ` Maxime COQUELIN
2013-10-02 13:56 ` Maxime COQUELIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5243FEAF.4090506@st.com \
--to=maxime.coquelin@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gabriel.fernandez@st.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olivier.clergeaud@st.co \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=srinivas.kandagatla@st.com \
--cc=stephen.gallimore@st.com \
--cc=stuart.menefy@st.com \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.