All of lore.kernel.org
 help / color / mirror / Atom feed
From: Afzal Mohammed <afzal@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Ambresh K <ambresh@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Benoit Cousson <bcousson@baylibre.com>,
	Tony Lindgren <tony@atomide.com>, Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH v4 07/11] ARM: OMAP2+: CM: AM43x clockdomain data
Date: Mon, 30 Sep 2013 17:08:12 +0530	[thread overview]
Message-ID: <524962A4.5080405@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309301107150.17980@utopia.booyaka.com>

Hi Paul,

On Monday 30 September 2013 04:39 PM, Paul Walmsley wrote:
> On Mon, 30 Sep 2013, Afzal Mohammed wrote:

>>> The references to "wkup_pwrdm" on some of these clockdomains don't 
>>> look right to me.  For example, this clockdomain is listed as being in 
>>> AM43XX_CM_WKUP_INST, but its enclosing powerdomain is listed as being in 
>>> AM43XX_PRM_WKUP_INST.  Looks to me like it's best to have two different 
>>> wakeup powerdomains: one CM_WKUP, and one PRM_WKUP.
>>
>> On AM43x, prcm is a single block as in AM335x and is part of wakeup
>> domain. This is different from OMAP4 that had separate prm and cm
>> blocks. Script also generated the same output.

> Why are there two different address offsets for CM_WKUP and PRM_WKUP?  
> From another patch in the series:
> 
> +#define AM43XX_PRM_WKUP_INST                           0x2000
> 
> ...
> 
> +#define AM43XX_CM_WKUP_INST                            0x2800

AM43XX_PRM_WKUP_INST and AM43XX_CM_WKUP_INST are offsets from PRCM_BASE.
We don't have separate base address for PRM & CM. This is similar to as
that in AM335x, where it is 0xD00 and 0x400 respectively (both from same
base) as in prm33xx.h & cm33xx.h.

Please note that AM43XX_PRM_PARTITION and AM43XX_CM_PARTITION both are '1'.

PRCM register details from TRM (not yet public) is mentioned below.

Regards
Afzal


PRCM Functional Registers
The table below shows the base address and address space for the PRCM
module instances.
Table 2. PRCM Instance Summary
ModuleName	BaseAddress	Size
OCP_SOCKET_PRM	0x0000		256 Bytes
PRM_MPU		0x0300		256 Bytes
PRM_GFX		0x0400		256 Bytes
PRM_RTC		0x0500		256 Bytes
PRM_TAMPER	0x0600		256 Bytes
PRM_CEFUSE	0x0700		256 Bytes
PRM_PER		0x0800		6 KBytes
PRM_WKUP	0x2000		2 KBytes
CM_WKUP		0x2800		2 KBytes
PRM_DEVICE	0x4000		256 Bytes
CM_DEVICE	0x4100		256 Bytes
CM_DPLL		0x4200		256 Bytes
CM_MPU		0x8300		256 Bytes
CM_GFX		0x8400		256 Bytes
CM_RTC		0x8500		256 Bytes
CM_TAMPER	0x8600		256 Bytes
CM_CEFUSE	0x8700		256 Bytes
CM_PER		0x8800		6 KBytes




WARNING: multiple messages have this Message-ID (diff)
From: afzal@ti.com (Afzal Mohammed)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 07/11] ARM: OMAP2+: CM: AM43x clockdomain data
Date: Mon, 30 Sep 2013 17:08:12 +0530	[thread overview]
Message-ID: <524962A4.5080405@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309301107150.17980@utopia.booyaka.com>

Hi Paul,

On Monday 30 September 2013 04:39 PM, Paul Walmsley wrote:
> On Mon, 30 Sep 2013, Afzal Mohammed wrote:

>>> The references to "wkup_pwrdm" on some of these clockdomains don't 
>>> look right to me.  For example, this clockdomain is listed as being in 
>>> AM43XX_CM_WKUP_INST, but its enclosing powerdomain is listed as being in 
>>> AM43XX_PRM_WKUP_INST.  Looks to me like it's best to have two different 
>>> wakeup powerdomains: one CM_WKUP, and one PRM_WKUP.
>>
>> On AM43x, prcm is a single block as in AM335x and is part of wakeup
>> domain. This is different from OMAP4 that had separate prm and cm
>> blocks. Script also generated the same output.

> Why are there two different address offsets for CM_WKUP and PRM_WKUP?  
> From another patch in the series:
> 
> +#define AM43XX_PRM_WKUP_INST                           0x2000
> 
> ...
> 
> +#define AM43XX_CM_WKUP_INST                            0x2800

AM43XX_PRM_WKUP_INST and AM43XX_CM_WKUP_INST are offsets from PRCM_BASE.
We don't have separate base address for PRM & CM. This is similar to as
that in AM335x, where it is 0xD00 and 0x400 respectively (both from same
base) as in prm33xx.h & cm33xx.h.

Please note that AM43XX_PRM_PARTITION and AM43XX_CM_PARTITION both are '1'.

PRCM register details from TRM (not yet public) is mentioned below.

Regards
Afzal


PRCM Functional Registers
The table below shows the base address and address space for the PRCM
module instances.
Table 2. PRCM Instance Summary
ModuleName	BaseAddress	Size
OCP_SOCKET_PRM	0x0000		256 Bytes
PRM_MPU		0x0300		256 Bytes
PRM_GFX		0x0400		256 Bytes
PRM_RTC		0x0500		256 Bytes
PRM_TAMPER	0x0600		256 Bytes
PRM_CEFUSE	0x0700		256 Bytes
PRM_PER		0x0800		6 KBytes
PRM_WKUP	0x2000		2 KBytes
CM_WKUP		0x2800		2 KBytes
PRM_DEVICE	0x4000		256 Bytes
CM_DEVICE	0x4100		256 Bytes
CM_DPLL		0x4200		256 Bytes
CM_MPU		0x8300		256 Bytes
CM_GFX		0x8400		256 Bytes
CM_RTC		0x8500		256 Bytes
CM_TAMPER	0x8600		256 Bytes
CM_CEFUSE	0x8700		256 Bytes
CM_PER		0x8800		6 KBytes

  reply	other threads:[~2013-09-30 11:38 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26  9:28 [PATCH v4 00/11] ARM: OMAP2+: AM43x PRCM basic support Afzal Mohammed
2013-09-26  9:28 ` Afzal Mohammed
2013-09-26  9:32 ` [PATCH v4 01/11] ARM: OMAP2+: CM: cm_inst offset s16->u16 Afzal Mohammed
2013-09-26  9:32   ` Afzal Mohammed
2013-09-30  3:23   ` Paul Walmsley
2013-09-30  3:23     ` Paul Walmsley
2013-09-30  8:50     ` Afzal Mohammed
2013-09-30  8:50       ` Afzal Mohammed
2013-09-26  9:32 ` [PATCH v4 03/11] ARM: OMAP2+: hwmod: AM335x: runtime register update Afzal Mohammed
2013-09-26  9:32   ` Afzal Mohammed
2013-09-26  9:32 ` [PATCH v4 04/11] ARM: OMAP2+: hwmod: AM335x: remove static register offs Afzal Mohammed
2013-09-26  9:32   ` Afzal Mohammed
2013-09-26  9:32 ` [PATCH v4 05/11] ARM: OMAP2+: PRCM: AM43x definitions Afzal Mohammed
2013-09-26  9:32   ` Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 06/11] ARM: OMAP2+: PM: AM43x powerdomain data Afzal Mohammed
2013-09-26  9:33   ` Afzal Mohammed
2013-09-30 10:27   ` Paul Walmsley
2013-09-30 10:27     ` Paul Walmsley
2013-09-30 12:14     ` Afzal Mohammed
2013-09-30 12:14       ` Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 07/11] ARM: OMAP2+: CM: AM43x clockdomain data Afzal Mohammed
2013-09-26  9:33   ` Afzal Mohammed
2013-09-30  9:31   ` Paul Walmsley
2013-09-30  9:31     ` Paul Walmsley
2013-09-30 10:16     ` Paul Walmsley
2013-09-30 10:16       ` Paul Walmsley
2013-09-30 11:05     ` Afzal Mohammed
2013-09-30 11:05       ` Afzal Mohammed
2013-09-30 11:09       ` Paul Walmsley
2013-09-30 11:09         ` Paul Walmsley
2013-09-30 11:38         ` Afzal Mohammed [this message]
2013-09-30 11:38           ` Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 08/11] ARM: OMAP2+: hwmod: AM43x support Afzal Mohammed
2013-09-26  9:33   ` Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 09/11] ARM: OMAP2+: hwmod: AM43x operations Afzal Mohammed
2013-09-26  9:33   ` Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 10/11] ARM: OMAP2+: AM43x: PRCM kbuild Afzal Mohammed
2013-09-26  9:33   ` Afzal Mohammed
2013-09-26  9:33 ` [PATCH v4 11/11] ARM: OMAP2+: AM43x PRCM init Afzal Mohammed
2013-09-26  9:33   ` Afzal Mohammed
2013-09-26 10:30 ` [PATCH v4 00/11] ARM: OMAP2+: AM43x PRCM basic support Afzal Mohammed
2013-09-26 10:30   ` Afzal Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524962A4.5080405@ti.com \
    --to=afzal@ti.com \
    --cc=ambresh@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.