From: Afzal Mohammed <afzal@ti.com>
To: Paul Walmsley <paul@pwsan.com>, Ambresh K <ambresh@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>, Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH v4 07/11] ARM: OMAP2+: CM: AM43x clockdomain data
Date: Mon, 30 Sep 2013 16:35:39 +0530 [thread overview]
Message-ID: <52495B03.3050006@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309300927520.17980@utopia.booyaka.com>
Hi Paul,
On Monday 30 September 2013 03:01 PM, Paul Walmsley wrote:
> On Thu, 26 Sep 2013, Afzal Mohammed wrote:
>> From: Ambresh K <ambresh@ti.com>
>>
>> Add the data file to describe clock domains in AM43x SoC.
>> OMAP4 clockdomain operations is being reused here.
>>
>> Signed-off-by: Ambresh K <ambresh@ti.com>
>> Signed-off-by: Afzal Mohammed <afzal@ti.com>
>> ---
>> arch/arm/mach-omap2/clockdomain.h | 2 +
>> arch/arm/mach-omap2/clockdomains43xx_data.c | 196 ++++++++++++++++++++++++++++
>> arch/arm/mach-omap2/cminst44xx.c | 9 ++
>> 3 files changed, 207 insertions(+)
>> create mode 100644 arch/arm/mach-omap2/clockdomains43xx_data.c
>>
>
> ...
>
>> diff --git a/arch/arm/mach-omap2/clockdomains43xx_data.c b/arch/arm/mach-omap2/clockdomains43xx_data.c
>> new file mode 100644
>> index 0000000..6d71c60
>> --- /dev/null
>> +++ b/arch/arm/mach-omap2/clockdomains43xx_data.c
>> @@ -0,0 +1,196 @@
>
> ...
>
>> +static struct clockdomain l3s_tsc_43xx_clkdm = {
>> + .name = "l3s_tsc_clkdm",
>> + .pwrdm = { .name = "wkup_pwrdm" },
>> + .prcm_partition = AM43XX_CM_PARTITION,
>> + .cm_inst = AM43XX_CM_WKUP_INST,
>> + .clkdm_offs = AM43XX_CM_WKUP_L3S_TSC_CDOFFS,
>> + .flags = CLKDM_CAN_SWSUP,
>> +};
> The references to "wkup_pwrdm" on some of these clockdomains don't
> look right to me. For example, this clockdomain is listed as being in
> AM43XX_CM_WKUP_INST, but its enclosing powerdomain is listed as being in
> AM43XX_PRM_WKUP_INST. Looks to me like it's best to have two different
> wakeup powerdomains: one CM_WKUP, and one PRM_WKUP.
On AM43x, prcm is a single block as in AM335x and is part of wakeup
domain. This is different from OMAP4 that had separate prm and cm
blocks. Script also generated the same output.
Regards
Afzal
WARNING: multiple messages have this Message-ID (diff)
From: afzal@ti.com (Afzal Mohammed)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 07/11] ARM: OMAP2+: CM: AM43x clockdomain data
Date: Mon, 30 Sep 2013 16:35:39 +0530 [thread overview]
Message-ID: <52495B03.3050006@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309300927520.17980@utopia.booyaka.com>
Hi Paul,
On Monday 30 September 2013 03:01 PM, Paul Walmsley wrote:
> On Thu, 26 Sep 2013, Afzal Mohammed wrote:
>> From: Ambresh K <ambresh@ti.com>
>>
>> Add the data file to describe clock domains in AM43x SoC.
>> OMAP4 clockdomain operations is being reused here.
>>
>> Signed-off-by: Ambresh K <ambresh@ti.com>
>> Signed-off-by: Afzal Mohammed <afzal@ti.com>
>> ---
>> arch/arm/mach-omap2/clockdomain.h | 2 +
>> arch/arm/mach-omap2/clockdomains43xx_data.c | 196 ++++++++++++++++++++++++++++
>> arch/arm/mach-omap2/cminst44xx.c | 9 ++
>> 3 files changed, 207 insertions(+)
>> create mode 100644 arch/arm/mach-omap2/clockdomains43xx_data.c
>>
>
> ...
>
>> diff --git a/arch/arm/mach-omap2/clockdomains43xx_data.c b/arch/arm/mach-omap2/clockdomains43xx_data.c
>> new file mode 100644
>> index 0000000..6d71c60
>> --- /dev/null
>> +++ b/arch/arm/mach-omap2/clockdomains43xx_data.c
>> @@ -0,0 +1,196 @@
>
> ...
>
>> +static struct clockdomain l3s_tsc_43xx_clkdm = {
>> + .name = "l3s_tsc_clkdm",
>> + .pwrdm = { .name = "wkup_pwrdm" },
>> + .prcm_partition = AM43XX_CM_PARTITION,
>> + .cm_inst = AM43XX_CM_WKUP_INST,
>> + .clkdm_offs = AM43XX_CM_WKUP_L3S_TSC_CDOFFS,
>> + .flags = CLKDM_CAN_SWSUP,
>> +};
> The references to "wkup_pwrdm" on some of these clockdomains don't
> look right to me. For example, this clockdomain is listed as being in
> AM43XX_CM_WKUP_INST, but its enclosing powerdomain is listed as being in
> AM43XX_PRM_WKUP_INST. Looks to me like it's best to have two different
> wakeup powerdomains: one CM_WKUP, and one PRM_WKUP.
On AM43x, prcm is a single block as in AM335x and is part of wakeup
domain. This is different from OMAP4 that had separate prm and cm
blocks. Script also generated the same output.
Regards
Afzal
next prev parent reply other threads:[~2013-09-30 11:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 9:28 [PATCH v4 00/11] ARM: OMAP2+: AM43x PRCM basic support Afzal Mohammed
2013-09-26 9:28 ` Afzal Mohammed
2013-09-26 9:32 ` [PATCH v4 01/11] ARM: OMAP2+: CM: cm_inst offset s16->u16 Afzal Mohammed
2013-09-26 9:32 ` Afzal Mohammed
2013-09-30 3:23 ` Paul Walmsley
2013-09-30 3:23 ` Paul Walmsley
2013-09-30 8:50 ` Afzal Mohammed
2013-09-30 8:50 ` Afzal Mohammed
2013-09-26 9:32 ` [PATCH v4 03/11] ARM: OMAP2+: hwmod: AM335x: runtime register update Afzal Mohammed
2013-09-26 9:32 ` Afzal Mohammed
2013-09-26 9:32 ` [PATCH v4 04/11] ARM: OMAP2+: hwmod: AM335x: remove static register offs Afzal Mohammed
2013-09-26 9:32 ` Afzal Mohammed
2013-09-26 9:32 ` [PATCH v4 05/11] ARM: OMAP2+: PRCM: AM43x definitions Afzal Mohammed
2013-09-26 9:32 ` Afzal Mohammed
2013-09-26 9:33 ` [PATCH v4 06/11] ARM: OMAP2+: PM: AM43x powerdomain data Afzal Mohammed
2013-09-26 9:33 ` Afzal Mohammed
2013-09-30 10:27 ` Paul Walmsley
2013-09-30 10:27 ` Paul Walmsley
2013-09-30 12:14 ` Afzal Mohammed
2013-09-30 12:14 ` Afzal Mohammed
2013-09-26 9:33 ` [PATCH v4 07/11] ARM: OMAP2+: CM: AM43x clockdomain data Afzal Mohammed
2013-09-26 9:33 ` Afzal Mohammed
2013-09-30 9:31 ` Paul Walmsley
2013-09-30 9:31 ` Paul Walmsley
2013-09-30 10:16 ` Paul Walmsley
2013-09-30 10:16 ` Paul Walmsley
2013-09-30 11:05 ` Afzal Mohammed [this message]
2013-09-30 11:05 ` Afzal Mohammed
2013-09-30 11:09 ` Paul Walmsley
2013-09-30 11:09 ` Paul Walmsley
2013-09-30 11:38 ` Afzal Mohammed
2013-09-30 11:38 ` Afzal Mohammed
2013-09-26 9:33 ` [PATCH v4 08/11] ARM: OMAP2+: hwmod: AM43x support Afzal Mohammed
2013-09-26 9:33 ` Afzal Mohammed
2013-09-26 9:33 ` [PATCH v4 09/11] ARM: OMAP2+: hwmod: AM43x operations Afzal Mohammed
2013-09-26 9:33 ` Afzal Mohammed
2013-09-26 9:33 ` [PATCH v4 10/11] ARM: OMAP2+: AM43x: PRCM kbuild Afzal Mohammed
2013-09-26 9:33 ` Afzal Mohammed
2013-09-26 9:33 ` [PATCH v4 11/11] ARM: OMAP2+: AM43x PRCM init Afzal Mohammed
2013-09-26 9:33 ` Afzal Mohammed
2013-09-26 10:30 ` [PATCH v4 00/11] ARM: OMAP2+: AM43x PRCM basic support Afzal Mohammed
2013-09-26 10:30 ` Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52495B03.3050006@ti.com \
--to=afzal@ti.com \
--cc=ambresh@ti.com \
--cc=bcousson@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.