From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs
Date: Tue, 01 Oct 2013 09:57:44 -0600 [thread overview]
Message-ID: <524AF0F8.3050008@wwwdotorg.org> (raw)
In-Reply-To: <20131001080829.GJ2548@pengutronix.de>
On 10/01/2013 02:08 AM, Uwe Kleine-K?nig wrote:
> On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote:
>> On 09/16/2013 11:44 AM, Uwe Kleine-K?nig wrote:
>>> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>>> ---
>>> Hello,
>>>
>>> I'm not sure that the way I implemented if a given timer is used as
>>> clock_source or clock_event_device is robust. Does it need locking?
>>> The reason to create a timer device for each timer instead of a single
>>> device of all of them is that it makes it cleaner to specify irqs and
>>> clks which each timer has one of each respectively. I didn't find an
>>> example, but while looking I wondered if in zevio-timer.c a single timer
>>> can really support both clock_event and clocksource.
>>>
>>> I guess for inclusion I need to write a document describing the
>>> of-binding. I will include that in the next iteration.
>>
>> Right and a nice description of the timer would be valuable.
> Where is the location to put a device tree binding document for a
> clocksource/clock event device? I found
>
> arm,armv7-timer-mem | arm/arch_timer.txt
> fsl,timrot | N/A
> nvidia,tegra20-rtc | rtc/nvidia,tegra20-rtc.txt
The Tegra example isn't a good one here, since the Tegra HW block is
primarily an RTC (hence the location of the binding file), which also
happens to be able to act as the clocksource.
> Should I introduce a "clocksource" directory below
> Documentation/devicetree/bindings?
That seems reasonable for any HW block that is truly purely a
clocksource. However, you'd want to also check with all the other DT
bindings maintainers.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs
Date: Tue, 01 Oct 2013 09:57:44 -0600 [thread overview]
Message-ID: <524AF0F8.3050008@wwwdotorg.org> (raw)
In-Reply-To: <20131001080829.GJ2548@pengutronix.de>
On 10/01/2013 02:08 AM, Uwe Kleine-König wrote:
> On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote:
>> On 09/16/2013 11:44 AM, Uwe Kleine-König wrote:
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>> ---
>>> Hello,
>>>
>>> I'm not sure that the way I implemented if a given timer is used as
>>> clock_source or clock_event_device is robust. Does it need locking?
>>> The reason to create a timer device for each timer instead of a single
>>> device of all of them is that it makes it cleaner to specify irqs and
>>> clks which each timer has one of each respectively. I didn't find an
>>> example, but while looking I wondered if in zevio-timer.c a single timer
>>> can really support both clock_event and clocksource.
>>>
>>> I guess for inclusion I need to write a document describing the
>>> of-binding. I will include that in the next iteration.
>>
>> Right and a nice description of the timer would be valuable.
> Where is the location to put a device tree binding document for a
> clocksource/clock event device? I found
>
> arm,armv7-timer-mem | arm/arch_timer.txt
> fsl,timrot | N/A
> nvidia,tegra20-rtc | rtc/nvidia,tegra20-rtc.txt
The Tegra example isn't a good one here, since the Tegra HW block is
primarily an RTC (hence the location of the binding file), which also
happens to be able to act as the clocksource.
> Should I introduce a "clocksource" directory below
> Documentation/devicetree/bindings?
That seems reasonable for any HW block that is truly purely a
clocksource. However, you'd want to also check with all the other DT
bindings maintainers.
next prev parent reply other threads:[~2013-10-01 15:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 9:44 [RFC, PATCH] clocksource: provide timekeeping for efm32 SoCs Uwe Kleine-König
2013-09-16 9:44 ` Uwe Kleine-König
2013-09-25 14:33 ` Daniel Lezcano
2013-09-25 14:33 ` Daniel Lezcano
2013-09-25 15:32 ` Uwe Kleine-König
2013-09-25 15:32 ` Uwe Kleine-König
2013-09-25 23:49 ` Daniel Lezcano
2013-09-25 23:49 ` Daniel Lezcano
2013-09-25 23:55 ` John Stultz
2013-09-25 23:55 ` John Stultz
2013-09-26 7:58 ` Uwe Kleine-König
2013-09-26 7:58 ` Uwe Kleine-König
2013-09-26 8:20 ` Uwe Kleine-König
2013-09-26 8:20 ` Uwe Kleine-König
2013-09-26 8:52 ` Daniel Lezcano
2013-09-26 8:52 ` Daniel Lezcano
2013-09-26 9:05 ` Uwe Kleine-König
2013-09-26 9:05 ` Uwe Kleine-König
2013-10-01 8:08 ` Uwe Kleine-König
2013-10-01 8:08 ` Uwe Kleine-König
2013-10-01 15:57 ` Stephen Warren [this message]
2013-10-01 15:57 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524AF0F8.3050008@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.