From: "Philippe Rétornaz" <philippe.retornaz@epfl.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Mark Brown <broonie@kernel.org>, Shawn Guo <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH 1/2] ASoC: fsl: imx-ssi: fix probe on imx31
Date: Mon, 07 Oct 2013 11:07:24 +0200 [thread overview]
Message-ID: <525279CC.8080309@epfl.ch> (raw)
In-Reply-To: <CAOMZO5C_kjTJ8iVGc67pcLLaO43arTiyMRQ1822VkBLDm7hzPw@mail.gmail.com>
Hello
Le 04/10/2013 20:10, Fabio Estevam a écrit :
> On Thu, Oct 3, 2013 at 1:07 PM, Philippe Rétornaz wrote
>> It was working but it is broken since a few release. There is no
>> need to rush for a fix, both patches can follow the standard
>> process.
>
> We have been using sound/soc/fsl/fsl_ssi.c for the dt imx and
> powerpc parts, and that's probably the reason we haven't noticed this
> bug.
Well, I don't think it's fair to break boards just because they are not
(yet) converted to DT ... this board was merged before the DT era on ARM.
Anyway even on DT it's broken: before the switch to the common asoc pcm
code, the dma API was misused to let it think that the audio part of the
SoC was doing the bus mastering, while in fact the sdma was doing it.
Regards,
Philippe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: philippe.retornaz@epfl.ch (Philippe Rétornaz)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/2] ASoC: fsl: imx-ssi: fix probe on imx31
Date: Mon, 07 Oct 2013 11:07:24 +0200 [thread overview]
Message-ID: <525279CC.8080309@epfl.ch> (raw)
In-Reply-To: <CAOMZO5C_kjTJ8iVGc67pcLLaO43arTiyMRQ1822VkBLDm7hzPw@mail.gmail.com>
Hello
Le 04/10/2013 20:10, Fabio Estevam a ?crit :
> On Thu, Oct 3, 2013 at 1:07 PM, Philippe R?tornaz wrote
>> It was working but it is broken since a few release. There is no
>> need to rush for a fix, both patches can follow the standard
>> process.
>
> We have been using sound/soc/fsl/fsl_ssi.c for the dt imx and
> powerpc parts, and that's probably the reason we haven't noticed this
> bug.
Well, I don't think it's fair to break boards just because they are not
(yet) converted to DT ... this board was merged before the DT era on ARM.
Anyway even on DT it's broken: before the switch to the common asoc pcm
code, the dma API was misused to let it think that the audio part of the
SoC was doing the bus mastering, while in fact the sdma was doing it.
Regards,
Philippe
next prev parent reply other threads:[~2013-10-07 9:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 12:36 [PATCH 0/2] ASoC: fix sound on mx31moboard Philippe Rétornaz
2013-10-01 12:36 ` Philippe Rétornaz
2013-10-01 12:36 ` [PATCH 1/2] ASoC: fsl: imx-ssi: fix probe on imx31 Philippe Rétornaz
2013-10-01 12:36 ` Philippe Rétornaz
2013-10-01 12:36 ` [PATCH 2/2] ASoC: fsl: Fix sound on mx31moboard Philippe Rétornaz
2013-10-01 12:36 ` Philippe Rétornaz
2013-10-03 16:00 ` Mark Brown
2013-10-03 16:00 ` Mark Brown
2013-10-03 15:59 ` [PATCH 1/2] ASoC: fsl: imx-ssi: fix probe on imx31 Mark Brown
2013-10-03 15:59 ` Mark Brown
2013-10-03 16:07 ` Philippe Rétornaz
2013-10-03 16:07 ` Philippe Rétornaz
2013-10-04 18:10 ` Fabio Estevam
2013-10-04 18:10 ` [alsa-devel] " Fabio Estevam
2013-10-07 9:07 ` Philippe Rétornaz [this message]
2013-10-07 9:07 ` Philippe Rétornaz
2013-10-07 10:29 ` Fabio Estevam
2013-10-07 10:29 ` Fabio Estevam
2013-10-07 10:17 ` Mark Brown
2013-10-07 10:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525279CC.8080309@epfl.ch \
--to=philippe.retornaz@epfl.ch \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.