From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: SmartMIPS: Fix build
Date: Mon, 7 Oct 2013 16:29:07 +0100 [thread overview]
Message-ID: <5252D343.6090100@imgtec.com> (raw)
In-Reply-To: <1381158642-10598-1-git-send-email-treding@nvidia.com>
On 10/07/13 16:10, Thierry Reding wrote:
> All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
> the ACX register declaration in struct pt_regs is still protected by it,
> causing builds to fail. Remove the #ifdef protection and always declare
> the register.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/mips/include/asm/ptrace.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7bba9da..d47bdce 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -33,9 +33,7 @@ struct pt_regs {
> unsigned long cp0_status;
> unsigned long hi;
> unsigned long lo;
> -#ifdef CONFIG_CPU_HAS_SMARTMIPS
> unsigned long acx;
> -#endif
> unsigned long cp0_badvaddr;
> unsigned long cp0_cause;
> unsigned long cp0_epc;
>
Hi Thierry,
Looks good to me. Thanks!
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: SmartMIPS: Fix build
Date: Mon, 7 Oct 2013 16:29:07 +0100 [thread overview]
Message-ID: <5252D343.6090100@imgtec.com> (raw)
Message-ID: <20131007152907.gAVQyiutopqwZ2nd6ofoH3TpjYQ8PhXPZIEibx64xDc@z> (raw)
In-Reply-To: <1381158642-10598-1-git-send-email-treding@nvidia.com>
On 10/07/13 16:10, Thierry Reding wrote:
> All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
> the ACX register declaration in struct pt_regs is still protected by it,
> causing builds to fail. Remove the #ifdef protection and always declare
> the register.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/mips/include/asm/ptrace.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7bba9da..d47bdce 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -33,9 +33,7 @@ struct pt_regs {
> unsigned long cp0_status;
> unsigned long hi;
> unsigned long lo;
> -#ifdef CONFIG_CPU_HAS_SMARTMIPS
> unsigned long acx;
> -#endif
> unsigned long cp0_badvaddr;
> unsigned long cp0_cause;
> unsigned long cp0_epc;
>
Hi Thierry,
Looks good to me. Thanks!
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
next prev parent reply other threads:[~2013-10-07 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 15:10 [PATCH] MIPS: SmartMIPS: Fix build Thierry Reding
2013-10-07 15:29 ` Markos Chandras [this message]
2013-10-07 15:29 ` Markos Chandras
2013-10-07 15:58 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5252D343.6090100@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.