* [PATCH] MIPS: SmartMIPS: Fix build
@ 2013-10-07 15:10 Thierry Reding
2013-10-07 15:29 ` Markos Chandras
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2013-10-07 15:10 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, linux-kernel
All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
the ACX register declaration in struct pt_regs is still protected by it,
causing builds to fail. Remove the #ifdef protection and always declare
the register.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/mips/include/asm/ptrace.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
index 7bba9da..d47bdce 100644
--- a/arch/mips/include/asm/ptrace.h
+++ b/arch/mips/include/asm/ptrace.h
@@ -33,9 +33,7 @@ struct pt_regs {
unsigned long cp0_status;
unsigned long hi;
unsigned long lo;
-#ifdef CONFIG_CPU_HAS_SMARTMIPS
unsigned long acx;
-#endif
unsigned long cp0_badvaddr;
unsigned long cp0_cause;
unsigned long cp0_epc;
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: SmartMIPS: Fix build
@ 2013-10-07 15:29 ` Markos Chandras
0 siblings, 0 replies; 4+ messages in thread
From: Markos Chandras @ 2013-10-07 15:29 UTC (permalink / raw)
To: Thierry Reding, Ralf Baechle; +Cc: linux-mips, linux-kernel
On 10/07/13 16:10, Thierry Reding wrote:
> All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
> the ACX register declaration in struct pt_regs is still protected by it,
> causing builds to fail. Remove the #ifdef protection and always declare
> the register.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/mips/include/asm/ptrace.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7bba9da..d47bdce 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -33,9 +33,7 @@ struct pt_regs {
> unsigned long cp0_status;
> unsigned long hi;
> unsigned long lo;
> -#ifdef CONFIG_CPU_HAS_SMARTMIPS
> unsigned long acx;
> -#endif
> unsigned long cp0_badvaddr;
> unsigned long cp0_cause;
> unsigned long cp0_epc;
>
Hi Thierry,
Looks good to me. Thanks!
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: SmartMIPS: Fix build
@ 2013-10-07 15:29 ` Markos Chandras
0 siblings, 0 replies; 4+ messages in thread
From: Markos Chandras @ 2013-10-07 15:29 UTC (permalink / raw)
To: Thierry Reding, Ralf Baechle; +Cc: linux-mips, linux-kernel
On 10/07/13 16:10, Thierry Reding wrote:
> All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
> the ACX register declaration in struct pt_regs is still protected by it,
> causing builds to fail. Remove the #ifdef protection and always declare
> the register.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/mips/include/asm/ptrace.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> index 7bba9da..d47bdce 100644
> --- a/arch/mips/include/asm/ptrace.h
> +++ b/arch/mips/include/asm/ptrace.h
> @@ -33,9 +33,7 @@ struct pt_regs {
> unsigned long cp0_status;
> unsigned long hi;
> unsigned long lo;
> -#ifdef CONFIG_CPU_HAS_SMARTMIPS
> unsigned long acx;
> -#endif
> unsigned long cp0_badvaddr;
> unsigned long cp0_cause;
> unsigned long cp0_epc;
>
Hi Thierry,
Looks good to me. Thanks!
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] MIPS: SmartMIPS: Fix build
2013-10-07 15:29 ` Markos Chandras
(?)
@ 2013-10-07 15:58 ` Ralf Baechle
-1 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2013-10-07 15:58 UTC (permalink / raw)
To: Markos Chandras; +Cc: Thierry Reding, linux-mips, linux-kernel
On Mon, Oct 07, 2013 at 04:29:07PM +0100, Markos Chandras wrote:
> On 10/07/13 16:10, Thierry Reding wrote:
> >All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
> >the ACX register declaration in struct pt_regs is still protected by it,
> >causing builds to fail. Remove the #ifdef protection and always declare
> >the register.
> >
> >Signed-off-by: Thierry Reding <treding@nvidia.com>
> >---
> > arch/mips/include/asm/ptrace.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> >diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> >index 7bba9da..d47bdce 100644
> >--- a/arch/mips/include/asm/ptrace.h
> >+++ b/arch/mips/include/asm/ptrace.h
> >@@ -33,9 +33,7 @@ struct pt_regs {
> > unsigned long cp0_status;
> > unsigned long hi;
> > unsigned long lo;
> >-#ifdef CONFIG_CPU_HAS_SMARTMIPS
> > unsigned long acx;
> >-#endif
> > unsigned long cp0_badvaddr;
> > unsigned long cp0_cause;
> > unsigned long cp0_epc;
> >
>
> Hi Thierry,
>
> Looks good to me. Thanks!
>
> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Looking good - but I've already pulled the offending patch. Processor
specific registers in the register frame have historically been a PITA -
in particular because much of what's requiring space there is also
requiring space in the signal frame and that's a kernel ABI.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-07 15:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-07 15:10 [PATCH] MIPS: SmartMIPS: Fix build Thierry Reding
2013-10-07 15:29 ` Markos Chandras
2013-10-07 15:29 ` Markos Chandras
2013-10-07 15:58 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.