All of lore.kernel.org
 help / color / mirror / Atom feed
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] clk: palmas: add clock driver for palmas
Date: Tue, 08 Oct 2013 11:08:43 -0600	[thread overview]
Message-ID: <52543C1B.3000403@wwwdotorg.org> (raw)
In-Reply-To: <52542F69.30407@ti.com>

On 10/08/2013 10:14 AM, Nishanth Menon wrote:
> On 10/08/2013 09:39 AM, Laxman Dewangan wrote:
>> Thanks Nishanth for review.
>>
>> On Tuesday 08 October 2013 06:59 PM, Nishanth Menon wrote:
>>> On 10/08/2013 08:21 AM, Laxman Dewangan wrote:
>>>> Palmas devices has two clock output CLK32K_KG and CLK32K_KG_AUDIO
>>> not all palmas devices have 2 clocks - example: tps659038
>>
>> This is for generic palmas and I have seen it for TPS65913, TPS65914, 
>> TPS80036. If the generic one is not compatible then it need to add  
>> device specific and at that time, it is require to update the binding 
>> document accordingly.
> 
> ?? you do have two clocks inside the device they should be represented
> as two compatible entities - that simplifies everyone's life.

I think the terminology you're using here is quite confusing.

Are you talking about having two different compatible values for two
different HW designs, where those different designs implement different
sets of clocks (which makes sense), or two different DT nodes for two
different clocks (which IMHO doesn't always, unless those different
clocks *truly* are separate IP blocks with completely independent
register regions, and where those IP blocks are likely to be re-used
as-is in other chips).

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Nishanth Menon <nm@ti.com>, Laxman Dewangan <ldewangan@nvidia.com>
Cc: "mturquette@linaro.org" <mturquette@linaro.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Stephen Warren <swarren@nvidia.com>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"broonie@linaro.org" <broonie@linaro.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"rob@landley.net" <rob@landley.net>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	J Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH V3] clk: palmas: add clock driver for palmas
Date: Tue, 08 Oct 2013 11:08:43 -0600	[thread overview]
Message-ID: <52543C1B.3000403@wwwdotorg.org> (raw)
In-Reply-To: <52542F69.30407@ti.com>

On 10/08/2013 10:14 AM, Nishanth Menon wrote:
> On 10/08/2013 09:39 AM, Laxman Dewangan wrote:
>> Thanks Nishanth for review.
>>
>> On Tuesday 08 October 2013 06:59 PM, Nishanth Menon wrote:
>>> On 10/08/2013 08:21 AM, Laxman Dewangan wrote:
>>>> Palmas devices has two clock output CLK32K_KG and CLK32K_KG_AUDIO
>>> not all palmas devices have 2 clocks - example: tps659038
>>
>> This is for generic palmas and I have seen it for TPS65913, TPS65914, 
>> TPS80036. If the generic one is not compatible then it need to add  
>> device specific and at that time, it is require to update the binding 
>> document accordingly.
> 
> ?? you do have two clocks inside the device they should be represented
> as two compatible entities - that simplifies everyone's life.

I think the terminology you're using here is quite confusing.

Are you talking about having two different compatible values for two
different HW designs, where those different designs implement different
sets of clocks (which makes sense), or two different DT nodes for two
different clocks (which IMHO doesn't always, unless those different
clocks *truly* are separate IP blocks with completely independent
register regions, and where those IP blocks are likely to be re-used
as-is in other chips).


  reply	other threads:[~2013-10-08 17:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 13:21 [PATCH V3] clk: palmas: add clock driver for palmas Laxman Dewangan
2013-10-08 13:21 ` Laxman Dewangan
2013-10-08 13:21 ` Laxman Dewangan
2013-10-08 13:29 ` Nishanth Menon
2013-10-08 13:29   ` Nishanth Menon
2013-10-08 13:29   ` Nishanth Menon
2013-10-08 14:39   ` Laxman Dewangan
2013-10-08 14:39     ` Laxman Dewangan
2013-10-08 15:28     ` Mark Rutland
2013-10-08 15:28       ` Mark Rutland
2013-10-09  9:43       ` Laxman Dewangan
2013-10-09  9:43         ` Laxman Dewangan
2013-10-08 16:14     ` Nishanth Menon
2013-10-08 16:14       ` Nishanth Menon
2013-10-08 17:08       ` Stephen Warren [this message]
2013-10-08 17:08         ` Stephen Warren
2013-10-08 17:33         ` Nishanth Menon
2013-10-08 17:33           ` Nishanth Menon
2013-10-08 20:43           ` Stephen Warren
2013-10-08 20:43             ` Stephen Warren
2013-10-08 21:05             ` Nishanth Menon
2013-10-08 21:05               ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52543C1B.3000403@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.