All of lore.kernel.org
 help / color / mirror / Atom feed
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] clk: palmas: add clock driver for palmas
Date: Wed, 9 Oct 2013 15:13:41 +0530	[thread overview]
Message-ID: <5255254D.4090108@nvidia.com> (raw)
In-Reply-To: <20131008152812.GA4981@e106331-lin.cambridge.arm.com>

On Tuesday 08 October 2013 08:58 PM, Mark Rutland wrote:
> On Tue, Oct 08, 2013 at 03:39:54PM +0100, Laxman Dewangan wrote:
>>
>>>> +
>>>> +     Optional subnode properties:
>>>> +     ti,clock-boot-enable: Enable clock at the time of booting.
>>> Dumb question: Why is this needed? should'nt relevant drivers do a
>>> clk_get to enable the relevant clocks?
>> If some board needs this clock to be always available for rest of system
>> to work without any specific driver then this flag is useful.
> Do we _actually_ need this right now, or is this hypothetical?
>
> If we don't need it now, remove it. If you think we need it know, please
> describe exactly why (i.e. what device needs the clock to work, why does
> this affect the rest of the board if we don't ahve a driver for that
> device, why don't we just write a driver for that device).
>

Ok, I will remove it. Going with nothing free of cost for the 
driver/system and client need to call the proper APIs.

>>
>>>> +     ti,external-sleep-control: The clock is enable/disabled by state
>>>> +             of external enable input pins ENABLE, ENABLE2 and NSLEEP.
>>>> +             The valid value for the external pins are:
>>>> +                     1 for ENABLE1
>>>> +                     2 for ENABLE2
>>>> +                     3 for NSLEEP.
> I asked this on the last version (before having noticed this one). What
> actually drives those pins to control the clock(s)?
>
> Is this for setting the clock to be controlled by the external pin, or
> is the clock hard-wired to a particular pin?
>

This is for setting the clock to be controlled by the external pin.

WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Nishanth Menon <nm@ti.com>,
	"mturquette@linaro.org" <mturquette@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Stephen Warren <swarren@nvidia.com>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"broonie@linaro.org" <broonie@linaro.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"rob@landley.net" <rob@landley.net>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	J Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH V3] clk: palmas: add clock driver for palmas
Date: Wed, 9 Oct 2013 15:13:41 +0530	[thread overview]
Message-ID: <5255254D.4090108@nvidia.com> (raw)
In-Reply-To: <20131008152812.GA4981@e106331-lin.cambridge.arm.com>

On Tuesday 08 October 2013 08:58 PM, Mark Rutland wrote:
> On Tue, Oct 08, 2013 at 03:39:54PM +0100, Laxman Dewangan wrote:
>>
>>>> +
>>>> +     Optional subnode properties:
>>>> +     ti,clock-boot-enable: Enable clock at the time of booting.
>>> Dumb question: Why is this needed? should'nt relevant drivers do a
>>> clk_get to enable the relevant clocks?
>> If some board needs this clock to be always available for rest of system
>> to work without any specific driver then this flag is useful.
> Do we _actually_ need this right now, or is this hypothetical?
>
> If we don't need it now, remove it. If you think we need it know, please
> describe exactly why (i.e. what device needs the clock to work, why does
> this affect the rest of the board if we don't ahve a driver for that
> device, why don't we just write a driver for that device).
>

Ok, I will remove it. Going with nothing free of cost for the 
driver/system and client need to call the proper APIs.

>>
>>>> +     ti,external-sleep-control: The clock is enable/disabled by state
>>>> +             of external enable input pins ENABLE, ENABLE2 and NSLEEP.
>>>> +             The valid value for the external pins are:
>>>> +                     1 for ENABLE1
>>>> +                     2 for ENABLE2
>>>> +                     3 for NSLEEP.
> I asked this on the last version (before having noticed this one). What
> actually drives those pins to control the clock(s)?
>
> Is this for setting the clock to be controlled by the external pin, or
> is the clock hard-wired to a particular pin?
>

This is for setting the clock to be controlled by the external pin.


  reply	other threads:[~2013-10-09  9:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 13:21 [PATCH V3] clk: palmas: add clock driver for palmas Laxman Dewangan
2013-10-08 13:21 ` Laxman Dewangan
2013-10-08 13:21 ` Laxman Dewangan
2013-10-08 13:29 ` Nishanth Menon
2013-10-08 13:29   ` Nishanth Menon
2013-10-08 13:29   ` Nishanth Menon
2013-10-08 14:39   ` Laxman Dewangan
2013-10-08 14:39     ` Laxman Dewangan
2013-10-08 15:28     ` Mark Rutland
2013-10-08 15:28       ` Mark Rutland
2013-10-09  9:43       ` Laxman Dewangan [this message]
2013-10-09  9:43         ` Laxman Dewangan
2013-10-08 16:14     ` Nishanth Menon
2013-10-08 16:14       ` Nishanth Menon
2013-10-08 17:08       ` Stephen Warren
2013-10-08 17:08         ` Stephen Warren
2013-10-08 17:33         ` Nishanth Menon
2013-10-08 17:33           ` Nishanth Menon
2013-10-08 20:43           ` Stephen Warren
2013-10-08 20:43             ` Stephen Warren
2013-10-08 21:05             ` Nishanth Menon
2013-10-08 21:05               ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5255254D.4090108@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.