From: Afzal Mohammed <afzal@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: wakeupgen: AM43x adaptation
Date: Wed, 9 Oct 2013 12:52:47 +0530 [thread overview]
Message-ID: <52550447.5070805@ti.com> (raw)
In-Reply-To: <20131008212436.GR8313@atomide.com>
Hi Tony,
On Wednesday 09 October 2013 02:54 AM, Tony Lindgren wrote:
> * Afzal Mohammed <afzal@ti.com> [130905 04:03]:
>> -#define MAX_NR_REG_BANKS 5
>> -#define MAX_IRQS 160
>> +/* maximum value correspond to that of AM43x */
>> +#define MAX_NR_REG_BANKS 7
>> +#define MAX_IRQS 224
>> +#define DEFAULT_NR_REG_BANKS 5
>> +#define DEFAULT_IRQS 160
>> #define WKG_MASK_ALL 0x00000000
>> #define WKG_UNMASK_ALL 0xffffffff
>> #define CPU_ENA_OFFSET 0x400
>
> How about define it like this to avoid updating things
> in multiple places for new SoCs:
>
> #define AM43X_NR_REG_BANKS 7
> #define MAX_NR_REG_BANKS AM43X_NR_REG_BANKS
Yes that is better
>> for (i = 0; i < irq_banks; i++) {
>> wakeupgen_writel(0, i, CPU0_ID);
>> - wakeupgen_writel(0, i, CPU1_ID);
>> + if (!am43x)
>> + wakeupgen_writel(0, i, CPU1_ID);
>> }
>
> Why not use soc_is_am43xx() directly here?
Ok, it has been changed in the new version.
Regards
Afzal
WARNING: multiple messages have this Message-ID (diff)
From: afzal@ti.com (Afzal Mohammed)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: wakeupgen: AM43x adaptation
Date: Wed, 9 Oct 2013 12:52:47 +0530 [thread overview]
Message-ID: <52550447.5070805@ti.com> (raw)
In-Reply-To: <20131008212436.GR8313@atomide.com>
Hi Tony,
On Wednesday 09 October 2013 02:54 AM, Tony Lindgren wrote:
> * Afzal Mohammed <afzal@ti.com> [130905 04:03]:
>> -#define MAX_NR_REG_BANKS 5
>> -#define MAX_IRQS 160
>> +/* maximum value correspond to that of AM43x */
>> +#define MAX_NR_REG_BANKS 7
>> +#define MAX_IRQS 224
>> +#define DEFAULT_NR_REG_BANKS 5
>> +#define DEFAULT_IRQS 160
>> #define WKG_MASK_ALL 0x00000000
>> #define WKG_UNMASK_ALL 0xffffffff
>> #define CPU_ENA_OFFSET 0x400
>
> How about define it like this to avoid updating things
> in multiple places for new SoCs:
>
> #define AM43X_NR_REG_BANKS 7
> #define MAX_NR_REG_BANKS AM43X_NR_REG_BANKS
Yes that is better
>> for (i = 0; i < irq_banks; i++) {
>> wakeupgen_writel(0, i, CPU0_ID);
>> - wakeupgen_writel(0, i, CPU1_ID);
>> + if (!am43x)
>> + wakeupgen_writel(0, i, CPU1_ID);
>> }
>
> Why not use soc_is_am43xx() directly here?
Ok, it has been changed in the new version.
Regards
Afzal
WARNING: multiple messages have this Message-ID (diff)
From: Afzal Mohammed <afzal@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: OMAP2+: wakeupgen: AM43x adaptation
Date: Wed, 9 Oct 2013 12:52:47 +0530 [thread overview]
Message-ID: <52550447.5070805@ti.com> (raw)
In-Reply-To: <20131008212436.GR8313@atomide.com>
Hi Tony,
On Wednesday 09 October 2013 02:54 AM, Tony Lindgren wrote:
> * Afzal Mohammed <afzal@ti.com> [130905 04:03]:
>> -#define MAX_NR_REG_BANKS 5
>> -#define MAX_IRQS 160
>> +/* maximum value correspond to that of AM43x */
>> +#define MAX_NR_REG_BANKS 7
>> +#define MAX_IRQS 224
>> +#define DEFAULT_NR_REG_BANKS 5
>> +#define DEFAULT_IRQS 160
>> #define WKG_MASK_ALL 0x00000000
>> #define WKG_UNMASK_ALL 0xffffffff
>> #define CPU_ENA_OFFSET 0x400
>
> How about define it like this to avoid updating things
> in multiple places for new SoCs:
>
> #define AM43X_NR_REG_BANKS 7
> #define MAX_NR_REG_BANKS AM43X_NR_REG_BANKS
Yes that is better
>> for (i = 0; i < irq_banks; i++) {
>> wakeupgen_writel(0, i, CPU0_ID);
>> - wakeupgen_writel(0, i, CPU1_ID);
>> + if (!am43x)
>> + wakeupgen_writel(0, i, CPU1_ID);
>> }
>
> Why not use soc_is_am43xx() directly here?
Ok, it has been changed in the new version.
Regards
Afzal
next prev parent reply other threads:[~2013-10-09 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 10:55 [PATCH] ARM: OMAP2+: wakeupgen: AM43x adaptation Afzal Mohammed
2013-09-05 10:55 ` Afzal Mohammed
2013-09-05 10:55 ` Afzal Mohammed
2013-10-08 21:24 ` Tony Lindgren
2013-10-08 21:24 ` Tony Lindgren
2013-10-09 7:22 ` Afzal Mohammed [this message]
2013-10-09 7:22 ` Afzal Mohammed
2013-10-09 7:22 ` Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52550447.5070805@ti.com \
--to=afzal@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.